• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • jacoco-plugin
    • None
    • Jenkins 1.501 / Tomcat 6 / JDK 1.6.0_18 / Debian 6 / x86
      IE 9

      It would be great if a future release of the JaCoCo plugin would show the dashboard "N/A" label with white background instead of that ugly black bar.

      As only few of my projects use JaCoCo (we have lots of non-Java project running in Jenkins) most projects now show a ugly, fat black "N/A" bar, which really scares people when looking at the dashboard. If it would have a simple white background, the "N/A" would look much more friendly.

          [JENKINS-16786] Please make the "N/A" white, not black. :-)

          Jason Wooster added a comment - - edited

          I would prefer if the column was not enabled by default.
          We have a large number of jobs which don't actually build code and just execute tasks.
          And the jobs which do build code don't normally run code coverage currently (we're working on fixing that but it takes buy-in from the project teams).

          Jason Wooster added a comment - - edited I would prefer if the column was not enabled by default. We have a large number of jobs which don't actually build code and just execute tasks. And the jobs which do build code don't normally run code coverage currently (we're working on fixing that but it takes buy-in from the project teams).

          I agree with Jason, we have a couple of Jenkins jobs that do not run code coverage (they are not build jobs), and I also think that the column should rather be visible if selected instead of the opposite.

          Andreas Sandberg added a comment - I agree with Jason, we have a couple of Jenkins jobs that do not run code coverage (they are not build jobs), and I also think that the column should rather be visible if selected instead of the opposite.

          I'm also in favor of choosing whether or not display the additionnal column because in my case, only a few builds are relative to code coverage report and I don't want it to appear on dashboard. I managed to do it by deleting the embedded "JaCoCo Coverage Column plugin" which is installed by default with the JaCoCo plugin.
          Thanks.

          Laurent Schoelens added a comment - I'm also in favor of choosing whether or not display the additionnal column because in my case, only a few builds are relative to code coverage report and I don't want it to appear on dashboard. I managed to do it by deleting the embedded "JaCoCo Coverage Column plugin" which is installed by default with the JaCoCo plugin. Thanks.

          My problem exactly. I have only one job using Jacoco at the moment out of about 100 projects (many of them not using Java at all).
          It is nice to be able to add the coverage column to a specific view, but I would not want it in the "All" view.
          It should be possible to disable the coverage column from the main view; otherwise it should only be available in the other views, whose columns are editable.

          Andrea Gualano added a comment - My problem exactly. I have only one job using Jacoco at the moment out of about 100 projects (many of them not using Java at all). It is nice to be able to add the coverage column to a specific view, but I would not want it in the "All" view. It should be possible to disable the coverage column from the main view; otherwise it should only be available in the other views, whose columns are editable.

          sakkew added a comment -

          +1 for having column disabled by default.

          sakkew added a comment - +1 for having column disabled by default.

          Ognjen Bubalo added a comment -

          Hi,

          Comming soon.

          Ogi

          Ognjen Bubalo added a comment - Hi, Comming soon. Ogi

          Jason Faas added a comment -

          Another reason to move N/A to white is to differentiate it from jobs with < 5% code coverage.

          Jason Faas added a comment - Another reason to move N/A to white is to differentiate it from jobs with < 5% code coverage.

          centic added a comment -

          I have updated https://github.com/jenkinsci/jacoco-plugin/pull/19 with changes to fix the color of the column. As for not showing it by default, I couldn't find a way to do this after a quick look at the extension functionality of Jenkins, does anybody know of a plugin that does this (i.e. add a column but not by default), so I can take a look how this is done?

          centic added a comment - I have updated https://github.com/jenkinsci/jacoco-plugin/pull/19 with changes to fix the color of the column. As for not showing it by default, I couldn't find a way to do this after a quick look at the extension functionality of Jenkins, does anybody know of a plugin that does this (i.e. add a column but not by default), so I can take a look how this is done?

          Code changed in jenkins
          User: Dominik Stadler
          Path:
          src/main/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumn.java
          src/main/resources/hudson/plugins/jacococoveragecolumn/JaCoCoColumn/column.jelly
          src/test/java/hudson/plugins/jacococoveragecolumn/CoverageRangeTest.java
          src/test/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumnTest.java
          http://jenkins-ci.org/commit/jacoco-plugin/131a83673b8091d2c2575ddd60cf06982ee457d7
          Log:
          JENKINS-16786: make N/A white, not black. Also enhance unit tests for
          coverage column classes

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dominik Stadler Path: src/main/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumn.java src/main/resources/hudson/plugins/jacococoveragecolumn/JaCoCoColumn/column.jelly src/test/java/hudson/plugins/jacococoveragecolumn/CoverageRangeTest.java src/test/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumnTest.java http://jenkins-ci.org/commit/jacoco-plugin/131a83673b8091d2c2575ddd60cf06982ee457d7 Log: JENKINS-16786 : make N/A white, not black. Also enhance unit tests for coverage column classes

          Code changed in jenkins
          User: ognjenb
          Path:
          src/main/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumn.java
          src/main/resources/hudson/plugins/jacococoveragecolumn/JaCoCoColumn/column.jelly
          src/test/java/hudson/plugins/jacococoveragecolumn/CoverageRangeTest.java
          src/test/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumnTest.java
          http://jenkins-ci.org/commit/jacoco-plugin/a730ff0c1315f562bb026b5799450317d73a9bb0
          Log:
          Merge pull request #22 from centic9/JENKINS-16786

          JENKINS-16786: make coverage column show N/A as white, not black

          Compare: https://github.com/jenkinsci/jacoco-plugin/compare/b2fbab739fcc...a730ff0c1315

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ognjenb Path: src/main/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumn.java src/main/resources/hudson/plugins/jacococoveragecolumn/JaCoCoColumn/column.jelly src/test/java/hudson/plugins/jacococoveragecolumn/CoverageRangeTest.java src/test/java/hudson/plugins/jacococoveragecolumn/JaCoCoColumnTest.java http://jenkins-ci.org/commit/jacoco-plugin/a730ff0c1315f562bb026b5799450317d73a9bb0 Log: Merge pull request #22 from centic9/ JENKINS-16786 JENKINS-16786 : make coverage column show N/A as white, not black Compare: https://github.com/jenkinsci/jacoco-plugin/compare/b2fbab739fcc...a730ff0c1315

          +1 for option to enable/disable the column on the dashboard.

          Matthew Harrah added a comment - +1 for option to enable/disable the column on the dashboard.

          centic added a comment -

          I am splitting the discussion about "allow to disable the coverage column" into a separate issue as this one is more about the link-color

          centic added a comment - I am splitting the discussion about "allow to disable the coverage column" into a separate issue as this one is more about the link-color

          centic added a comment -

          The next release of jacoco-plugin should have better colouring of the N/A entries, discussion about disabling the coverage column is done in JENKINS-18894.

          centic added a comment - The next release of jacoco-plugin should have better colouring of the N/A entries, discussion about disabling the coverage column is done in JENKINS-18894 .

          centic added a comment -

          This should be included in release 1.0.13

          centic added a comment - This should be included in release 1.0.13

            centic centic
            mkarg Markus KARG
            Votes:
            9 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved: