Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17040

Grey build status "Aborted" should NOT win in nested view summary

    XMLWordPrintable

Details

    Description

      At the moment, when one of my jobs in a nested view has been aborted, the icon of the nested view is gray ("Aborted"), no matter how many yellow or red builds I have in there.

      IMHO, green/yellow/red is much more important than the "aborted" status (even if you could distinguish it from the equally gray "disabled" status, but that's another problem)

      The summary status should have the following priorities (low to high):

      • disabled (grey)
      • aborted (gray)
      • success (green)
      • test failures (yellow)
      • error (red)

      So red should always win.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          marc_guenther Marc Günther created issue -
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: stanislav bashkirtsev
          Path:
          pom.xml
          src/main/java/hudson/plugins/nested_view/NestedView.java
          http://jenkins-ci.org/commit/nested-view-plugin/8ba32de909430969250edfb51e61a63730c15f39
          Log:
          Merge pull request #11 from yoichi/JENKINS-17040

          [FIXED JENKINS-17040] give weight to completed build results in nested view status

          Compare: https://github.com/jenkinsci/nested-view-plugin/compare/cc853be35354...8ba32de90943

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: stanislav bashkirtsev Path: pom.xml src/main/java/hudson/plugins/nested_view/NestedView.java http://jenkins-ci.org/commit/nested-view-plugin/8ba32de909430969250edfb51e61a63730c15f39 Log: Merge pull request #11 from yoichi/ JENKINS-17040 [FIXED JENKINS-17040] give weight to completed build results in nested view status Compare: https://github.com/jenkinsci/nested-view-plugin/compare/cc853be35354...8ba32de90943
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          yoichi Yoichi Nakayama added a comment -

          I noticed the fix was incomplete.
          When subviews are aborted and success, then parent nested view become aborted.

          yoichi Yoichi Nakayama added a comment - I noticed the fix was incomplete. When subviews are aborted and success, then parent nested view become aborted.
          yoichi Yoichi Nakayama made changes -
          Assignee Yoichi Nakayama [ yoichi ]
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: stanislav bashkirtsev
          Path:
          src/main/java/hudson/plugins/nested_view/NestedView.java
          src/test/java/hudson/plugins/nested_view/NestedViewTest.java
          http://jenkins-ci.org/commit/nested-view-plugin/8e1ca88ebbeb0092191032ac678674d142642539
          Log:
          Merge pull request #12 from yoichi/JENKINS-17040-19716

          [FIXED JENKINS-17040][FIXED JENKINS-19716] fix status handling for nested NestedView

          Compare: https://github.com/jenkinsci/nested-view-plugin/compare/7137761528dc...8e1ca88ebbeb

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: stanislav bashkirtsev Path: src/main/java/hudson/plugins/nested_view/NestedView.java src/test/java/hudson/plugins/nested_view/NestedViewTest.java http://jenkins-ci.org/commit/nested-view-plugin/8e1ca88ebbeb0092191032ac678674d142642539 Log: Merge pull request #12 from yoichi/ JENKINS-17040 -19716 [FIXED JENKINS-17040] [FIXED JENKINS-19716] fix status handling for nested NestedView Compare: https://github.com/jenkinsci/nested-view-plugin/compare/7137761528dc...8e1ca88ebbeb
          yoichi Yoichi Nakayama added a comment -

          Fixed.
          Thanks,

          yoichi Yoichi Nakayama added a comment - Fixed. Thanks,
          yoichi Yoichi Nakayama made changes -
          Assignee Yoichi Nakayama [ yoichi ] Marc Günther [ marc_guenther ]
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Resolved [ 5 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 147871 ] JNJira + In-Review [ 192620 ]

          People

            marc_guenther Marc Günther
            marc_guenther Marc Günther
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: