• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Component/s: mercurial-plugin
• Labels:

  None
• Environment:

  Linux, Jenkis 1.506, Mercurial extension v. 1.44, mercurial 2.2

[JENKINS-17260] Mercurial Push Notifications: URLs should be compared in canonical form

Elifarley created issue - 2013-03-18 16:55

Elifarley made changes - 2013-03-18 16:56

Environment

New: Linux, Jenkis 1.506, Mercurial extension v. 1.44, mercurial 2.2

Elifarley made changes - 2013-03-18 16:57

Description

Original: The comparison of a job's repository URL and the URL passed to notifyCommit will fail when the 2 URLs differ slightly, even though they point to the same place. Example that triggers the problem: Repository URL: http://mymercurialrepo.com.br/hg/main/myproj/ hook configuration: [hooks] commit.jenkins = wget -q -O /dev/null http://myjenkins.com.br/jenkins/mercurial/notifyCommit?url=http://mymercurialrepo.com.br/hg/main/myproj incoming.jenkins = wget -q -O /dev/null http://myjenkins.com.br/jenkins/mercurial/notifyCommit?url=http://mymercurialrepo.com.br/hg/main/myproj The URL comparison should first transform both URLs to their canonical form (by appending a slash at the end if one is missing, for instance). I guess it will also fail if one of the URLs includes an HTTP redirect.

New: The comparison of a job's repository URL and the URL passed to notifyCommit will fail when the 2 URLs differ slightly, even though they point to the same place. Example that triggers the problem: Repository URL (in job configuration screen): http://mymercurialrepo.com.br/hg/main/myproj/ hook configuration: [hooks] commit.jenkins = wget -q -O /dev/null http://myjenkins.com.br/jenkins/mercurial/notifyCommit?url=http://mymercurialrepo.com.br/hg/main/myproj incoming.jenkins = wget -q -O /dev/null http://myjenkins.com.br/jenkins/mercurial/notifyCommit?url=http://mymercurialrepo.com.br/hg/main/myproj The URL comparison should first transform both URLs to their canonical form (by appending a slash at the end if one is missing, for instance). I guess it will also fail if one of the URLs includes an HTTP redirect.

Jesse Glick made changes - 2013-06-07 14:32

Priority

Original: Major [ 3 ]

New: Minor [ 4 ]

R. Tyler Croy made changes - 2016-07-25 23:50

Workflow

Original: JNJira [ 148093 ]

New: JNJira + In-Review [ 177089 ]