Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1738

Warning tags should scan for words only

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • tasks-plugin
    • None
    • Platform: All, OS: All

    Description

      If you use keyword like WARNING then it is going to report variables and any
      strings that have it like

      Stirng WARNINGS ="asdf"; IMHO it should look for keyword + ' '.

      I,E., the regular expression should be \W(Tag)\W.

      Attachments

        Issue Links

          Activity

            drulli Ulli Hafner added a comment -

            Can you please clarify: what is your expectation?

            drulli Ulli Hafner added a comment - Can you please clarify: what is your expectation?
            yellowbeard Bort Senoia added a comment -

            not working for me. I get 5 open tasks created for this field/getter/setter/annotation combo:

            private String todo; // creates a task

            @Column(name = "todo") // creates a task
            public String getTodo()
            {
            return this.todo; // creates a task
            }

            public void setTodo(String todo) // creates a task
            {
            this.todo = todo; // creates a task
            }

            yellowbeard Bort Senoia added a comment - not working for me. I get 5 open tasks created for this field/getter/setter/annotation combo: private String todo; // creates a task @Column(name = "todo") // creates a task public String getTodo() { return this.todo; // creates a task } public void setTodo(String todo) // creates a task { this.todo = todo; // creates a task }

            Code changed in hudson
            User: : drulli
            Path:
            trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/parser/TaskScanner.java
            trunk/hudson/plugins/tasks/src/test/java/hudson/plugins/tasks/parser/TaskScannerTest.java
            trunk/hudson/plugins/tasks/src/test/resources/hudson/plugins/tasks/parser/tasks-words-test.txt
            http://fisheye4.cenqua.com/changelog/hudson/?cs=10489
            Log:
            [FIXED JENKINS-1738]: scan for tasks words only, use regexp \b to ensure that we are not in the middle of a word.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : drulli Path: trunk/hudson/plugins/tasks/src/main/java/hudson/plugins/tasks/parser/TaskScanner.java trunk/hudson/plugins/tasks/src/test/java/hudson/plugins/tasks/parser/TaskScannerTest.java trunk/hudson/plugins/tasks/src/test/resources/hudson/plugins/tasks/parser/tasks-words-test.txt http://fisheye4.cenqua.com/changelog/hudson/?cs=10489 Log: [FIXED JENKINS-1738] : scan for tasks words only, use regexp \b to ensure that we are not in the middle of a word.

            People

              drulli Ulli Hafner
              drulli Ulli Hafner
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: