Details
-
New Feature
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
-
Jenkins 1.480.3
Email-ext 2.28
Description
Our CI system uses so called build accounts to execute builds. These accounts are considered as committers as they do changes to vcs. These accounts do not have email addresses, or email addresses are invalid. Email addresses for committers are searched from directory server in our system. I would like to rule out these build accounts from email sending altogether.
First implementation alternative is to have a global exclude list of user accounts. For these accounts, email address resolution would be skipped and thus the whole email sending.
Second implementation alternative is to remove build account email addresses from the email message prior its sending. This is not as optimal as the first alternative as it requires email address resolution, but it gets the job done. This solution alternative requires configuration at global level too and is therefore related to JENKINS-14508.
As a workaround, I can use project level pre-send script to filter out unwanted email addresses.
Attachments
Issue Links
- is duplicated by
-
-
- Resolved
-
-
-
- Closed
-
- is related to
-
JENKINS-14508 Default pre-send script in Jenkins Configuration
-
- Closed
-
Activity
Sami Salonen
created issue -
Sami Salonen
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue is related to |
| Link |
This issue is duplicated by |
Would be nice to have a global solution with a simple ui rather than a change to each scm.
Sami Salonen
added a comment - Isn't it so that Email-ext gets the user IDs of committers? Could it then simply filter out blacklisted ones before requesting email address resolution for the remaining ones?
Sami Salonen
added a comment - Isn't it so that Email-ext gets the user IDs of committers? Could it then simply filter out blacklisted ones before requesting email address resolution for the remaining ones? Am interested in doing this right - but I submitted a pull request so an implementation in email-ext could be looked at as part of the conversation: https://github.com/jenkinsci/email-ext-plugin/pull/63
Code changed in jenkins
User: Harold Shinsato
Path:
src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy
src/main/webapp/help/globalConfig/excludedCommitters.html
http://jenkins-ci.org/commit/email-ext-plugin/57c6b86d67f0a89842ec41f8c0097dac533179d8
Log:
Fix for JENKINS-17503
Code changed in jenkins
User: Alex Earl
Path:
src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy
src/main/webapp/help/globalConfig/excludedCommitters.html
http://jenkins-ci.org/commit/email-ext-plugin/519f012a2a59782e1fcccf6ab1de6aebff14b993
Log:
Merge pull request #63 from hajush/master
Fix for JENKINS-17503 by adding an excluded committer list to email-ext global config
Compare: https://github.com/jenkinsci/email-ext-plugin/compare/4af57bfdfccc...519f012a2a59
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Link |
This issue is duplicated by |
| Workflow | JNJira [ 148682 ] | JNJira + In-Review [ 192824 ] |
The address resolution is actually done in the scm plugins, so there would have to be changes to those to support the blacklist idea. Email-ext just calls the core address resolution functionality.