Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17648

SSH Slaves Plugin 0.24: Exception while connection slaves

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • ssh-slaves-plugin
    • Scientific Linux 6.4 64 bit

      After upgrading the SSH Slaves Plugin from version 0.23 to 0.24 I the following exception while trying to connect slaves:

      [04/17/13 08:18:57] [SSH] Opening SSH connection to XXX:22.
      ERROR: Unexpected error in launching a slave. This is probably a bug in Jenkins.
      hudson.security.AccessDeniedException2: anonymous is missing the Administer permission
      at hudson.security.ACL.checkPermission(ACL.java:54)
      at hudson.model.Node.checkPermission(Node.java:394)
      at com.cloudbees.plugins.credentials.SystemCredentialsProvider.save(SystemCredentialsProvider.java:178)
      at hudson.plugins.sshslaves.SSHLauncher.upgrade(SSHLauncher.java:407)
      at hudson.plugins.sshslaves.SSHLauncher.getCredentials(SSHLauncher.java:351)
      at hudson.plugins.sshslaves.SSHLauncher.openConnection(SSHLauncher.java:907)
      at hudson.plugins.sshslaves.SSHLauncher.launch(SSHLauncher.java:473)
      at hudson.slaves.SlaveComputer$1.call(SlaveComputer.java:223)
      at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
      at java.util.concurrent.FutureTask.run(FutureTask.java:166)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
      at java.lang.Thread.run(Thread.java:722)
      [04/17/13 08:18:57] [SSH] Connection closed.

          [JENKINS-17648] SSH Slaves Plugin 0.24: Exception while connection slaves

          Johannes Luther created issue -
          Christopher Orr made changes -
          Component/s New: credentials [ 16523 ]
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ] New: Stephen Connolly [ stephenconnolly ]
          Labels Original: slave ssh New: credentials slave ssh

          I updated the component as the stacktrace comes from the Credentials Plugin (which is a dependency of the SSH Credentials Plugin, which is a dependency of the SSH Slaves Plugin).

          Christopher Orr added a comment - I updated the component as the stacktrace comes from the Credentials Plugin (which is a dependency of the SSH Credentials Plugin, which is a dependency of the SSH Slaves Plugin).

          While the stack trace is coming from the credentials plugin because the ssh-slaves plugin is calling a method without ensuring the method has the correct security context. Not a problem with the credentials plugin but with the ssh-slaves plugin

          Stephen Connolly added a comment - While the stack trace is coming from the credentials plugin because the ssh-slaves plugin is calling a method without ensuring the method has the correct security context. Not a problem with the credentials plugin but with the ssh-slaves plugin
          Stephen Connolly made changes -
          Component/s Original: credentials [ 16523 ]
          Labels Original: credentials slave ssh New: slave ssh

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/sshslaves/SSHLauncher.java
          http://jenkins-ci.org/commit/ssh-slaves-plugin/71a8521cb5537b29bd32424dfe05d87e1c8d218f
          Log:
          [FIX JENKINS-17648] When upgrading legacy credential format ensure that the upgraded credentials are persisted with the correct security context

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/sshslaves/SSHLauncher.java http://jenkins-ci.org/commit/ssh-slaves-plugin/71a8521cb5537b29bd32424dfe05d87e1c8d218f Log: [FIX JENKINS-17648] When upgrading legacy credential format ensure that the upgraded credentials are persisted with the correct security context

          Fixed in 0.25

          Stephen Connolly added a comment - Fixed in 0.25
          Stephen Connolly made changes -
          Fix Version/s New: current [ 10162 ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          war/pom.xml
          http://jenkins-ci.org/commit/jenkins/64ff0470944f71d0e25d6ff2b02892a759d95a9e
          Log:
          JENKINS-17648 Bump ssh-slaves version to effectively backport 71a8521cb5537b29bd32424dfe05d87e1c8d218f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: war/pom.xml http://jenkins-ci.org/commit/jenkins/64ff0470944f71d0e25d6ff2b02892a759d95a9e Log: JENKINS-17648 Bump ssh-slaves version to effectively backport 71a8521cb5537b29bd32424dfe05d87e1c8d218f

          Great! Thanks! 0.25 works as expected - no problems with slaves anymore.

          Johannes Luther added a comment - Great! Thanks! 0.25 works as expected - no problems with slaves anymore.

            stephenconnolly Stephen Connolly
            jolu Johannes Luther
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: