[1] seems to break maven module links.

@Vlatombe
Would you like to look into this?

[1] https://github.com/jenkinsci/jenkins/commit/d54105c296965f915d2124a3b475de2b8b6efa54

root cause seems to be a problem in stapler, not returning ancestors relative paths correctly when the url doesn't end with / (like in /modules)

Reproduced by selenium tests https://github.com/jenkinsci/selenium-tests/pull/22

Bug confirmed - please fix

Opened https://github.com/stapler/stapler/issues/19

Code changed in jenkins
User: Jesse Glick
Path:
core/src/test/java/hudson/FunctionsTest.java
test/src/test/java/hudson/maven/MavenMultiModuleTest.java
http://jenkins-ci.org/commit/jenkins/a5ac54eac82ce1cbfd7fbeca46ac080bc0847627
Log:
JENKINS-17713 Preparing unit and functional test coverage.

Compare: https://github.com/jenkinsci/jenkins/compare/972d8bad229a...a5ac54eac82c

Integrated in jenkins_main_trunk #2559
JENKINS-17713 Preparing unit and functional test coverage. (Revision a5ac54eac82ce1cbfd7fbeca46ac080bc0847627)

Result = SUCCESS
Jesse Glick : a5ac54eac82ce1cbfd7fbeca46ac080bc0847627
Files :

• test/src/test/java/hudson/maven/MavenMultiModuleTest.java
• core/src/test/java/hudson/FunctionsTest.java

Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
changelog.html
core/pom.xml
http://jenkins-ci.org/commit/jenkins/bda95c67a6780ff0e6350f80d6f69cf0f61e737c
Log:
[FIXED JENKINS-17713 JENKINS-14362]

Integrated the new version of Stapler that fixes them.

Compare: https://github.com/jenkinsci/jenkins/compare/59d4c6a4c25a...bda95c67a678

Code changed in jenkins
User: Jesse Glick
Path:
test/src/test/java/hudson/maven/MavenMultiModuleTest.java
http://jenkins-ci.org/commit/jenkins/f8ec4c15c2924bc2fa4141522f6076e3f0c1d376
Log:
JENKINS-17713 Not yet fixed.
Links are now correct, thanks to Ancestor.getRelativePath as called from getRelativeLinkTo being correct.
But getRelativeNameFrom is not working, so anchor texts are ‘project » module’ rather than simply ‘module’.

I filed https://github.com/jenkinsci/jenkins/pull/820 with my proposed fix for the display name issue; would appreciate some review, though I cannot get back to it until July so either merge it or leave it.

Integrated in jenkins_main_trunk #2631
JENKINS-17713 Not yet fixed. (Revision f8ec4c15c2924bc2fa4141522f6076e3f0c1d376)

Result = SUCCESS
Jesse Glick : f8ec4c15c2924bc2fa4141522f6076e3f0c1d376
Files :

• test/src/test/java/hudson/maven/MavenMultiModuleTest.java

Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332
Log:
JENKINS-17713 [FIXED JENKINS-14362] These fixes were (mistakenly?) recorded for 1.518 rather than for trunk.

Integrated in jenkins_main_trunk #2633
JENKINS-17713 [FIXED JENKINS-14362] These fixes were (mistakenly?) recorded for 1.518 rather than for trunk. (Revision fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332)

Result = SUCCESS
Jesse Glick : fbba0cc01eeb1c9d7c412a6e7b76c588cd36c332
Files :

• changelog.html

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/resources/hudson/model/TreeView/ajaxRows.jelly
core/src/main/resources/hudson/model/View/main.groovy
core/src/main/resources/hudson/views/JobColumn/column.jelly
core/src/main/resources/lib/hudson/projectView.jelly
maven-plugin/src/main/resources/hudson/maven/MavenModuleSet/modules.jelly
test/src/test/java/hudson/maven/MavenMultiModuleTest.java
http://jenkins-ci.org/commit/jenkins/b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8
Log:
[FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation.
So passing it in explicitly from both the view main page and from the Maven module set modules page.
A more automatic solution might be to make getRelativeDisplayNameFrom use Ancestor.

Integrated in jenkins_main_trunk #2636
[FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation. (Revision b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8)

Result = UNSTABLE
kohsuke : b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8
Files :

• core/src/main/resources/hudson/model/TreeView/ajaxRows.jelly
• core/src/main/resources/hudson/views/JobColumn/column.jelly
• core/src/main/resources/hudson/model/View/main.groovy
• test/src/test/java/hudson/maven/MavenMultiModuleTest.java
• maven-plugin/src/main/resources/hudson/maven/MavenModuleSet/modules.jelly
• core/src/main/resources/lib/hudson/projectView.jelly

Code changed in jenkins
User: Jesse Glick
Path:
src/main/resources/hudson/maven/MavenModuleSet/modules.jelly
http://jenkins-ci.org/commit/maven-plugin/9709e00b5ec290ca083e5a91c8d34a46b28c0695
Log:
[FIXED JENKINS-17713] JobColumn/column.jelly needs to have an itemGroup for display name calculation.
So passing it in explicitly from both the view main page and from the Maven module set modules page.
A more automatic solution might be to make getRelativeDisplayNameFrom use Ancestor.
Originally-Committed-As: b0c222477b0eaf0bc2c7a4c7eba35be7d2e591a8