Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17955

DownstreamPassCondition mishandles jobs in folders

XMLWordPrintable

      DownstreamPassCondition.jobs is in some places (e.g. getJobList) interpreted as a list of paths relative to the current job, yet in other places as a list of absolute paths (e.g. contains). Also there is no form validation on this field. The result is that you may be tempted to use a relative path to a downstream job in the same folder, but the promotion will silently never occur unless you use an absolute path.

          [JENKINS-17955] DownstreamPassCondition mishandles jobs in folders

          Jesse Glick created issue -

          Jesse Glick added a comment -

          PromotionTrigger also seems flawed. jobName is interpreted in appliesTo as a fullDisplayName, i.e. Folder Display Name » Job Display Name; but in the DescriptorImpl as a fullName, i.e. folder/job.

          Jesse Glick added a comment - PromotionTrigger also seems flawed. jobName is interpreted in appliesTo as a fullDisplayName , i.e. Folder Display Name » Job Display Name ; but in the DescriptorImpl as a fullName , i.e. folder/job .
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Assignee Original: Jesse Glick [ jglick ] New: Nicolas De Loof [ ndeloof ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/hudson/plugins/promoted_builds/PromotionTrigger.java
          src/main/java/hudson/plugins/promoted_builds/conditions/DownstreamPassCondition.java
          http://jenkins-ci.org/commit/promoted-builds-plugin/063a50bfe65e845bd74507507d1b4038a7338dc2
          Log:
          [FIXED JENKINS-17955] fix job (full)Name comparison

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/plugins/promoted_builds/PromotionTrigger.java src/main/java/hudson/plugins/promoted_builds/conditions/DownstreamPassCondition.java http://jenkins-ci.org/commit/promoted-builds-plugin/063a50bfe65e845bd74507507d1b4038a7338dc2 Log: [FIXED JENKINS-17955] fix job (full)Name comparison
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 149252 ] New: JNJira + In-Review [ 193040 ]

            ndeloof Nicolas De Loof
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: