[JENKINS-18157] Email Template Testing can't find passed Jelly script file - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: email-ext-plugin
Labels:
None
Environment:
OS: Windows 7
Jenkins: 1.516
Email-ext: 2.30.2

Similar Issues:

Show

Description

Newly implemented Email Template Testing feature doesn't work for Jelly scripts.

If name of template file is passed with extension following error occurs:

Jelly script [myscript.jelly] was not found in $JENKINS_HOME/email-templates.

If name of template file is passed without extension following error occurs:

Template [myscript] was not found in $JENKINS_HOME/email-templates.

additionally a validation error is shown:

The file 'myscript' does not exist

The problem is that EmailExtTemplateAction.doTemplateFileCheck() and EmailExtTemplateAction.renderTemplate() methods expect that template name includes extension. But JellyScriptContent.getTemplateInputStream() expects that template name doesn't contains extension.

Attachments

Activity

Ascending order - Click to sort in descending order

Volodja Medvid created issue - 2013-05-31 15:12

Volodja Medvid made changes - 2013-05-31 15:15

Field	Original Value	New Value
Summary	Email Template Testing can't find passed script file	Email Template Testing can't find passed Jelly script file

Alex Earl added a comment - 2013-05-31 15:15

Thanks for testing this I'll see if I can get a fix in for the next release.

Alex Earl added a comment - 2013-05-31 15:15 Thanks for testing this I'll see if I can get a fix in for the next release.

Volodja Medvid made changes - 2013-05-31 15:16

Description

Newly implemented Email Template Testing feature doesn't work.
If name of template file is passed with extension following error occurs:

{noformat}Jelly script [myscript.jelly] was not found in $JENKINS_HOME/email-templates.{noformat}

If name of template file is passed without extension following error occurs:

{noformat}Template [myscript] was not found in $JENKINS_HOME/email-templates.{noformat}

additionally a validation error is shown:

{noformat}The file 'myscript' does not exist{noformat}

The problem is that {{EmailExtTemplateAction.doTemplateFileCheck()}} and {{EmailExtTemplateAction.renderTemplate()}} methods expect that template name includes extension. But {{JellyScriptContent.getTemplateInputStream()}} expects that template name doesn't contains extension.

Newly implemented Email Template Testing feature doesn't work for Jelly scripts.

If name of template file is passed with extension following error occurs:

{noformat}Jelly script [myscript.jelly] was not found in $JENKINS_HOME/email-templates.{noformat}

If name of template file is passed without extension following error occurs:

{noformat}Template [myscript] was not found in $JENKINS_HOME/email-templates.{noformat}

additionally a validation error is shown:

{noformat}The file 'myscript' does not exist{noformat}

The problem is that {{EmailExtTemplateAction.doTemplateFileCheck()}} and {{EmailExtTemplateAction.renderTemplate()}} methods expect that template name includes extension. But {{JellyScriptContent.getTemplateInputStream()}} expects that template name doesn't contains extension.

SCM/JIRA link daemon added a comment - 2013-05-31 19:55

Code changed in jenkins
User: Alex Earl
Path:
src/main/java/hudson/plugins/emailext/plugins/content/JellyScriptContent.java
http://jenkins-ci.org/commit/email-ext-plugin/16a8d52dc4d65b586dc5310a07152d68a0cd78c0
Log:
Fixed ~~JENKINS-18157~~

Check if file already ends with .jelly and don't add if it does.

SCM/JIRA link daemon added a comment - 2013-05-31 19:55 Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/plugins/content/JellyScriptContent.java http://jenkins-ci.org/commit/email-ext-plugin/16a8d52dc4d65b586dc5310a07152d68a0cd78c0 Log: Fixed JENKINS-18157 Check if file already ends with .jelly and don't add if it does.

Alex Earl added a comment - 2013-05-31 20:36

Added check if template name already ends with .jelly and don't append if it does.

Alex Earl added a comment - 2013-05-31 20:36 Added check if template name already ends with .jelly and don't append if it does.

Alex Earl made changes - 2013-05-31 20:36

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Angel Williams added a comment - 2014-03-17 17:40

Has this been fixed I am havving issues but need Windows nodes to connect.

Angel Williams added a comment - 2014-03-17 17:40 Has this been fixed I am havving issues but need Windows nodes to connect.

Alex Earl added a comment - 2014-03-17 17:47

Yes, it was fixed. I'm not sure what it has to do with nodes at all...

Alex Earl added a comment - 2014-03-17 17:47 Yes, it was fixed. I'm not sure what it has to do with nodes at all...

Angel Williams added a comment - 2014-03-17 17:52 - edited

where is the directory $Jenkins_Home/email-templates.. its been soo long I can't find it

Well that is because between build 1.504 which was working for Jenkins and now 1.546 The Email-templates directory is gone.

Angel Williams added a comment - 2014-03-17 17:52 - edited where is the directory $Jenkins_Home/email-templates.. its been soo long I can't find it Well that is because between build 1.504 which was working for Jenkins and now 1.546 The Email-templates directory is gone.

Alex Earl added a comment - 2014-03-17 17:59

$JENKINS_HOME is on your Jenkins server. Usually its $HOME/.jenkins.

Alex Earl added a comment - 2014-03-17 17:59 $JENKINS_HOME is on your Jenkins server. Usually its $HOME/.jenkins.

Alex Earl added a comment - 2014-03-17 18:53

Then it some how got removed during your upgrade process, which has nothing to do with email-ext.

Alex Earl added a comment - 2014-03-17 18:53 Then it some how got removed during your upgrade process, which has nothing to do with email-ext.

Angel Williams added a comment - 2014-03-17 19:44

ok I upgraded Jenkins from 1.504 to 1.546 recently and upgraded the EmailExt Plugin from 2.27.1 to what ever is available now.

I luckily had a snapshot of the server prior to upgrade and can say that after the upgrade all my templates were missing from this path:
C:\Jenkins\plugins\email-ext\WEB-INF\classes\hudson\plugins\emailext\templates

So is there a proper way to upgrade this plugin without loosing my templates and the ability to send email post build?

Angel Williams added a comment - 2014-03-17 19:44 ok I upgraded Jenkins from 1.504 to 1.546 recently and upgraded the EmailExt Plugin from 2.27.1 to what ever is available now. I luckily had a snapshot of the server prior to upgrade and can say that after the upgrade all my templates were missing from this path: C:\Jenkins\plugins\email-ext\WEB-INF\classes\hudson\plugins\emailext\templates So is there a proper way to upgrade this plugin without loosing my templates and the ability to send email post build?

Alex Earl added a comment - 2014-03-17 21:51

Your templates should never go into the path you mention. Please review the documentation on where to put templates. With the most recent version of the plugin you can also use the managed config file plugin to contain your templates.

Alex Earl added a comment - 2014-03-17 21:51 Your templates should never go into the path you mention. Please review the documentation on where to put templates. With the most recent version of the plugin you can also use the managed config file plugin to contain your templates.

Kevin Behrens added a comment - 2014-11-20 13:20 - edited

@Alex Earl , Can you expound upon using he 'config file plugin to contain your templates'? This sounds like sauce I need to have.

Were you referring to the Config+File+Provider+Plugin? From the wiki, it say it

Adds the ability to provide configuration files (i.e., settings.xml for maven, XML, groovy, custom files, etc.) loaded through the Jenkins UI which will be copied to the job's workspace.

I am missing something, as that would allow me to put the template on the slave, where it won't be used.

Kevin Behrens added a comment - 2014-11-20 13:20 - edited @Alex Earl , Can you expound upon using he 'config file plugin to contain your templates'? This sounds like sauce I need to have. Were you referring to the Config+File+Provider+Plugin ? From the wiki, it say it Adds the ability to provide configuration files (i.e., settings.xml for maven, XML, groovy, custom files, etc.) loaded through the Jenkins UI which will be copied to the job's workspace. I am missing something, as that would allow me to put the template on the slave, where it won't be used.

Alex Earl added a comment - 2014-11-20 13:37

Email-ext uses that plugin to allow users to store templates inside Jenkins. You would want this plugin https://wiki.jenkins-ci.org/display/JENKINS/Managed+Script+Plugin for the GUI to manage the files.

Alex Earl added a comment - 2014-11-20 13:37 Email-ext uses that plugin to allow users to store templates inside Jenkins. You would want this plugin https://wiki.jenkins-ci.org/display/JENKINS/Managed+Script+Plugin for the GUI to manage the files.

R. Tyler Croy made changes - 2016-07-25 23:55

Workflow

JNJira [ 149455 ]

JNJira + In-Review [ 193134 ]

People

Assignee:: Alex Earl

Reporter:: Volodja Medvid

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2013-05-31 15:12

Updated:: 2014-11-20 13:37

Resolved:: 2013-05-31 20:36