-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
Development
In https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContextHelper.groovy the buildParameterNodes.containsKey(parameterName) won't help if someone calls parameters a few times, since that check only works within a single Context. Ideally we should queue up all the buildParameterNodes and then replay only at the very end.
Even if there are checks across parameter contexts, there are still templates and configure blocks to be considered to be 100% sure to have only unique parameter definitions. Since the DSL does not do this level of checks for other features, I tend to close this as "won't fix" and actually remove the existing checks since they pretend false security.