Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18274

Configurable loggers should capture messages on slaves

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      See https://github.com/jenkinsci/git-plugin/pull/156 for background. If you emit log messages at FINE or below on a slave, by default they are lost, and it is not obvious how to see them. https://github.com/jenkinsci/remoting/commit/e01f23c13dc18b93df106c929ee1af3eec27313f is another case.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          jglick Jesse Glick created issue -
          Hide
          Permalink
          jglick Jesse Glick added a comment -

          There is a SlaveComputer.getLogRecords, but it appears to always return an empty list.

          Show
          jglick Jesse Glick added a comment - There is a SlaveComputer.getLogRecords , but it appears to always return an empty list.
          Hide
          Permalink
          jglick Jesse Glick added a comment -

          Demo plugin that every 20s logs a message at INFO and a message at FINE from every computer (master and slave), using logger test.logstuff.Work$Ping.

          Show
          jglick Jesse Glick added a comment - Demo plugin that every 20s logs a message at INFO and a message at FINE from every computer (master and slave), using logger test.logstuff.Work$Ping .
          jglick Jesse Glick made changes -
          Field Original Value New Value
          Attachment logstuff.hpi [ 23736 ]
          jglick Jesse Glick made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          jglick Jesse Glick made changes -
          Assignee Jesse Glick [ jglick ]
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/0ca88a6ceae605e7d2e126a328a196c046a91a12
          Log:
          JENKINS-16952 JENKINS-18274 Slave computers should record all log messages at INFO+, not just those in the hudson.* namespace.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/0ca88a6ceae605e7d2e126a328a196c046a91a12 Log: JENKINS-16952 JENKINS-18274 Slave computers should record all log messages at INFO+, not just those in the hudson.* namespace.
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/remoting/Channel.java
          http://jenkins-ci.org/commit/remoting/f1e2b80fc3a327a1deb7dc66f16aea1e213b0aad
          Log:
          JENKINS-18274 No longer need special tricks to enable slave logging.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/remoting/Channel.java http://jenkins-ci.org/commit/remoting/f1e2b80fc3a327a1deb7dc66f16aea1e213b0aad Log: JENKINS-18274 No longer need special tricks to enable slave logging.
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/logging/LogRecorder.java
          core/src/main/resources/hudson/logging/LogRecorder/index.jelly
          core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly
          test/src/test/java/hudson/logging/LogRecorderManagerTest.java
          http://jenkins-ci.org/commit/jenkins/d10fbc5eace959d3a5928d40b1c1f8975b3be1d0
          Log:
          [FIXED JENKINS-18274] LogRecorder.getSlaveLogRecords

          Compare: https://github.com/jenkinsci/jenkins/compare/3238d6328db4...d10fbc5eace9

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/logging/LogRecorder.java core/src/main/resources/hudson/logging/LogRecorder/index.jelly core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly test/src/test/java/hudson/logging/LogRecorderManagerTest.java http://jenkins-ci.org/commit/jenkins/d10fbc5eace959d3a5928d40b1c1f8975b3be1d0 Log: [FIXED JENKINS-18274] LogRecorder.getSlaveLogRecords Compare: https://github.com/jenkinsci/jenkins/compare/3238d6328db4...d10fbc5eace9
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          Hide
          Permalink
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2588
          JENKINS-16952 JENKINS-18274 Slave computers should record all log messages at INFO+, not just those in the hudson.* namespace. (Revision 0ca88a6ceae605e7d2e126a328a196c046a91a12)
          [FIXED JENKINS-18274] LogRecorder.getSlaveLogRecords (Revision d10fbc5eace959d3a5928d40b1c1f8975b3be1d0)

          Result = UNSTABLE
          Jesse Glick : 0ca88a6ceae605e7d2e126a328a196c046a91a12
          Files :

          • core/src/main/java/hudson/slaves/SlaveComputer.java

          Jesse Glick : d10fbc5eace959d3a5928d40b1c1f8975b3be1d0
          Files :

          • core/src/main/resources/hudson/logging/LogRecorder/index.jelly
          • changelog.html
          • test/src/test/java/hudson/logging/LogRecorderManagerTest.java
          • core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly
          • core/src/main/java/hudson/logging/LogRecorder.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2588 JENKINS-16952 JENKINS-18274 Slave computers should record all log messages at INFO+, not just those in the hudson.* namespace. (Revision 0ca88a6ceae605e7d2e126a328a196c046a91a12) [FIXED JENKINS-18274] LogRecorder.getSlaveLogRecords (Revision d10fbc5eace959d3a5928d40b1c1f8975b3be1d0) Result = UNSTABLE Jesse Glick : 0ca88a6ceae605e7d2e126a328a196c046a91a12 Files : core/src/main/java/hudson/slaves/SlaveComputer.java Jesse Glick : d10fbc5eace959d3a5928d40b1c1f8975b3be1d0 Files : core/src/main/resources/hudson/logging/LogRecorder/index.jelly changelog.html test/src/test/java/hudson/logging/LogRecorderManagerTest.java core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly core/src/main/java/hudson/logging/LogRecorder.java
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/ca5304307607a9bddfb472cf6dc014ed5c0f8f83
          Log:
          JENKINS-18274 ComputerListener methods should be called as ACL.SYSTEM.
          https://ci.jenkins-ci.org/job/jenkins_main_trunk/2588/testReport/junit/hudson.bugs/JnlpAccessWithSecuredHudsonTest/testServiceUsingDirectSecret/

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/ca5304307607a9bddfb472cf6dc014ed5c0f8f83 Log: JENKINS-18274 ComputerListener methods should be called as ACL.SYSTEM. https://ci.jenkins-ci.org/job/jenkins_main_trunk/2588/testReport/junit/hudson.bugs/JnlpAccessWithSecuredHudsonTest/testServiceUsingDirectSecret/
          Hide
          Permalink
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2591
          JENKINS-18274 ComputerListener methods should be called as ACL.SYSTEM. (Revision ca5304307607a9bddfb472cf6dc014ed5c0f8f83)

          Result = UNSTABLE
          Jesse Glick : ca5304307607a9bddfb472cf6dc014ed5c0f8f83
          Files :

          • core/src/main/java/hudson/slaves/SlaveComputer.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2591 JENKINS-18274 ComputerListener methods should be called as ACL.SYSTEM. (Revision ca5304307607a9bddfb472cf6dc014ed5c0f8f83) Result = UNSTABLE Jesse Glick : ca5304307607a9bddfb472cf6dc014ed5c0f8f83 Files : core/src/main/java/hudson/slaves/SlaveComputer.java
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/63001918f5e2f48222d6747eab70f24eeed0f4e7
          Log:
          JENKINS-16952 JENKINS-18274 Slave computers should record all log messages at INFO+, not just those in the hudson.* namespace.
          (cherry picked from commit 0ca88a6ceae605e7d2e126a328a196c046a91a12)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/63001918f5e2f48222d6747eab70f24eeed0f4e7 Log: JENKINS-16952 JENKINS-18274 Slave computers should record all log messages at INFO+, not just those in the hudson.* namespace. (cherry picked from commit 0ca88a6ceae605e7d2e126a328a196c046a91a12)
          danielbeck Daniel Beck made changes -
          Labels diagnostics logging slave diagnostics logging lts-candidate slave
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/logging/LogRecorder.java
          core/src/main/resources/hudson/logging/LogRecorder/index.jelly
          core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly
          test/src/test/java/hudson/logging/LogRecorderManagerTest.java
          http://jenkins-ci.org/commit/jenkins/76163e2243ddd177046ee83001181c3968db679b
          Log:
          [FIXED JENKINS-18274] LogRecorder.getSlaveLogRecords
          (cherry picked from commit d10fbc5eace959d3a5928d40b1c1f8975b3be1d0)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/logging/LogRecorder.java core/src/main/resources/hudson/logging/LogRecorder/index.jelly core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly test/src/test/java/hudson/logging/LogRecorderManagerTest.java http://jenkins-ci.org/commit/jenkins/76163e2243ddd177046ee83001181c3968db679b Log: [FIXED JENKINS-18274] LogRecorder.getSlaveLogRecords (cherry picked from commit d10fbc5eace959d3a5928d40b1c1f8975b3be1d0)
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/b358d71ce0f0f8232bab211680f54eefd8ea973f
          Log:
          JENKINS-18274 ComputerListener methods should be called as ACL.SYSTEM.
          https://ci.jenkins-ci.org/job/jenkins_main_trunk/2588/testReport/junit/hudson.bugs/JnlpAccessWithSecuredHudsonTest/testServiceUsingDirectSecret/
          (cherry picked from commit ca5304307607a9bddfb472cf6dc014ed5c0f8f83)

          Compare: https://github.com/jenkinsci/jenkins/compare/8097aac90687...b358d71ce0f0

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/b358d71ce0f0f8232bab211680f54eefd8ea973f Log: JENKINS-18274 ComputerListener methods should be called as ACL.SYSTEM. https://ci.jenkins-ci.org/job/jenkins_main_trunk/2588/testReport/junit/hudson.bugs/JnlpAccessWithSecuredHudsonTest/testServiceUsingDirectSecret/ (cherry picked from commit ca5304307607a9bddfb472cf6dc014ed5c0f8f83) Compare: https://github.com/jenkinsci/jenkins/compare/8097aac90687...b358d71ce0f0
          olivergondza Oliver Gondža made changes -
          Labels diagnostics logging lts-candidate slave 1.509.4-fixed diagnostics logging slave
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 149580 ] JNJira + In-Review [ 193191 ]

            People

            Assignee:
            jglick Jesse Glick
            Reporter:
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: