Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18368

Decorated Launcher Does Not Maintain "isUnix" for RemoteLauncher

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • Reproducible with Windows master, Linux slaves

      RemoteLauncher's isUnix attribute is supplied on construction for slaves. However, when the RemoteLauncher is passed through decorateByEnv, because the anonymous class created in this method does not override isUnix, it delegates back to the base Launcher's File.pathSeparatorChar==':' check. The value for the slave passed into RemoteLauncher on construction is lost. A similar problem occurs with decorateByPrefix.

      This will cause a problem if any downstream logic depends on the Launcher's isUnix value for a process launched on a slave with a different isUnix value than the master. For example, with a Windows master and a Linux slave, the wrong file path separator is selected in a regex on the history output, and so the SCM polling does not accurately pick up changes.

          [JENKINS-18368] Decorated Launcher Does Not Maintain "isUnix" for RemoteLauncher

          Timothy Lantz created issue -
          Timothy Lantz made changes -
          Link New: This issue is related to JENKINS-3496 [ JENKINS-3496 ]
          Timothy Lantz made changes -
          Link New: This issue is related to JENKINS-13285 [ JENKINS-13285 ]
          Timothy Lantz made changes -
          Link New: This issue is related to JENKINS-12911 [ JENKINS-12911 ]
          Timothy Lantz made changes -
          Assignee New: Timothy Lantz [ tslantz ]
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Bullhorn RelEng made changes -
          Link New: This issue is related to JENKINS-15585 [ JENKINS-15585 ]
          Jesse Glick made changes -
          Labels New: lts-candidate
          Jesse Glick made changes -
          Labels Original: lts-candidate New: lts-candidate regression
          Oliver Gondža made changes -
          Labels Original: lts-candidate regression New: lts-1.509.3-fixed regression
          Oliver Gondža made changes -
          Labels Original: lts-1.509.3-fixed regression New: 1.509.3-fixed regression

            tslantz Timothy Lantz
            tslantz Timothy Lantz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: