Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18455

all modules of all maven projects are listed separately

XMLWordPrintable

      From 1.36 to 1.37 something changed so we now see all modules of all our maven projects as separately configurable in configuration slicing.
      Due to the number of projects and the huge number of modules within each of them, configuration slicing lost much of its usability.

      Maybe the noted change "add support for folders" brought this change.

      Would be nice to have a global config switch to set configuration slicing to default to the old behaviour no longer showing every single maven module in config slicing lists when not explicitely chosen to do so.

      Reverting to 1.36 from 1.37 brought back the old behaviour for us so we can see again our projects without every single maven module listed besides them.

          [JENKINS-18455] all modules of all maven projects are listed separately

          T.-C. B. created issue -

          Daniel Beck added a comment -

          Why is this labeled lts-candidate? It's not a core issue.

          FWIW it's probably a bug and should be resolved without adding an option.

          Daniel Beck added a comment - Why is this labeled lts-candidate? It's not a core issue. FWIW it's probably a bug and should be resolved without adding an option.
          T.-C. B. made changes -
          Labels Original: configuration lts-candidate plugin New: configuration plugin
          Jacob Robertson made changes -
          Assignee Original: mdonohue [ mdonohue ] New: Nicolas De Loof [ ndeloof ]

          Jacob Robertson added a comment -

          I've looked at this, and it looks pretty clear that the code changes made by Nicolas De Loof from CloudBees causes this. The plugin wasn't designed to handle "getAllItems", and that code change was made without enough testing. I have assigned the ticket to him.

          Jacob Robertson added a comment - I've looked at this, and it looks pretty clear that the code changes made by Nicolas De Loof from CloudBees causes this. The plugin wasn't designed to handle "getAllItems", and that code change was made without enough testing. I have assigned the ticket to him.
          Nicolas De Loof made changes -
          Link New: This issue is related to JENKINS-18554 [ JENKINS-18554 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/configurationslicing/maven/MavenVersionSlicer.java
          http://jenkins-ci.org/commit/configurationslicing-plugin/eefdd378edd33db54ec7e2abcddbc63ca7428fec
          Log:
          [FIXED JENKINS-18455] only expose topLevelItem
          use of getAllItems to support folders introduces as a side effect inclusion of nested maven modules / matrix axes as configurable items

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/configurationslicing/maven/MavenVersionSlicer.java http://jenkins-ci.org/commit/configurationslicing-plugin/eefdd378edd33db54ec7e2abcddbc63ca7428fec Log: [FIXED JENKINS-18455] only expose topLevelItem use of getAllItems to support folders introduces as a side effect inclusion of nested maven modules / matrix axes as configurable items
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Tim-Christian Bloss added a comment - - edited

          Hi,

          the problem seems to persist when using slicing to set JDK per maven project.

          When reconfiguring projects for new JDK versions, I see al modules of all projects listed.

          Environment:
          Debian 7.6 amd64
          Oracle JRE7 1.7.0_60
          Tomcat 7.0.54
          Jenkins 1.554.3
          Locale/Charset: de_DE.UTF-8

          EDIT 20140829@1310 :
          Configuration Sclicing Plugin 1.38.3

          Tim-Christian Bloss added a comment - - edited Hi, the problem seems to persist when using slicing to set JDK per maven project. When reconfiguring projects for new JDK versions, I see al modules of all projects listed. Environment: Debian 7.6 amd64 Oracle JRE7 1.7.0_60 Tomcat 7.0.54 Jenkins 1.554.3 Locale/Charset: de_DE.UTF-8 EDIT 20140829@1310 : Configuration Sclicing Plugin 1.38.3
          Tim-Christian Bloss made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

            ninian Ninian
            tcb T.-C. B.
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: