Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18510

JavaScript Compiles <script> Tag Inline

XMLWordPrintable

      When instantiating buildPipeline, the generated source is:

      var buildPipeline = new BuildPipeline(<script src='/adjuncts/515ad041/org/kohsuke/stapler/json2.js' type='text/javascript'></script>makeStaplerProxy('/$stapler/bound/a2de33aa-3d21-41db-b922-103346da87ce','3e86c0cf-632d-480f-8e05-16ecbadfd7f2',['triggerManualBuild','retryBuild','rerunBuild']), Handlebars.compile(buildCardTemplateSource), Handlebars.compile(projectCardTemplateSource), 3000);

      That <script> tag shouldn't be there.

          [JENKINS-18510] JavaScript Compiles <script> Tag Inline

          Daniel Watkins created issue -
          Daniel Watkins made changes -
          Description Original: build-pipeline.js declares BuildPipeline, all of the inline JS uses buildPipeline.

          This doesn't work.           		New: When instantiating buildPipeline, the generated source is:

              var buildPipeline = new BuildPipeline(<script src='/adjuncts/515ad041/org/kohsuke/stapler/json2.js' type='text/javascript'></script>makeStaplerProxy('/$stapler/bound/a2de33aa-3d21-41db-b922-103346da87ce','3e86c0cf-632d-480f-8e05-16ecbadfd7f2',['triggerManualBuild','retryBuild','rerunBuild']), Handlebars.compile(buildCardTemplateSource), Handlebars.compile(projectCardTemplateSource), 3000);

          That <script> tag shouldn't be there.
          Summary Original: JavaScript Variable Mismatch New: JavaScript Compiles <script> Tag Inline

          Michael Prokop added a comment -

          I seem to have a related issue with Jenkins version 1.520 and the 'Slaves statistics' view on the Dashboard, I get:

          makeStaplerProxy('/$stapler/bound/[snip]','[snip]',['getSlaves','getOnlineSlaves','getOfflineSlaves','getDisconnectedSlaves','getTasksInQueue','getRunningJobs']) function repeat()[snip]

          instead of the actual slave statistics.

          Michael Prokop added a comment - I seem to have a related issue with Jenkins version 1.520 and the 'Slaves statistics' view on the Dashboard, I get: makeStaplerProxy('/$stapler/bound/ [snip] ',' [snip] ', ['getSlaves','getOnlineSlaves','getOfflineSlaves','getDisconnectedSlaves','getTasksInQueue','getRunningJobs'] ) function repeat() [snip] instead of the actual slave statistics.

          Shannon Kerr added a comment -

          I seem to have a related issue as well with Jenkins version 1.520 and the "People" view on the Dashboard, I get:

          makeStaplerProxy('/$stapler/bound/9a91e193-7ef5-4228-9a15-6e812ffbf76b','a53c5f70-3fe8-4473-9d29-9f226d91f251',['news']), display);

          No people are actually listed.

          Shannon Kerr added a comment - I seem to have a related issue as well with Jenkins version 1.520 and the "People" view on the Dashboard, I get: makeStaplerProxy('/$stapler/bound/9a91e193-7ef5-4228-9a15-6e812ffbf76b','a53c5f70-3fe8-4473-9d29-9f226d91f251', ['news'] ), display); No people are actually listed.

          John Cook added a comment - - edited

          Yeah, this stopped our build pipelines from rendering. What makes it worse is that downgrading leaves me with migrated data so some stuff is... wonky. That's a technical term.

          John Cook added a comment - - edited Yeah, this stopped our build pipelines from rendering. What makes it worse is that downgrading leaves me with migrated data so some stuff is... wonky. That's a technical term.

          Michael Chamberlain added a comment - - edited

          We seem to have the exact same issue too.. (This seems to be a duplicate of: https://issues.jenkins-ci.org/browse/JENKINS-18553)
          This is after upgrading to 1.520 (still there after 1.521)

          makeStaplerProxy('/$stapler/bound/2ed077d6-01d2-460d-ac3a-9f5edac59de3','4a71cfa0-f512-4721-9df0-11a6d592deb3',['triggerManualBuild','retryBuild','rerunBuild']), Handlebars.compile(buildCardTemplateSource), Handlebars.compile(projectCardTemplateSource), 0);

          Michael Chamberlain added a comment - - edited We seem to have the exact same issue too.. (This seems to be a duplicate of: https://issues.jenkins-ci.org/browse/JENKINS-18553 ) This is after upgrading to 1.520 (still there after 1.521) makeStaplerProxy('/$stapler/bound/2ed077d6-01d2-460d-ac3a-9f5edac59de3','4a71cfa0-f512-4721-9df0-11a6d592deb3', ['triggerManualBuild','retryBuild','rerunBuild'] ), Handlebars.compile(buildCardTemplateSource), Handlebars.compile(projectCardTemplateSource), 0);

          Łukasz Jąder added a comment -

          It looks like fix for this issue is already in plugin repo https://github.com/jenkinsci/build-pipeline-plugin/commits/master - waiting for release.

          Łukasz Jąder added a comment - It looks like fix for this issue is already in plugin repo https://github.com/jenkinsci/build-pipeline-plugin/commits/master - waiting for release.
          Łukasz Jąder made changes -
          Link New: This issue is related to JENKINS-18553 [ JENKINS-18553 ]
          Wilfredo Velazquez made changes -
          Link New: This issue is related to JENKINS-18641 [ JENKINS-18641 ]

          Marcell Jusztin added a comment -

          Any estimate on when this can make it to "production"? It would be awesome if I could get back the pipeline view.

          Marcell Jusztin added a comment - Any estimate on when this can make it to "production"? It would be awesome if I could get back the pipeline view.

            Unassigned Unassigned
            odd_bloke Daniel Watkins
            Votes:
            16 Vote for this issue
            Watchers:
            28 Start watching this issue

              Created:
              Updated:
              Resolved: