[JENKINS-18574] changelog use external path for affected path, not workspace related

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: subversion-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

repository is using svn:externals
when changed are committer to external, changelog reports affected path based on external repository root, not local workspace

maven plugin then fails to detect impacted modules to be built (incremental build option)

is related to

JENKINS-22199 Jenkins throwing errors in SCM Polling and Updates with Subversion

Closed

JENKINS-16045 Subversion plugin doesn't adhere getAffectedPaths() contract

Closed

JENKINS-23146 StringIndexOutOfBoundsException on subversion checkout

Resolved

JENKINS-22778 Changelog entries for SVN externals were broken in 2.0

Resolved

Nicolas De Loof created issue - 2013-07-02 08:55

kutzi made changes - 2013-07-04 20:43

Link

New: This issue is related to ~~JENKINS-16045~~ [ ~~JENKINS-16045~~ ]

SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Code changed in jenkins
User: Nicolas De Loof
Path:
src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
src/main/java/hudson/scm/SubversionChangeLogBuilder.java
http://jenkins-ci.org/commit/subversion-plugin/77aa934e4719a0be7e3b225aafa6a4d0838eb811
Log:
~~JENKINS-18574~~ use main repo path in change log for svn:externals affected paths

SCM/JIRA link daemon added a comment - 2014-01-22 16:29 Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java http://jenkins-ci.org/commit/subversion-plugin/77aa934e4719a0be7e3b225aafa6a4d0838eb811 Log: JENKINS-18574 use main repo path in change log for svn:externals affected paths

SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Code changed in jenkins
User: Nicolas De Loof
Path:
src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
src/main/java/hudson/scm/SubversionChangeLogBuilder.java
http://jenkins-ci.org/commit/subversion-plugin/feda34e113066c0226af2558d8dc37fe9d4739b8
Log:
~~JENKINS-18574~~ use main repo path in change log for svn:externals affected paths
remove '/' svn log prepend to affected path so maven plugin can compare with modules

SCM/JIRA link daemon added a comment - 2014-01-22 16:29 Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java http://jenkins-ci.org/commit/subversion-plugin/feda34e113066c0226af2558d8dc37fe9d4739b8 Log: JENKINS-18574 use main repo path in change log for svn:externals affected paths remove '/' svn log prepend to affected path so maven plugin can compare with modules

SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Code changed in jenkins
User: Nicolas De Loof
Path:
src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
src/test/java/hudson/scm/SubversionSCMTest.java
http://jenkins-ci.org/commit/subversion-plugin/5317d0bc910461e277d9215c3d5a4e134fffefdb
Log:
~~JENKINS-18574~~ unit test to demonstrate the fix
changed implementation to workaround a constraint (bug?) in FSPathChange

SCM/JIRA link daemon added a comment - 2014-01-22 16:29 Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/5317d0bc910461e277d9215c3d5a4e134fffefdb Log: JENKINS-18574 unit test to demonstrate the fix changed implementation to workaround a constraint (bug?) in FSPathChange

SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Code changed in jenkins
User: Nicolas De Loof
Path:
src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
src/main/java/hudson/scm/SubversionChangeLogBuilder.java
src/test/java/hudson/scm/SubversionSCMTest.java
http://jenkins-ci.org/commit/subversion-plugin/2c9e37f096acf53325a24ec836cd60bfd19c7904
Log:
~~JENKINS-18574~~ fix leading '/' that confuse maven-plugin to determine impacted modules

SCM/JIRA link daemon added a comment - 2014-01-22 16:29 Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/2c9e37f096acf53325a24ec836cd60bfd19c7904 Log: JENKINS-18574 fix leading '/' that confuse maven-plugin to determine impacted modules

SCM/JIRA link daemon added a comment - 2014-01-22 16:30

Code changed in jenkins
User: Nicolas De Loof
Path:
src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
src/main/java/hudson/scm/SubversionChangeLogBuilder.java
src/test/java/hudson/scm/SubversionSCMTest.java
http://jenkins-ci.org/commit/subversion-plugin/ec606ac7557772cb07e72f00c084203810ebd815
Log:
merge ~~JENKINS-18574~~ branch

Compare: https://github.com/jenkinsci/subversion-plugin/compare/3f09b1c6c040...ec606ac75577

SCM/JIRA link daemon added a comment - 2014-01-22 16:30 Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/ec606ac7557772cb07e72f00c084203810ebd815 Log: merge JENKINS-18574 branch Compare: https://github.com/jenkinsci/subversion-plugin/compare/3f09b1c6c040...ec606ac75577

Daniel Beck added a comment - 2014-01-26 13:38

Doesn't this change break all repository browsers, that now would start linking to files that don't exist?

Daniel Beck added a comment - 2014-01-26 13:38 Doesn't this change break all repository browsers, that now would start linking to files that don't exist?

SCM/JIRA link daemon added a comment - 2014-03-31 19:36

Code changed in jenkins
User: cbos
Path:
src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
src/test/java/hudson/scm/SubversionSCMTest.java
http://jenkins-ci.org/commit/subversion-plugin/fe0b64105c2a585831e0cac90587ccd582c4c838
Log:
Fix ~~JENKINS-18574~~

SCM/JIRA link daemon added a comment - 2014-03-31 19:36 Code changed in jenkins User: cbos Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/fe0b64105c2a585831e0cac90587ccd582c4c838 Log: Fix JENKINS-18574

Daniel Beck made changes - 2014-04-26 22:37

Link

New: This issue is related to ~~JENKINS-22778~~ [ ~~JENKINS-22778~~ ]

Assignee:: Unassigned

Reporter:: Nicolas De Loof

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 2013-07-02 08:55

Updated:: 2014-08-18 14:12

Resolved:: 2014-05-07 13:21

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Expand comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Collapse comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Expand comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Collapse comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Expand comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Collapse comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Expand comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:29

Collapse comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:30

Expand comment: SCM/JIRA link daemon added a comment - 2014-01-22 16:30

Collapse comment: Daniel Beck added a comment - 2014-01-26 13:38

Expand comment: Daniel Beck added a comment - 2014-01-26 13:38

Collapse comment: SCM/JIRA link daemon added a comment - 2014-03-31 19:36

Expand comment: SCM/JIRA link daemon added a comment - 2014-03-31 19:36

People

Dates