Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1877

Explanatory message at prepare for shutdown

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      Platform: All, OS: Windows XP
    • Similar Issues:
    • Released As:
      2.267 and 2.277.1

      Description

      When preparing a heavily used hudson instance for shutdown, there are always
      questions about the "why, how long and what does it mean?". I could easily
      explain it upfront, if i could enter a message when starting the shutdown
      preparation that gets shown additional to the current text.

      Think of it like the "reason for shutdown" textfield on windows servers.

        Attachments

          Issue Links

            Activity

            dlindner dlindner created issue -
            Hide
            dlindner dlindner added a comment -

            Direct enhancement to issue 109

            Show
            dlindner dlindner added a comment - Direct enhancement to issue 109
            dlindner dlindner made changes -
            Field Original Value New Value
            Link This issue depends on JENKINS-109 [ JENKINS-109 ]
            Hide
            beta Pei-Tang Huang added a comment -

            +1

            Can anyone resolve this issue?

            Show
            beta Pei-Tang Huang added a comment - +1 Can anyone resolve this issue?
            sbreitbach Steffen Breitbach made changes -
            Link This issue is related to JENKINS-15822 [ JENKINS-15822 ]
            sbreitbach Steffen Breitbach made changes -
            Link This issue is duplicated by JENKINS-16012 [ JENKINS-16012 ]
            sbreitbach Steffen Breitbach made changes -
            Link This issue is duplicated by JENKINS-15269 [ JENKINS-15269 ]
            Hide
            hx_unbanned Linards L added a comment -

            I think this is irrevelant feature. For super-small teams - ok - you can do it, but from larger infrastructure/maintaice departments more important would be to allow some scripting assets as pre-shutdown events ... for example, to trigger backups and to perform some specific preparation ... or just connect JRockit instead of default JVM for debugging needs.

            -1

            Show
            hx_unbanned Linards L added a comment - I think this is irrevelant feature. For super-small teams - ok - you can do it, but from larger infrastructure/maintaice departments more important would be to allow some scripting assets as pre-shutdown events ... for example, to trigger backups and to perform some specific preparation ... or just connect JRockit instead of default JVM for debugging needs. -1
            hx_unbanned Linards L made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            Hide
            sbreitbach Steffen Breitbach added a comment -

            I somewhat disagree.

            In my opinion, the shutdown message is semantically incorrect. It says "Jenkins is going to shut down." when really just the flag that prevents new jobs from being executed is set. If you un-set the flag, nothing will happen in terms of shutdown.

            Maybe you don't see any benefit in a shutdown message. If we don't get the ability to set one at least the message should be set.

            I use the shutdown flag from time to time just to prevent Jenkins from doing anything while working on other tools (e.g. Sonar).

            Show
            sbreitbach Steffen Breitbach added a comment - I somewhat disagree. In my opinion, the shutdown message is semantically incorrect. It says "Jenkins is going to shut down." when really just the flag that prevents new jobs from being executed is set. If you un-set the flag, nothing will happen in terms of shutdown. Maybe you don't see any benefit in a shutdown message. If we don't get the ability to set one at least the message should be set. I use the shutdown flag from time to time just to prevent Jenkins from doing anything while working on other tools (e.g. Sonar).
            Hide
            hx_unbanned Linards L added a comment -

            Well, imho you use feature for what is is NOT designed, Steffen. The message in its current text makes you feel the shutdown itslef is due hadware maitnaince, not just to stop jobs execution.

            For managing queue, there are MILLION better ways. It is like you tamper build job execution flow in the way CI server has too much internal stress.

            But ... if it works for you ... well ... maybe I am getting to perfectional

            Show
            hx_unbanned Linards L added a comment - Well, imho you use feature for what is is NOT designed, Steffen. The message in its current text makes you feel the shutdown itslef is due hadware maitnaince, not just to stop jobs execution. For managing queue, there are MILLION better ways. It is like you tamper build job execution flow in the way CI server has too much internal stress. But ... if it works for you ... well ... maybe I am getting to perfectional
            Hide
            sbreitbach Steffen Breitbach added a comment -

            Okay, so tell me just one of those MILLION better ways: how to stop the build queue AND let users know what's happening?

            Show
            sbreitbach Steffen Breitbach added a comment - Okay, so tell me just one of those MILLION better ways: how to stop the build queue AND let users know what's happening?
            Hide
            hx_unbanned Linards L added a comment -

            EmailExt plugin had some support for custom messages. I don't want to rant your needs, but I doubt the way you want everyone to know the reason cannot be simply done by spam

            Show
            hx_unbanned Linards L added a comment - EmailExt plugin had some support for custom messages. I don't want to rant your needs, but I doubt the way you want everyone to know the reason cannot be simply done by spam
            Hide
            sbreitbach Steffen Breitbach added a comment -

            How exactly do I stop all Jobs on Jenkins with EmailExt plugin?!

            Show
            sbreitbach Steffen Breitbach added a comment - How exactly do I stop all Jobs on Jenkins with EmailExt plugin?!
            Hide
            hx_unbanned Linards L added a comment - - edited

            Sorry, "In conjuction with it", I meant.

            This looks like somewhat more robust way to do it: http://blog.cloudbees.com/2012/02/let-jenkins-hit-itself-in-head-without.html

            Show
            hx_unbanned Linards L added a comment - - edited Sorry, "In conjuction with it", I meant. This looks like somewhat more robust way to do it: http://blog.cloudbees.com/2012/02/let-jenkins-hit-itself-in-head-without.html
            Hide
            sbreitbach Steffen Breitbach added a comment -

            I just realised that we do exactly have the "Explanatory message at (prepare for) shutdown" functionality already.

            You can enter a comment when taking offline a slave. So why not have the same functionality when taking the master offline?!

            Show
            sbreitbach Steffen Breitbach added a comment - I just realised that we do exactly have the "Explanatory message at (prepare for) shutdown" functionality already. You can enter a comment when taking offline a slave. So why not have the same functionality when taking the master offline?!
            oleg_nenashev Oleg Nenashev made changes -
            Component/s core [ 15593 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is duplicated by JENKINS-15822 [ JENKINS-15822 ]
            ircbot Jenkins IRC Bot made changes -
            Component/s gui [ 15492 ]
            Hide
            fawzymanaa Fawzy Manaa added a comment -

            Has this been resolved yet? It doesn't seem like it.

            I see the explanatory prompt if I try to take down a slave, but not if I try to restart safely or prepare for shutdown of Jenkins itself.

            Show
            fawzymanaa Fawzy Manaa added a comment - Has this been resolved yet? It doesn't seem like it. I see the explanatory prompt if I try to take down a slave, but not if I try to restart safely or prepare for shutdown of Jenkins itself.
            Hide
            maniagnihotri Kumar Mani added a comment -

            There is a workaround to use Lenient shutdown plugin https://wiki.jenkins-ci.org/display/JENKINS/Lenient+shutdown+plugin, which allows customized shutdown notification message.

            Show
            maniagnihotri Kumar Mani added a comment - There is a workaround to use Lenient shutdown plugin https://wiki.jenkins-ci.org/display/JENKINS/Lenient+shutdown+plugin , which allows customized shutdown notification message.
            Hide
            sbreitbach Steffen Breitbach added a comment -

            Thanks Kumar Mani, nice find!

            Show
            sbreitbach Steffen Breitbach added a comment - Thanks Kumar Mani , nice find!
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 131950 ] JNJira + In-Review [ 173846 ]
            Hide
            cjuroz Cristian Uroz added a comment -
            Show
            cjuroz Cristian Uroz added a comment - Kumar Mani +1
            Hide
            maniagnihotri Kumar Mani added a comment -

            Since the workaround is acceptable, marking the bug as resolved. Please reopen if you think otherwise.

            Show
            maniagnihotri Kumar Mani added a comment - Since the workaround is acceptable, marking the bug as resolved. Please reopen if you think otherwise.
            maniagnihotri Kumar Mani made changes -
            Resolution Done [ 10000 ]
            Status Open [ 1 ] Resolved [ 5 ]
            maniagnihotri Kumar Mani made changes -
            Comment [ Marking the bug as resolved. ]
            Hide
            sbreitbach Steffen Breitbach added a comment -

            Well, this is not a "Bug", it's an "Improvement".

            The lenient shutdown plugin has other caveats and I still feel this should find its way into Jenkins sooner or later, so I'm reopening this.

            Show
            sbreitbach Steffen Breitbach added a comment - Well, this is not a "Bug", it's an "Improvement". The lenient shutdown plugin has other caveats and I still feel this should find its way into Jenkins sooner or later, so I'm reopening this.
            sbreitbach Steffen Breitbach made changes -
            Resolution Done [ 10000 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            Hide
            andwho Anders Hoglund added a comment -

            There is a need for separate "Shutdown" and "Restart" messages. When an update requires a restart, there is the this usual brutal and un-friendly "Shutdown" message scarring my users. Jenkins should be able to make a difference between "shutdown" and "restart".

            Show
            andwho Anders Hoglund added a comment - There is a need for separate "Shutdown" and "Restart" messages. When an update requires a restart, there is the this usual brutal and un-friendly "Shutdown" message scarring my users. Jenkins should be able to make a difference between "shutdown" and "restart".
            Hide
            andwho Anders Hoglund added a comment -

            Tried the Lenient plugin. But that does not solve the case with "native" Jenkins restart message when for instance a plugin update forces a restart. Lenient is YAWOR (yet another way of restarting), separated from the built in. Not integrated with. Still the brutal "Jenkins is is going to shutdown".

            Show
            andwho Anders Hoglund added a comment - Tried the Lenient plugin. But that does not solve the case with "native" Jenkins restart message when for instance a plugin update forces a restart. Lenient is YAWOR (yet another way of restarting), separated from the built in. Not integrated with. Still the brutal "Jenkins is is going to shutdown".
            Hide
            danielbeck Daniel Beck added a comment -

            Is the problem the wording of the default message, or that there's no easy way to add an explanation next to it?

            I.e. would changing the message to "Jenkins is quieting down in preparation for maintenance" or something similar work?

            Show
            danielbeck Daniel Beck added a comment - Is the problem the wording of the default message, or that there's no easy way to add an explanation next to it? I.e. would changing the message to "Jenkins is quieting down in preparation for maintenance" or something similar work?
            Hide
            andwho Anders Hoglund added a comment -

            All of above. Wording, hardcoded somewhere. And also no distinction made between shutdown and restart. Only a shutdown message.
            My users got scared thinking I would end the service. When all I did was update plugins.

            Show
            andwho Anders Hoglund added a comment - All of above. Wording, hardcoded somewhere. And also no distinction made between shutdown and restart. Only a shutdown message. My users got scared thinking I would end the service. When all I did was update plugins.
            Hide
            sbreitbach Steffen Breitbach added a comment - - edited

            Seconded.

            The worst part of the message is the "shutdown" part. I also got calls from users "why the Jenkins is shutting down" when this absolutely wasn't true...

            To me the best solution would be a default message (maybe the shutdown one) being displayed as long as not specified otherwise and the ability to override this somehow.

            Maybe the menu item shouldn't even read "Prepare for shutdown" but "Cease all operation" instead?

            Show
            sbreitbach Steffen Breitbach added a comment - - edited Seconded. The worst part of the message is the "shutdown" part. I also got calls from users "why the Jenkins is shutting down" when this absolutely wasn't true... To me the best solution would be a default message (maybe the shutdown one) being displayed as long as not specified otherwise and the ability to override this somehow. Maybe the menu item shouldn't even read "Prepare for shutdown" but "Cease all operation" instead?
            alexchesters Alex Chesters made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            Hide
            steven_at_cisco Steven Christenson added a comment -

            I agree, it would be wonderful if instead of displaying the built-in shutdown message it were possible to display a custom, user defined message like:

            Out of service from Monday, June 1, 2017 5:00 PM to 7:00 PM while ...

            Show
            steven_at_cisco Steven Christenson added a comment - I agree, it would be wonderful if instead of displaying the built-in shutdown message it were possible to display a custom, user defined message like: Out of service from Monday, June 1, 2017 5:00 PM to 7:00 PM while ...
            Hide
            snorky Fabien Rica added a comment -

            Hello,

            I need to restart Jenkins in 4 use cases:

            1. Plugins update: Message would contain the reason (ex: "plugins update") and a date/time when it will occur. Users will understand better that it's a minor inconvenience.
            2. General restart of Jenkins: Message would contain the reason (ex: "Performance issues") and the date/time. Users will understand that we are taking care of the complaints regarding general slowness.
            3. Reboot of the server: Message would contain the reason (ex: "OS updates")  and the date/time. No one really then discusses why it's needed, the OS have to be up-to-date to be in line with company security policy.
            4. Version update: Message would contain the reason (ex: "Jenkins version update")  and the date/time, several days in advance.

            In comparison: this feature exists in our company JIRA server and is extremely handy and well-perceived by the users.

            I don't understand why I see features requests created in from 2008/2009 (see also https://issues.jenkins-ci.org/browse/JENKINS-4967) and this is still not at least agreed that it is useful.

            I think it would be a great usability addition to Jenkins.

             

            Show
            snorky Fabien Rica added a comment - Hello, I need to restart Jenkins in 4 use cases: Plugins update: Message would contain the reason (ex: "plugins update") and a date/time when it will occur. Users will understand better that it's a minor inconvenience. General restart of Jenkins: Message would contain the reason (ex: "Performance issues") and the date/time. Users will understand that we are taking care of the complaints regarding general slowness. Reboot of the server: Message would contain the reason (ex: "OS updates")  and the date/time. No one really then discusses why it's needed, the OS have to be up-to-date to be in line with company security policy. Version update: Message would contain the reason (ex: "Jenkins version update")  and the date/time, several days in advance. In comparison: this feature exists in our company JIRA server and is extremely handy and well-perceived by the users. I don't understand why I see features requests created in from 2008/2009 (see also https://issues.jenkins-ci.org/browse/JENKINS-4967 ) and this is still not at least agreed that it is useful. I think it would be a great usability addition to Jenkins.  
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Fabien Rica I think everybody agrees it's useful. Even more, it's not a big deal to implement it. So it just needs a contributor who is ready to deliver it.

            In my previous company we were just using a custom CSS via Simple Theme Plugin to make Jenkins Web UI red and to customize the header in order to warn about maintenance timeframe and the reasons. Then we just used System Groovy scripts to publish the announcements. It was working pretty fine.

            Show
            oleg_nenashev Oleg Nenashev added a comment - Fabien Rica I think everybody agrees it's useful. Even more, it's not a big deal to implement it. So it just needs a contributor who is ready to deliver it. In my previous company we were just using a custom CSS via Simple Theme Plugin to make Jenkins Web UI red and to customize the header in order to warn about maintenance timeframe and the reasons. Then we just used System Groovy scripts to publish the announcements. It was working pretty fine.
            oleg_nenashev Oleg Nenashev made changes -
            Labels newbie-friendly
            Hide
            snorky Fabien Rica added a comment -

            Oleg Nenashev I understand perfectly your point. It's just that when reading the thread I had the feeling some people were trying to minimize the need for it.

            Thanks for the workaround also.

            Show
            snorky Fabien Rica added a comment - Oleg Nenashev I understand perfectly your point. It's just that when reading the thread I had the feeling some people were trying to minimize the need for it. Thanks for the workaround also.
            Hide
            rickybobpat Rick Patterson added a comment -

            Yes, I would like this feature just to prevent builds from happening at certain  times, such as when the LAN is down, and builds would just fail anyway.  Or we wish to suspend builds for an hour while we change a build process or something.  We would like to say have suspended Jenkins (i.e. is out of service temporarily), and it is not actually really going to shut down.

            Show
            rickybobpat Rick Patterson added a comment - Yes, I would like this feature just to prevent builds from happening at certain  times, such as when the LAN is down, and builds would just fail anyway.  Or we wish to suspend builds for an hour while we change a build process or something.  We would like to say have suspended Jenkins (i.e. is out of service temporarily), and it is not actually really going to shut down.
            austry Ilia Zasimov made changes -
            Assignee Ilia Zasimov [ austry ]
            austry Ilia Zasimov made changes -
            Status Reopened [ 4 ] In Progress [ 3 ]
            jorgepena jpena made changes -
            Comment [ +1. It would be super useful ]
            markewaite Mark Waite made changes -
            Released As 2.267
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            Hide
            martinjost Martin Jost added a comment - - edited

            I would like to see this inone of the next LTS releases. Would be really nice, Is there an official way to suggest this ?

            Show
            martinjost Martin Jost added a comment - - edited I would like to see this inone of the next LTS releases. Would be really nice, Is there an official way to suggest this ?
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            It will be automatically included into a next LTS release baseline which is based on Jenkins 2.267 or above. With the current process this release would happen in early april

            Show
            oleg_nenashev Oleg Nenashev added a comment - It will be automatically included into a next LTS release baseline which is based on Jenkins 2.267 or above. With the current process this release would happen in early april
            markewaite Mark Waite made changes -
            Released As 2.267 2.267 and 2.277.1
            reinholdfuereder Reinhold Füreder made changes -
            Link This issue is related to JENKINS-65100 [ JENKINS-65100 ]

              People

              Assignee:
              austry Ilia Zasimov
              Reporter:
              dlindner dlindner
              Votes:
              30 Vote for this issue
              Watchers:
              30 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: