Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18846

New lazy loading permalinks can break job.lastStableBuild != null => job.lastSuccessfulBuild != null

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I have seen this on some Maven module builds, especially ones where only some of the modules in the pom are build, e.g. by using `-pl some-module -am`

      The MavenModuleSet will have both lastSuccessfulBuild and lastStableBuild defined.

      The individual MavenModule instances, however, will only have lastStable defined.

        Attachments

          Issue Links

            Activity

            stephenconnolly Stephen Connolly created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is duplicated by JENKINS-17534 [ JENKINS-17534 ]
            Hide
            jglick Jesse Glick added a comment -

            The symptom described in JENKINS-19034 seems to be a corollary of this; the fix proposed for that is retroactive, whereas the fix for this would be proactive.

            Show
            jglick Jesse Glick added a comment - The symptom described in JENKINS-19034 seems to be a corollary of this; the fix proposed for that is retroactive, whereas the fix for this would be proactive.
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-19034 [ JENKINS-19034 ]
            jglick Jesse Glick made changes -
            Labels lazy-loading lts-candidate permalink symlink
            Hide
            jglick Jesse Glick added a comment -

            As far as I can tell, the actual symlinks have been incomplete or absent for Maven module builds for a long time; but this did not have a visible impact until JENKINS-16089 started using lastSuccessfulBuild to implement getLastSuccessfulBuild.

            Show
            jglick Jesse Glick added a comment - As far as I can tell, the actual symlinks have been incomplete or absent for Maven module builds for a long time; but this did not have a visible impact until JENKINS-16089 started using lastSuccessfulBuild to implement getLastSuccessfulBuild .
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-16089 [ JENKINS-16089 ]
            Hide
            jglick Jesse Glick added a comment -

            …and JENKINS-16023 started using other permalinks.

            Show
            jglick Jesse Glick added a comment - …and JENKINS-16023 started using other permalinks.
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-16023 [ JENKINS-16023 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/AbstractBuild.java
            core/src/main/java/hudson/model/Run.java
            maven-plugin/src/main/java/hudson/maven/MavenBuild.java
            test/src/test/java/hudson/maven/MavenMultiModuleTest.java
            http://jenkins-ci.org/commit/jenkins/a92e9da978262c6a7e4d74d3b2750319cbc748fb
            Log:
            [FIXED JENKINS-18846] Update symlinks for Maven module builds.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/MavenBuild.java test/src/test/java/hudson/maven/MavenMultiModuleTest.java http://jenkins-ci.org/commit/jenkins/a92e9da978262c6a7e4d74d3b2750319cbc748fb Log: [FIXED JENKINS-18846] Update symlinks for Maven module builds.
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2824
            [FIXED JENKINS-18846] Update symlinks for Maven module builds. (Revision a92e9da978262c6a7e4d74d3b2750319cbc748fb)

            Result = SUCCESS
            Jesse Glick : a92e9da978262c6a7e4d74d3b2750319cbc748fb
            Files :

            • core/src/main/java/hudson/model/AbstractBuild.java
            • test/src/test/java/hudson/maven/MavenMultiModuleTest.java
            • maven-plugin/src/main/java/hudson/maven/MavenBuild.java
            • changelog.html
            • core/src/main/java/hudson/model/Run.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2824 [FIXED JENKINS-18846] Update symlinks for Maven module builds. (Revision a92e9da978262c6a7e4d74d3b2750319cbc748fb) Result = SUCCESS Jesse Glick : a92e9da978262c6a7e4d74d3b2750319cbc748fb Files : core/src/main/java/hudson/model/AbstractBuild.java test/src/test/java/hudson/maven/MavenMultiModuleTest.java maven-plugin/src/main/java/hudson/maven/MavenBuild.java changelog.html core/src/main/java/hudson/model/Run.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/AbstractBuild.java
            core/src/main/java/hudson/model/Run.java
            maven-plugin/src/main/java/hudson/maven/MavenBuild.java
            test/src/test/java/hudson/maven/MavenMultiModuleTest.java
            http://jenkins-ci.org/commit/jenkins/92e85f74258526def5b9fd8e10efc5575b4d80bb
            Log:
            [FIXED JENKINS-18846] Update symlinks for Maven module builds.

            (cherry picked from commit a92e9da978262c6a7e4d74d3b2750319cbc748fb)

            Conflicts:
            changelog.html
            test/src/test/java/hudson/maven/MavenMultiModuleTest.java

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/MavenBuild.java test/src/test/java/hudson/maven/MavenMultiModuleTest.java http://jenkins-ci.org/commit/jenkins/92e85f74258526def5b9fd8e10efc5575b4d80bb Log: [FIXED JENKINS-18846] Update symlinks for Maven module builds. (cherry picked from commit a92e9da978262c6a7e4d74d3b2750319cbc748fb) Conflicts: changelog.html test/src/test/java/hudson/maven/MavenMultiModuleTest.java
            olivergondza Oliver Gondža made changes -
            Labels lazy-loading lts-candidate permalink symlink 1.509.4-fixed lazy-loading permalink symlink
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/maven/MavenBuild.java
            http://jenkins-ci.org/commit/maven-plugin/3a7e8116feced00bd2f8d1dc6cd071032e3fab0d
            Log:
            [FIXED JENKINS-18846] Update symlinks for Maven module builds.

            Originally-Committed-As: a92e9da978262c6a7e4d74d3b2750319cbc748fb

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenBuild.java http://jenkins-ci.org/commit/maven-plugin/3a7e8116feced00bd2f8d1dc6cd071032e3fab0d Log: [FIXED JENKINS-18846] Update symlinks for Maven module builds. Originally-Committed-As: a92e9da978262c6a7e4d74d3b2750319cbc748fb
            paux Stephan Pauxberger made changes -
            Link This issue is related to JENKINS-21597 [ JENKINS-21597 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 150196 ] JNJira + In-Review [ 193459 ]

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: