Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19081

Download update center from master by default

    XMLWordPrintable

Details

    Description

      The Jenkins update center retrieval code, as well as the code which obtains tool catalogues, is written to piggyback on the Internet connectivity of the user's browser, rather than directly downloading files. This has the advantage that if the master is not configured for a proxy (or cannot reach the Internet at all) you can still check for updates. But it has a number of disadvantages:

      1. The user's bandwidth is taken up, instead of the server's.

      2. The security mechanisms needed for this to work—signing to allow non-administrators to do the download, JSONP or postDocument to bypass same-origin restrictions, and some JavaScript AJAX glue—are complex and fragile, so when they break, updates are broken and it is tricky to debug the problem: you need to examine not only the server's logs and the update center's content, but the browser error console too.

      3. The download is interrupted by a new page load, so if a user clicks rapidly on several links, Jenkins goes into an exponential backoff procedure which can result in the download being significantly delayed with no clear explanation.

      4. The actual downloads of plugins or tools are still done directly, so you cannot really run with the master disconnected from the Internet—you can at best see that there are updates which could be installed.

      It would be better to default to making a direct connection, and fall back to the current browser tricks only if that fails.

      Attachments

        Issue Links

          Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick added a comment -

            Relevant bits: UpdateSite.updateDirectly; UpdateCenter/PageDecoratorImpl/footer.jelly and DownloadService/footer.jelly; hudson-behavior.js#downloadService; PluginManager/checkUpdates.jelly.

            jglick Jesse Glick added a comment - Relevant bits: UpdateSite.updateDirectly ; UpdateCenter/PageDecoratorImpl/footer.jelly and DownloadService/footer.jelly ; hudson-behavior.js#downloadService ; PluginManager/checkUpdates.jelly .
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Labels updateCenter robustness updateCenter
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-21984 [ JENKINS-21984 ]

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateCenter.java
            core/src/main/java/hudson/model/UpdateSite.java
            core/src/main/java/hudson/util/FormValidation.java
            core/src/main/java/jenkins/security/DownloadSettings.java
            core/src/main/resources/hudson/PluginManager/advanced.jelly
            core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly
            core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html
            core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html
            core/src/main/resources/jenkins/security/Messages.properties
            test/src/test/java/hudson/model/DownloadServiceTest.java
            http://jenkins-ci.org/commit/jenkins/1ac77750e93f9a1970fecbecdf7f84279d0a62b9
            Log:
            [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/util/FormValidation.java core/src/main/java/jenkins/security/DownloadSettings.java core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly core/src/main/resources/jenkins/security/DownloadSettings/config.groovy core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html core/src/main/resources/jenkins/security/Messages.properties test/src/test/java/hudson/model/DownloadServiceTest.java http://jenkins-ci.org/commit/jenkins/1ac77750e93f9a1970fecbecdf7f84279d0a62b9 Log: [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server.
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/485cc150eaa3d25dc64bc214a3f8a74194969069
            Log:
            [FIXED JENKINS-19081] Noting merge of #1144.

            Compare: https://github.com/jenkinsci/jenkins/compare/db4f60303aad...485cc150eaa3

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/485cc150eaa3d25dc64bc214a3f8a74194969069 Log: [FIXED JENKINS-19081] Noting merge of #1144. Compare: https://github.com/jenkinsci/jenkins/compare/db4f60303aad...485cc150eaa3
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3237
            [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server. (Revision 1ac77750e93f9a1970fecbecdf7f84279d0a62b9)
            [FIXED JENKINS-19081] Noting merge of #1144. (Revision 485cc150eaa3d25dc64bc214a3f8a74194969069)

            Result = SUCCESS
            Jesse Glick : 1ac77750e93f9a1970fecbecdf7f84279d0a62b9
            Files :

            • core/src/main/resources/hudson/PluginManager/advanced.jelly
            • core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html
            • core/src/main/java/jenkins/security/DownloadSettings.java
            • core/src/main/java/hudson/model/UpdateCenter.java
            • core/src/main/java/hudson/PluginManager.java
            • core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            • core/src/main/java/hudson/model/DownloadService.java
            • core/src/main/java/hudson/model/UpdateSite.java
            • core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html
            • core/src/main/resources/jenkins/security/Messages.properties
            • core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly
            • test/src/test/java/hudson/model/DownloadServiceTest.java
            • core/src/main/java/hudson/util/FormValidation.java

            Jesse Glick : 485cc150eaa3d25dc64bc214a3f8a74194969069
            Files :

            • changelog.html
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3237 [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server. (Revision 1ac77750e93f9a1970fecbecdf7f84279d0a62b9) [FIXED JENKINS-19081] Noting merge of #1144. (Revision 485cc150eaa3d25dc64bc214a3f8a74194969069) Result = SUCCESS Jesse Glick : 1ac77750e93f9a1970fecbecdf7f84279d0a62b9 Files : core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html core/src/main/java/jenkins/security/DownloadSettings.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/PluginManager.java core/src/main/resources/jenkins/security/DownloadSettings/config.groovy core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html core/src/main/resources/jenkins/security/Messages.properties core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly test/src/test/java/hudson/model/DownloadServiceTest.java core/src/main/java/hudson/util/FormValidation.java Jesse Glick : 485cc150eaa3d25dc64bc214a3f8a74194969069 Files : changelog.html
            danielbeck Daniel Beck made changes -
            Labels robustness updateCenter lts-candidate robustness updateCenter

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateCenter.java
            core/src/main/java/hudson/model/UpdateSite.java
            core/src/main/java/hudson/util/FormValidation.java
            core/src/main/java/jenkins/security/DownloadSettings.java
            core/src/main/resources/hudson/PluginManager/advanced.jelly
            core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly
            core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html
            core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html
            core/src/main/resources/jenkins/security/Messages.properties
            test/src/test/java/hudson/model/DownloadServiceTest.java
            http://jenkins-ci.org/commit/jenkins/d842aa4dd98f0b7c11671e58dc5ecafb201c4b1c
            Log:
            [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server.
            (cherry picked from commit 1ac77750e93f9a1970fecbecdf7f84279d0a62b9)

            Conflicts:
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateSite.java

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/util/FormValidation.java core/src/main/java/jenkins/security/DownloadSettings.java core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly core/src/main/resources/jenkins/security/DownloadSettings/config.groovy core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html core/src/main/resources/jenkins/security/Messages.properties test/src/test/java/hudson/model/DownloadServiceTest.java http://jenkins-ci.org/commit/jenkins/d842aa4dd98f0b7c11671e58dc5ecafb201c4b1c Log: [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server. (cherry picked from commit 1ac77750e93f9a1970fecbecdf7f84279d0a62b9) Conflicts: core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateSite.java

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/jenkins/security/DownloadSettings.java
            http://jenkins-ci.org/commit/jenkins/09af03aab1bf330efa247759afa8f554c9b93678
            Log:
            JENKINS-19081 Be a bit paranoid and ensure the admin has CONFIGURE_UPDATECENTER before turning off signature checks.

            (cherry picked from commit 1262d88289d94c1ee7d6736341ce354e948ceef7)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/security/DownloadSettings.java http://jenkins-ci.org/commit/jenkins/09af03aab1bf330efa247759afa8f554c9b93678 Log: JENKINS-19081 Be a bit paranoid and ensure the admin has CONFIGURE_UPDATECENTER before turning off signature checks. (cherry picked from commit 1262d88289d94c1ee7d6736341ce354e948ceef7)

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            http://jenkins-ci.org/commit/jenkins/7d6e02e8d965ad66c03d4023d95febe10be61dbd
            Log:
            JENKINS-19081 @kohsuke prefers that the option to disable signature checks not even be presented unless -Dhudson.model.DownloadService.noSignatureCheck is used.
            (cherry picked from commit 54c85007f355dadfbf8b0fc5924ded55f1614280)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/DownloadService.java core/src/main/resources/jenkins/security/DownloadSettings/config.groovy http://jenkins-ci.org/commit/jenkins/7d6e02e8d965ad66c03d4023d95febe10be61dbd Log: JENKINS-19081 @kohsuke prefers that the option to disable signature checks not even be presented unless -Dhudson.model.DownloadService.noSignatureCheck is used. (cherry picked from commit 54c85007f355dadfbf8b0fc5924ded55f1614280)

            Code changed in jenkins
            User: Jesse Glick
            Path:
            test/src/test/java/hudson/model/DownloadServiceTest.java
            test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller.json
            test/src/test/resources/hudson/model/hudson.tools.JDKInstaller.json
            http://jenkins-ci.org/commit/jenkins/a88fa41550b785670bb05e4f71d1a340b74dd4dc
            Log:
            JENKINS-19081 Testing the loadJSON method directly to make sure various JSONP formats are handled.
            (cherry picked from commit fb5241451337b2c084d8c7772c1d0552a0cc0169)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/test/java/hudson/model/DownloadServiceTest.java test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller.json test/src/test/resources/hudson/model/hudson.tools.JDKInstaller.json http://jenkins-ci.org/commit/jenkins/a88fa41550b785670bb05e4f71d1a340b74dd4dc Log: JENKINS-19081 Testing the loadJSON method directly to make sure various JSONP formats are handled. (cherry picked from commit fb5241451337b2c084d8c7772c1d0552a0cc0169)

            Code changed in jenkins
            User: Jesse Glick
            Path:
            test/src/test/java/hudson/model/UpdateSiteTest.java
            test/src/test/resources/hudson/model/update-center.json.html
            http://jenkins-ci.org/commit/jenkins/bb91cbf983d43b68cef72e003dff334fc34bc7d3
            Log:
            JENKINS-19081 Deleting failing test updateDirectlyWithHtml.
            loadJSON does not support parsing HTML.
            Nor should it need to, since UC URLs are supposed to be to the JSONP file.
            The .html extension is added automatically by downloadService when postBack is supported.
            (cherry picked from commit d6b37a94579a0d01359ba393f792fc0823275593)

            Conflicts:
            test/src/test/java/hudson/model/UpdateSiteTest.java
            test/src/test/resources/hudson/model/update-center.json.html

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/test/java/hudson/model/UpdateSiteTest.java test/src/test/resources/hudson/model/update-center.json.html http://jenkins-ci.org/commit/jenkins/bb91cbf983d43b68cef72e003dff334fc34bc7d3 Log: JENKINS-19081 Deleting failing test updateDirectlyWithHtml. loadJSON does not support parsing HTML. Nor should it need to, since UC URLs are supposed to be to the JSONP file. The .html extension is added automatically by downloadService when postBack is supported. (cherry picked from commit d6b37a94579a0d01359ba393f792fc0823275593) Conflicts: test/src/test/java/hudson/model/UpdateSiteTest.java test/src/test/resources/hudson/model/update-center.json.html

            Code changed in jenkins
            User: Jesse Glick
            Path:
            test/src/test/java/hudson/model/UpdateCenterTest.java
            http://jenkins-ci.org/commit/jenkins/38b5305f1a15696624a193bc04fffb553e14c4ce
            Log:
            JENKINS-19081 May as well use new DownloadService.loadJSON method here.
            (cherry picked from commit 1c99cc1af00eb52f6d9ae1963f9db7c12c1fbb5a)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/test/java/hudson/model/UpdateCenterTest.java http://jenkins-ci.org/commit/jenkins/38b5305f1a15696624a193bc04fffb553e14c4ce Log: JENKINS-19081 May as well use new DownloadService.loadJSON method here. (cherry picked from commit 1c99cc1af00eb52f6d9ae1963f9db7c12c1fbb5a)

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateCenter.java
            core/src/main/java/hudson/model/UpdateSite.java
            core/src/main/java/jenkins/model/DownloadSettings.java
            core/src/main/java/jenkins/security/DownloadSettings.java
            core/src/main/resources/hudson/PluginManager/advanced.jelly
            core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly
            core/src/main/resources/jenkins/model/DownloadSettings/config.groovy
            core/src/main/resources/jenkins/model/DownloadSettings/help-useBrowser.html
            core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html
            core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html
            core/src/main/resources/jenkins/security/Messages.properties
            test/src/test/java/hudson/model/DownloadServiceTest.java
            http://jenkins-ci.org/commit/jenkins/ca976dac70ad0945660db35d7e0bc6f063844472
            Log:
            JENKINS-19081 Removed DownloadSettings.checkSignature; back to using a plain system property for this.
            (cherry picked from commit df9c92e461443415be06743f0f8fc0b3937f2408)

            Compare: https://github.com/jenkinsci/jenkins/compare/de5e12f3b646...ca976dac70ad

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/jenkins/model/DownloadSettings.java core/src/main/java/jenkins/security/DownloadSettings.java core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly core/src/main/resources/jenkins/model/DownloadSettings/config.groovy core/src/main/resources/jenkins/model/DownloadSettings/help-useBrowser.html core/src/main/resources/jenkins/security/DownloadSettings/config.groovy core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html core/src/main/resources/jenkins/security/Messages.properties test/src/test/java/hudson/model/DownloadServiceTest.java http://jenkins-ci.org/commit/jenkins/ca976dac70ad0945660db35d7e0bc6f063844472 Log: JENKINS-19081 Removed DownloadSettings.checkSignature; back to using a plain system property for this. (cherry picked from commit df9c92e461443415be06743f0f8fc0b3937f2408) Compare: https://github.com/jenkinsci/jenkins/compare/de5e12f3b646...ca976dac70ad
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate robustness updateCenter 1.554.1-fixed robustness updateCenter
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-22227 [ JENKINS-22227 ]
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-9320 [ JENKINS-9320 ]
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-10061 [ JENKINS-10061 ]
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-15105 [ JENKINS-15105 ]
            jglick Jesse Glick added a comment -

            JENKINS-15105 means that Downloadable.updateNow does not work.

            jglick Jesse Glick added a comment - JENKINS-15105 means that Downloadable.updateNow does not work.
            jglick Jesse Glick made changes -
            Link This issue is blocking SECURITY-163 [ SECURITY-163 ]

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateCenter.java
            core/src/main/java/hudson/model/UpdateSite.java
            core/src/main/java/hudson/util/FormValidation.java
            core/src/main/java/jenkins/security/DownloadSettings.java
            core/src/main/resources/hudson/PluginManager/advanced.jelly
            core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly
            core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html
            core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html
            core/src/main/resources/jenkins/security/Messages.properties
            test/src/test/java/hudson/model/DownloadServiceTest.java
            http://jenkins-ci.org/commit/jenkins/33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80
            Log:
            [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server.
            (cherry picked from commit 1ac77750e93f9a1970fecbecdf7f84279d0a62b9)

            Conflicts:
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateSite.java

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/util/FormValidation.java core/src/main/java/jenkins/security/DownloadSettings.java core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly core/src/main/resources/jenkins/security/DownloadSettings/config.groovy core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html core/src/main/resources/jenkins/security/Messages.properties test/src/test/java/hudson/model/DownloadServiceTest.java http://jenkins-ci.org/commit/jenkins/33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80 Log: [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server. (cherry picked from commit 1ac77750e93f9a1970fecbecdf7f84279d0a62b9) Conflicts: core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateSite.java

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateCenter.java
            core/src/main/java/hudson/model/UpdateSite.java
            core/src/main/java/hudson/util/FormValidation.java
            core/src/main/java/jenkins/security/DownloadSettings.java
            core/src/main/resources/hudson/PluginManager/advanced.jelly
            core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly
            core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html
            core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html
            core/src/main/resources/jenkins/security/Messages.properties
            test/src/test/java/hudson/model/DownloadServiceTest.java
            http://jenkins-ci.org/commit/jenkins/33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80
            Log:
            [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server.
            (cherry picked from commit 1ac77750e93f9a1970fecbecdf7f84279d0a62b9)

            Conflicts:
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/UpdateSite.java

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/util/FormValidation.java core/src/main/java/jenkins/security/DownloadSettings.java core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly core/src/main/resources/jenkins/security/DownloadSettings/config.groovy core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html core/src/main/resources/jenkins/security/Messages.properties test/src/test/java/hudson/model/DownloadServiceTest.java http://jenkins-ci.org/commit/jenkins/33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80 Log: [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server. (cherry picked from commit 1ac77750e93f9a1970fecbecdf7f84279d0a62b9) Conflicts: core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/UpdateSite.java
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3989
            [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server. (Revision 33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80)

            Result = SUCCESS
            jesse glick : 33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80
            Files :

            • core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html
            • test/src/test/java/hudson/model/DownloadServiceTest.java
            • core/src/main/java/hudson/model/DownloadService.java
            • core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly
            • core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html
            • core/src/main/resources/jenkins/security/DownloadSettings/config.groovy
            • core/src/main/java/hudson/PluginManager.java
            • core/src/main/java/hudson/model/UpdateSite.java
            • core/src/main/java/jenkins/security/DownloadSettings.java
            • core/src/main/resources/hudson/PluginManager/advanced.jelly
            • core/src/main/resources/jenkins/security/Messages.properties
            • core/src/main/java/hudson/model/UpdateCenter.java
            • core/src/main/java/hudson/util/FormValidation.java
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3989 [FIXED JENKINS-19081] Offer the option of downloading metadata directly from the server. (Revision 33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80) Result = SUCCESS jesse glick : 33d88c015c7fc6c6cdb093d4a3d04a75aa85fa80 Files : core/src/main/resources/jenkins/security/DownloadSettings/help-checkSignature.html test/src/test/java/hudson/model/DownloadServiceTest.java core/src/main/java/hudson/model/DownloadService.java core/src/main/resources/hudson/model/UpdateCenter/PageDecoratorImpl/footer.jelly core/src/main/resources/jenkins/security/DownloadSettings/help-useBrowser.html core/src/main/resources/jenkins/security/DownloadSettings/config.groovy core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/jenkins/security/DownloadSettings.java core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/jenkins/security/Messages.properties core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/util/FormValidation.java
            ikedam ikedam made changes -
            Link This issue is related to JENKINS-32376 [ JENKINS-32376 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 150528 ] JNJira + In-Review [ 193566 ]

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: