Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19127

Details output missing information

    XMLWordPrintable

Details

    Description

      I have your latest jslint plugin and the latest checkstyle plugin running on the latest weekly Jenkins (1.526). Your plugin runs great and I do get the list of errors, but when I click on the details tab on the Checkstyle page, I see:

      foo2.js:69, , Priority: High
      Line too long.

      No description available. Please upgrade to latest checkstyle version.

      foo2.js:101, , Priority: High
      Line too long.

      No description available. Please upgrade to latest checkstyle version.

      Any ideas? I see this for all message types, not just Line too long.

      Attachments

        Activity

          kerrhome Shannon Kerr created issue -
          kerrhome Shannon Kerr added a comment -

          I switched from the Checkstyle plugin to the Violations plugin and it works fine. I do like consistency, so I wish I could stick with the Checkstyle plugin, but I'll take what works. Also, I would rather the link say "JSLint Violations" or something that identified it was JSLint instead of it saying "Checkstyle", but I may be the only one that cares

          kerrhome Shannon Kerr added a comment - I switched from the Checkstyle plugin to the Violations plugin and it works fine. I do like consistency, so I wish I could stick with the Checkstyle plugin, but I'll take what works. Also, I would rather the link say "JSLint Violations" or something that identified it was JSLint instead of it saying "Checkstyle", but I may be the only one that cares
          drulli Ulli Hafner added a comment -

          This message indicates that there is no additional information available for this violation. In my Checkstyle plug-in, only Checkstyle violations have additional information stored This is where the name of the plug-in comes from

          Actually I don't know what the JSLint plugin is doing, does it just convert the JSlint output to checkstyle format? Then it is clear that there are no additional information available.

          Did you already try the JSLint parser in the warning plug-in (which uses the same UI as the checkstyle plug-in)?

          drulli Ulli Hafner added a comment - This message indicates that there is no additional information available for this violation. In my Checkstyle plug-in, only Checkstyle violations have additional information stored This is where the name of the plug-in comes from Actually I don't know what the JSLint plugin is doing, does it just convert the JSlint output to checkstyle format? Then it is clear that there are no additional information available. Did you already try the JSLint parser in the warning plug-in (which uses the same UI as the checkstyle plug-in)?
          kerrhome Shannon Kerr added a comment -

          Thanks for getting back to me Ulli. I was going by the instruction here: http://www.boxuk.com/labs/jslint-jenkins-plugin/ And they use their plugin with the Checkstyle plugin. Perhaps that have, but don't mention, the same issue. I did try the Warning plugin, but, while it captured the numbers, it didn't capture the messages properly. Right now, the Violations plugin seems to be the only one I can get working with JSLint properly.

          kerrhome Shannon Kerr added a comment - Thanks for getting back to me Ulli. I was going by the instruction here: http://www.boxuk.com/labs/jslint-jenkins-plugin/ And they use their plugin with the Checkstyle plugin. Perhaps that have, but don't mention, the same issue. I did try the Warning plugin, but, while it captured the numbers, it didn't capture the messages properly. Right now, the Violations plugin seems to be the only one I can get working with JSLint properly.
          drulli Ulli Hafner added a comment -

          I see. Can you please attach one of your result files then I can adapt the warnings parser to get it right...

          drulli Ulli Hafner added a comment - I see. Can you please attach one of your result files then I can adapt the warnings parser to get it right...
          kerrhome Shannon Kerr added a comment -

          Please see the attached jslint.xml file. Thanks very much Ulli.

          kerrhome Shannon Kerr added a comment - Please see the attached jslint.xml file. Thanks very much Ulli.
          kerrhome Shannon Kerr made changes -
          Field Original Value New Value
          Attachment jslint.xml [ 24186 ]
          drulli Ulli Hafner added a comment -

          Thanks for attaching. Seems that this JSLint output format is different from the one I'm parsing in the warnings parser. Your format is almost identical to the checkstyle format... Maybe I should include the checkstyle parser in the warnings plug-in, too.

          drulli Ulli Hafner added a comment - Thanks for attaching. Seems that this JSLint output format is different from the one I'm parsing in the warnings parser. Your format is almost identical to the checkstyle format... Maybe I should include the checkstyle parser in the warnings plug-in, too.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          src/main/java/hudson/plugins/warnings/parser/JSLintXMLSaxParser.java
          src/test/java/hudson/plugins/warnings/parser/JSLintParserTest.java
          src/test/java/hudson/plugins/warnings/parser/ParserTester.java
          src/test/resources/hudson/plugins/warnings/parser/jslint/jslint.xml
          http://jenkins-ci.org/commit/warnings-plugin/390dc752c7fffb815e53e305970a4173e055c477
          Log:
          [FIXED JENKINS-19127] Improved JSLint parser to support checkstyle
          format.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml src/main/java/hudson/plugins/warnings/parser/JSLintXMLSaxParser.java src/test/java/hudson/plugins/warnings/parser/JSLintParserTest.java src/test/java/hudson/plugins/warnings/parser/ParserTester.java src/test/resources/hudson/plugins/warnings/parser/jslint/jslint.xml http://jenkins-ci.org/commit/warnings-plugin/390dc752c7fffb815e53e305970a4173e055c477 Log: [FIXED JENKINS-19127] Improved JSLint parser to support checkstyle format.
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          drulli Ulli Hafner added a comment -

          I hope you don't mind that I used your jslint file for my unit tests.

          drulli Ulli Hafner added a comment - I hope you don't mind that I used your jslint file for my unit tests.
          kerrhome Shannon Kerr added a comment -

          That's fine. I checked it out before I uploaded and there is nothing proprietary in it, so we're good. Thanks for letting me know though. Any idea how long until the updated plugin will be available?

          kerrhome Shannon Kerr added a comment - That's fine. I checked it out before I uploaded and there is nothing proprietary in it, so we're good. Thanks for letting me know though. Any idea how long until the updated plugin will be available?
          drulli Ulli Hafner added a comment -

          I'm still fixing some other parsers that don't use the columns yet. If you like to test the snapshot version that contains this change: https://buildhive.cloudbees.com/job/jenkinsci/job/warnings-plugin/org.jvnet.hudson.plugins$warnings/

          drulli Ulli Hafner added a comment - I'm still fixing some other parsers that don't use the columns yet. If you like to test the snapshot version that contains this change: https://buildhive.cloudbees.com/job/jenkinsci/job/warnings-plugin/org.jvnet.hudson.plugins$warnings/
          kerrhome Shannon Kerr made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 150574 ] JNJira + In-Review [ 206862 ]

          People

            drulli Ulli Hafner
            kerrhome Shannon Kerr
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: