Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19175

HTTPS with Client Certificates gives 'handshake_failure' with hidden NPE

    XMLWordPrintable

Details

    Description

      The key part of this issue is the hidden "details" button at the bottom of the screen when entering credentials:

      Caused by: java.lang.NullPointerException
	at org.tmatesoft.svn.core.internal.io.dav.http.HTTPSSLKeyManager.loadClientCertificate(HTTPSSLKeyManager.java:187)
	at org.tmatesoft.svn.core.internal.io.dav.http.HTTPSSLKeyManager.initialize(HTTPSSLKeyManager.java:441)
	at org.tmatesoft.svn.core.internal.io.dav.http.HTTPSSLKeyManager.initializeNoException(HTTPSSLKeyManager.java:406)
	at org.tmatesoft.svn.core.internal.io.dav.http.HTTPSSLKeyManager.chooseClientAlias(HTTPSSLKeyManager.java:302)
	at sun.security.ssl.AbstractKeyManagerWrapper.chooseClientAlias(SSLContextImpl.java:1046)
	at sun.security.ssl.ClientHandshaker.serverHelloDone(ClientHandshaker.java:706)
	at sun.security.ssl.ClientHandshaker.processMessage(ClientHandshaker.java:285)
	at sun.security.ssl.Handshaker.processLoop(Handshaker.java:868)
	at sun.security.ssl.Handshaker.process_record(Handshaker.java:804)
	at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1016)
	at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1312)
	at sun.security.ssl.SSLSocketImpl.writeRecord(SSLSocketImpl.java:702)
	at sun.security.ssl.AppOutputStream.write(AppOutputStream.java:122)
	at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
	at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
	at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection.sendData(HTTPConnection.java:323)
	at org.tmatesoft.svn.core.internal.io.dav.http.HTTPRequest.dispatch(HTTPRequest.java:170)
	at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection._request(HTTPConnection.java:480)

      This indicates that the root cause is the custom build of svnkit has a bad merge at https://github.com/jenkinsci/svnkit/blob/master/svnkit/src/main/java/org/tmatesoft/svn/core/internal/io/dav/http/HTTPSSLKeyManager.java#L187

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          svnkit/src/main/java/org/tmatesoft/svn/core/internal/io/dav/http/HTTPSSLKeyManager.java
          http://jenkins-ci.org/commit/svnkit/b0dcea1b10d1da1f70c326cbab3e609339f0580a
          Log:
          [FIXED JENKINS-19175] NPE when client certificates are used

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: svnkit/src/main/java/org/tmatesoft/svn/core/internal/io/dav/http/HTTPSSLKeyManager.java http://jenkins-ci.org/commit/svnkit/b0dcea1b10d1da1f70c326cbab3e609339f0580a Log: [FIXED JENKINS-19175] NPE when client certificates are used
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/scm/SubversionSCM.java
          http://jenkins-ci.org/commit/subversion-plugin/6a97955b2ab0b5f89694a737edc26d708eb2f06f
          Log:
          [FIXED JENKINS-19175] Add workaround while waiting for svnkit release with fix

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/scm/SubversionSCM.java http://jenkins-ci.org/commit/subversion-plugin/6a97955b2ab0b5f89694a737edc26d708eb2f06f Log: [FIXED JENKINS-19175] Add workaround while waiting for svnkit release with fix
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/scm/CredentialsSVNAuthenticationProviderImpl.java
          src/main/java/hudson/scm/SubversionSCM.java
          http://jenkins-ci.org/commit/subversion-plugin/2a0ab93dc99216f9fdecec071369f3eaf28bdf6a
          Log:
          [FIXED JENKINS-19175] Add workaround to new code path

          Compare: https://github.com/jenkinsci/subversion-plugin/compare/1785d16f42a6...2a0ab93dc992

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/scm/CredentialsSVNAuthenticationProviderImpl.java src/main/java/hudson/scm/SubversionSCM.java http://jenkins-ci.org/commit/subversion-plugin/2a0ab93dc99216f9fdecec071369f3eaf28bdf6a Log: [FIXED JENKINS-19175] Add workaround to new code path Compare: https://github.com/jenkinsci/subversion-plugin/compare/1785d16f42a6...2a0ab93dc992
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          svnkit/src/main/java/org/tmatesoft/svn/core/internal/io/dav/http/HTTPSSLKeyManager.java
          http://jenkins-ci.org/commit/svnkit/68b767241b9ed37aa9c55afc5391c858cea71a9d
          Log:
          [FIXED JENKINS-19175] NPE when client certificates are used(cherry picked from commit b0dcea1b10d1da1f70c326cbab3e609339f0580a)

          Compare: https://github.com/jenkinsci/svnkit/compare/43b5d0084786^...68b767241b9e

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: svnkit/src/main/java/org/tmatesoft/svn/core/internal/io/dav/http/HTTPSSLKeyManager.java http://jenkins-ci.org/commit/svnkit/68b767241b9ed37aa9c55afc5391c858cea71a9d Log: [FIXED JENKINS-19175] NPE when client certificates are used(cherry picked from commit b0dcea1b10d1da1f70c326cbab3e609339f0580a) Compare: https://github.com/jenkinsci/svnkit/compare/43b5d0084786 ^...68b767241b9e

          People

            Unassigned Unassigned
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: