Details
-
Type:
Improvement
-
Status: Reopened (View Workflow)
-
Priority:
Critical
-
Resolution: Unresolved
-
Component/s: role-strategy-plugin
-
Similar Issues:
Description
We use this plugin with Active Directory users authorisation and via AD user can be authorised with lowercase and CamelCase names. But "role-strategy" plugin uses exact user name and we have to register two user names for each user - lowercase and CamelCase.
Attachments
Issue Links
- is related to
-
JENKINS-12607 Active directory user names should not be case sensitive.
-
- Open
-
-
JENKINS-19320 Add support of user macros
-
- Open
-
- relates to
-
-
- Resolved
-
Activity
https://issues.jenkins-ci.org/browse/JENKINS-19320 can resolve this issue for role-strategy plugin.
I'm going to implement such feature at the October
Pull request: https://github.com/jenkinsci/role-strategy-plugin/pull/5
You can find test hpi in attachments
Attached hpi with a fix
Alexey, please test the plugin against ActiveDirectory. It works well for me (LDAP and LocalDatabase)
Global configuration example
Works for me, too.
In combination with Active Directory plugin
Walter Nagler
added a comment - Works for me, too.
In combination with Active Directory plugin +1. IMO this would be better to not mark this issue as fixed for communication, since the code has actually not reached master (still in the PR).
Baptiste Mathus, I've reopened the issue.
I'll consider the merge of the PR in the next release.
Oleg Nenashev Great! Thanks!
Has this been verified to work when using the "authenticated" special "user" when assigning roles.
It may be that it works inherently, but I just want to verify prior to release.
Also, will the update provide an option or will it automatically be case insensitive? (n/m, just saw the png)
pixman20
added a comment - - edited Has this been verified to work when using the "authenticated" special "user" when assigning roles.
It may be that it works inherently, but I just want to verify prior to release.
Also, will the update provide an option or will it automatically be case insensitive? (n/m, just saw the png) @pixman20
Yes, it should work with the "authenticated" user group.
If you want to perform an additional testing, I can provide the plugin's build with the patch. Such contribution will be appreciated.
Oleg Nenashev, I'd be happy to contribute and test it out. Feel free to email me (address in profile) unless there's somewhere I can grab it from. Thanks!
pixman20
added a comment - - edited Oleg Nenashev , I'd be happy to contribute and test it out. Feel free to email me (address in profile) unless there's somewhere I can grab it from. Thanks! What about the merge?
Ben Herfurth
added a comment - What about the merge? Believe I'm seeing this problem.
Users will be granted different access, whether they are logging in as lower-case "username" or have any or all letters capitalized.
If there's still something that needs to be tested prior to merge, please contact me - I'd be happy to test.
I will add it to the scope of https://jenkins.io/projects/gsoc/2019/project-ideas/role-strategy-ux/
I believe that a proper implementation nowadays would be an integration with User ID strategies from JENKINS-22247: https://javadoc.jenkins.io/jenkins/model/IdStrategy.html. Such extension point is available in recent versions
Issue is caused by active-directory plugin