• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: clover-plugin
• Labels:

  • plugin

[JENKINS-19703] clover-plugin: Ratio.getPercentageFloat() appears to handle N/0 improperly

Brian Wightman created issue - 2013-09-24 01:18

Brian Wightman made changes - 2013-09-24 01:20

Description

Original: The clover-plugin Ratio.getPercentageFloat() does not seem to handle a ratio of N / 0 properly. It seems that this should be 100%, not 0%. It looks like https://github.com/jenkinsci/clover-plugin/commit/ddbf016c17933cba373903bb797f18172b422509 may have introduced this issue. I have created a pull on GitHub (noted below). I have also added some tests for the Ratio.getPercentageFloat() in my pull request, but they are incomplete due to not being able to find documentation on the edge cases. I am willing to change the way the patch is assembled (if you want the testing broken into a different branch pull request, for example). I am also willing to flesh out the test for that method, I just need to know what the expected behavior should be.

New: The clover-plugin Ratio.getPercentageFloat() does not seem to handle a ratio of N / 0 properly. It seems that this should be 100%, not 0%. It looks like https://github.com/jenkinsci/clover-plugin/commit/ddbf016c17933cba373903bb797f18172b422509 may have introduced this issue. I have created a pull on GitHub (https://github.com/jenkinsci/clover-plugin/pull/9). I have also added some tests for the Ratio.getPercentageFloat() in my pull request, but they are incomplete due to not being able to find documentation on the edge cases. I am willing to change the way the patch is assembled (if you want the testing broken into a different branch pull request, for example). I am also willing to flesh out the test for that method, I just need to know what the expected behavior should be.

Collapse comment: Brian Wightman added a comment - 2013-09-24 01:37

Brian Wightman added a comment - 2013-09-24 01:37

This causes the clover-plugin to set the job status as not successful if there are no instances of a particular type of coverage class.

Expand comment: Brian Wightman added a comment - 2013-09-24 01:37

Brian Wightman added a comment - 2013-09-24 01:37 This causes the clover-plugin to set the job status as not successful if there are no instances of a particular type of coverage class.

Stephen Connolly made changes - 2016-07-13 08:19

Assignee

Original: Stephen Connolly [ stephenconnolly ]

R. Tyler Croy made changes - 2016-07-25 23:50

Workflow

Original: JNJira [ 151220 ]

New: JNJira + In-Review [ 177887 ]

Collapse comment: Marek Parfianowicz added a comment - 2018-01-10 21:00

Marek Parfianowicz added a comment - 2018-01-10 21:00

Pull request #9 has been merged into master in commit 8edab7de8d1186fb17c16bfa4e3c0a3b28114d19 on 2.06.2014. It was followed by two commits fixing a bug in Ratio.java class. Change has been shipped in Jenkins Clover Plugin version 4.4.0.

Expand comment: Marek Parfianowicz added a comment - 2018-01-10 21:00

Marek Parfianowicz added a comment - 2018-01-10 21:00 Pull request #9 has been merged into master in commit 8edab7de8d1186fb17c16bfa4e3c0a3b28114d19 on 2.06.2014. It was followed by two commits fixing a bug in Ratio.java class. Change has been shipped in Jenkins Clover Plugin version 4.4.0.

Marek Parfianowicz made changes - 2018-01-10 21:00

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

Marek Parfianowicz made changes - 2018-01-10 21:00

Assignee		New: Marek Parfianowicz [ marekparf ]
Status	Original: Resolved [ 5 ]	New: Closed [ 6 ]