[JENKINS-20176] Disk usage plugin write job config.xml after every build

Type: Bug
Resolution: Unresolved
Priority: Major
Component/s: disk-usage-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

With writing data in the config.xml of jobs show the job config history plugin a change of this file after every build.
e.g.

    <hudson.plugins.disk__usage.DiskUsageProperty plugin="disk-usage@0.22">
      <diskUsageWithoutBuilds>5475</diskUsageWithoutBuilds>
      
      <slaveWorkspacesUsage class="concurrent-hash-map">
        <entry>
          <string>xxxxxxxx</string>
          <concurrent-hash-map>
            <entry>
              <string>xxxxxxx</string>
              <long>292888</long>
            </entry>
          </concurrent-hash-map>
        </entry>
      </slaveWorkspacesUsage>
    </hudson.plugins.disk__usage.DiskUsageProperty>

IMHO is the config.xml not the right place to write this kind of information.

duplicates

JENKINS-23044 XML file fiddling improvements for the Disk Usage Plugin

Resolved

is duplicated by

JENKINS-20376 Disk-usage plugin causes change to job config for every build

Resolved

JENKINS-18189 disk-usage pluging: separate configuration and history serialization into different files

Resolved

Lucie Votypkova added a comment - 2013-10-22 12:06

It is due to job workspace size, saving it into build causes multiple workspace sizes (workspace is done for job not for build). I will think about another solution.

Lucie Votypkova added a comment - 2013-10-22 12:06 It is due to job workspace size, saving it into build causes multiple workspace sizes (workspace is done for job not for build). I will think about another solution.

Lucie Votypkova added a comment - 2013-10-22 12:09

I think the same should be for diskUsageWithoutBuilds - it is saved every time its counted.

Lucie Votypkova added a comment - 2013-10-22 12:09 I think the same should be for diskUsageWithoutBuilds - it is saved every time its counted.

Paul Nyheim added a comment - 2013-10-27 22:11

I agree - this should not be written to config.xml It is especially irritating when using the JobConfigHistory plugin where it causes every build to be listed as a change of config - whereas one is usually only interested in config changes made by users...

Paul Nyheim added a comment - 2013-10-27 22:11 I agree - this should not be written to config.xml It is especially irritating when using the JobConfigHistory plugin where it causes every build to be listed as a change of config - whereas one is usually only interested in config changes made by users...

moa_arosii added a comment - 2013-10-29 06:45

Also works badly together with the SCM Sync Configuration plugin as updating the config.xml triggers a SCM configuration checkin.

moa_arosii added a comment - 2013-10-29 06:45 Also works badly together with the SCM Sync Configuration plugin as updating the config.xml triggers a SCM configuration checkin.

Lucie Votypkova added a comment - 2013-10-29 08:08

Ok I will move information about disk usage into another file (some disk-usage.xml) as soon as possible. Thanks.

Lucie Votypkova added a comment - 2013-10-29 08:08 Ok I will move information about disk usage into another file (some disk-usage.xml) as soon as possible. Thanks.

Dan Albu added a comment - 2013-10-29 09:30

v 1.536
Yes i have the same issue and is rather irritating when you build every 10 min a job.

Dan Albu added a comment - 2013-10-29 09:30 v 1.536 Yes i have the same issue and is rather irritating when you build every 10 min a job.

Kayhan Sefat added a comment - 2013-10-31 11:24

Yep, this renders the JobConfigHistory plugin utterly pointless as it clutters up the history.

Kayhan Sefat added a comment - 2013-10-31 11:24 Yep, this renders the JobConfigHistory plugin utterly pointless as it clutters up the history.

Stefan Cordes added a comment - 2013-11-05 10:45

Same happens with "Jenkins ver. 1.509.4"

Stefan Cordes added a comment - 2013-11-05 10:45 Same happens with "Jenkins ver. 1.509.4"

Lucie Votypkova added a comment - 2013-11-12 13:37

I moved it into disk-usage.xml, so job is not saved after every build. Fixed version: 0.23.

Lucie Votypkova added a comment - 2013-11-12 13:37 I moved it into disk-usage.xml, so job is not saved after every build. Fixed version: 0.23.

Grégory Joseph added a comment - 2014-01-13 09:50

i have 0.23 installed and still see this happening.

Grégory Joseph added a comment - 2014-01-13 09:50 i have 0.23 installed and still see this happening.

Lucie Votypkova added a comment - 2014-01-14 08:30

I tested and it seemed ok. I will test it again and I wrote some tests for it.

Lucie Votypkova added a comment - 2014-01-14 08:30 I tested and it seemed ok. I will test it again and I wrote some tests for it.

Kent Granström added a comment - 2014-02-27 10:23 - edited

I can not see that this issue is fixed yet. I still get these items every day.
2014-02-27_08-20-46 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW)
2014-02-26_08-20-47 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW)
2014-02-25_08-20-46 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW)
2014-02-24_08-20-46 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW)
2014-02-23_08-20-45 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW)
2014-02-22_08-20-45 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW)
...

Any possibility to look into this once more?
Perhaps I am missing something in order to omit all these

-------------------------------------
Solution:
Add the DiskUsageProjectActionFactory to the "System configuration exclude file pattern" filtering and it is gone.

Case closed.

Kent Granström added a comment - 2014-02-27 10:23 - edited I can not see that this issue is fixed yet. I still get these items every day. 2014-02-27_08-20-46 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW) 2014-02-26_08-20-47 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW) 2014-02-25_08-20-46 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW) 2014-02-24_08-20-46 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW) 2014-02-23_08-20-45 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW) 2014-02-22_08-20-45 hudson.plugins.disk_usage.DiskUsageProjectActionFactory (system) Changed SYSTEM View as XML (RAW) ... Any possibility to look into this once more? Perhaps I am missing something in order to omit all these ------------------------------------- Solution: Add the DiskUsageProjectActionFactory to the "System configuration exclude file pattern" filtering and it is gone. Case closed.

Sven Ackermann added a comment - 2016-09-16 08:18 - edited

I also still have that problem with version 0.23 and Jenkins 2.7.2. This is really annoying because we also use the JOB DSL plugin to generate jobs. The generated jobs then always warn that they have been manually modified, see also https://groups.google.com/forum/#%21topic/job-dsl-plugin/Ab9dHd1LnZU

Sven Ackermann added a comment - 2016-09-16 08:18 - edited I also still have that problem with version 0.23 and Jenkins 2.7.2. This is really annoying because we also use the JOB DSL plugin to generate jobs. The generated jobs then always warn that they have been manually modified, see also https://groups.google.com/forum/#%21topic/job-dsl-plugin/Ab9dHd1LnZU

SCM/JIRA link daemon added a comment - 2017-09-25 14:57

Code changed in jenkins
User: Lucie Votypkova
Path:
pom.xml
src/test/java/hudson/plugins/disk_usage/integration/DiskUsagePropertyTest.java
http://jenkins-ci.org/commit/disk-usage-plugin/282084ec15fa6afd4306c011cf6c5b3f3219ce7b
Log:
Add test for issue JENKINS-20176

SCM/JIRA link daemon added a comment - 2017-09-25 14:57 Code changed in jenkins User: Lucie Votypkova Path: pom.xml src/test/java/hudson/plugins/disk_usage/integration/DiskUsagePropertyTest.java http://jenkins-ci.org/commit/disk-usage-plugin/282084ec15fa6afd4306c011cf6c5b3f3219ce7b Log: Add test for issue JENKINS-20176

Rusty Howell added a comment - 2018-03-07 21:24

This is still occurring with version 0.28 on Jenkins 2.89.4. All my DSL generated jobs constantly show the warning message about job being changed.

Rusty Howell added a comment - 2018-03-07 21:24 This is still occurring with version 0.28 on Jenkins 2.89.4. All my DSL generated jobs constantly show the warning message about job being changed.

Assignee:: Unassigned

Reporter:: Stefan Brausch

Votes:: 17 Vote for this issue

Watchers:: 22 Start watching this issue

Created:: 2013-10-22 10:55

Updated:: 2023-03-01 00:26

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Lucie Votypkova added a comment - 2013-10-22 12:06

Expand comment: Lucie Votypkova added a comment - 2013-10-22 12:06

Collapse comment: Lucie Votypkova added a comment - 2013-10-22 12:09

Expand comment: Lucie Votypkova added a comment - 2013-10-22 12:09

Collapse comment: Paul Nyheim added a comment - 2013-10-27 22:11

Expand comment: Paul Nyheim added a comment - 2013-10-27 22:11

Collapse comment: moa_arosii added a comment - 2013-10-29 06:45

Expand comment: moa_arosii added a comment - 2013-10-29 06:45

Collapse comment: Lucie Votypkova added a comment - 2013-10-29 08:08

Expand comment: Lucie Votypkova added a comment - 2013-10-29 08:08

Collapse comment: Dan Albu added a comment - 2013-10-29 09:30

Expand comment: Dan Albu added a comment - 2013-10-29 09:30

Collapse comment: Kayhan Sefat added a comment - 2013-10-31 11:24

Expand comment: Kayhan Sefat added a comment - 2013-10-31 11:24

Collapse comment: Stefan Cordes added a comment - 2013-11-05 10:45

Expand comment: Stefan Cordes added a comment - 2013-11-05 10:45

Collapse comment: Lucie Votypkova added a comment - 2013-11-12 13:37

Expand comment: Lucie Votypkova added a comment - 2013-11-12 13:37

Collapse comment: Grégory Joseph added a comment - 2014-01-13 09:50

Expand comment: Grégory Joseph added a comment - 2014-01-13 09:50

Collapse comment: Lucie Votypkova added a comment - 2014-01-14 08:30

Expand comment: Lucie Votypkova added a comment - 2014-01-14 08:30

Collapse comment: Kent Granström added a comment - 2014-02-27 10:23, Edited by Kent Granström - 2014-02-28 07:54

Expand comment: Kent Granström added a comment - 2014-02-27 10:23, Edited by Kent Granström - 2014-02-28 07:54

Collapse comment: Sven Ackermann added a comment - 2016-09-16 08:18, Edited by Sven Ackermann - 2016-09-16 08:29

Expand comment: Sven Ackermann added a comment - 2016-09-16 08:18, Edited by Sven Ackermann - 2016-09-16 08:29

Collapse comment: SCM/JIRA link daemon added a comment - 2017-09-25 14:57

Expand comment: SCM/JIRA link daemon added a comment - 2017-09-25 14:57

Collapse comment: Rusty Howell added a comment - 2018-03-07 21:24

Expand comment: Rusty Howell added a comment - 2018-03-07 21:24

People

Dates