-
Bug
-
Resolution: Fixed
-
Critical
-
None
The rebuild plugin only supports current Jenkins parameter types at the cost of branching the jelly configuration pages. This prevent the usage of custom parameter types.
[JENKINS-20288] The rebuild plugin doesn't support custom parameter types
Code changed in jenkins
User: William Bernardet
Path:
.gitignore
src/main/resources/com/sonyericsson/rebuild/RebuildAction/BooleanParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/ExtendedChoiceParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/FileParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/LabelParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/ListSubversionTagsParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/NodeParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/RunParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/StringParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/TextParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/ValidatingStringParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
http://jenkins-ci.org/commit/rebuild-plugin/d412c3d4224af25d35ea07c0f6cb68149afb9ffe
Log:
Fix proposal for JENKINS-20288 - Allow rebuild plugin to use default configuration page from any parameters.
Code changed in jenkins
User: William Bernardet
Path:
.gitignore
src/main/resources/com/sonyericsson/rebuild/RebuildAction/BooleanParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/ExtendedChoiceParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/FileParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/LabelParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/ListSubversionTagsParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/NodeParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/RunParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/StringParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/TextParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/ValidatingStringParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
http://jenkins-ci.org/commit/rebuild-plugin/8dc11d00dcafefc7778c337818dc70a099f93d8f
Log:
Revert "Fix proposal for JENKINS-20288 - Allow rebuild plugin to use default configuration page from any parameters."
This reverts commit d412c3d4224af25d35ea07c0f6cb68149afb9ffe.
Code changed in jenkins
User: William Bernardet
Path:
src/main/java/com/sonyericsson/rebuild/RebuildAction.java
src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
src/test/resources/com/sonyericsson/rebuild/RebuildValidatorTest/UnsupportedUnknownParameterDefinition/index.jelly
http://jenkins-ci.org/commit/rebuild-plugin/6b2d068400fa2c2f218ddcdc27ff0969a167711a
Log:
Fix proposal for JENKINS-20288 - Allow rebuild plugin to use default
configuration page from any parameters as last resort option.
If no RebuildParameterProvider, nor internal suitable jelly file is
found, then it falls back onto default parameter value page.
Code changed in jenkins
User: shemeersulaiman
Path:
src/main/java/com/sonyericsson/rebuild/RebuildAction.java
src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
src/test/resources/com/sonyericsson/rebuild/RebuildValidatorTest/UnsupportedUnknownParameterDefinition/index.jelly
http://jenkins-ci.org/commit/rebuild-plugin/99b95f2a5c4610fdda33cf07b87218bac7486368
Log:
Merge pull request #19 from williambernardet/master
Fix proposal for JENKINS-20288 - Allow rebuild plugin to use default configuration page from any parameters.
Compare: https://github.com/jenkinsci/rebuild-plugin/compare/787191f4f132...99b95f2a5c46
| Fix Version/s | New: current [ 10162 ] | |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: Open [ 1 ] | New: Closed [ 6 ] |
Seems the patch causes rebuild plugin from 1.22 to no more inject parameters that might have been injected in addition to the parameters defined in the job.
There is at least three issues mentioning that:
Create a fix proposal https://github.com/jenkinsci/rebuild-plugin/pull/19.
It is based on the copyWithDefaultValue from ParameterDefinition, which allows to display the parameter value page using previous build value as default. Only requirement is that ParameterDefinition is implementing correctly this method. Except that requirement, there is no need of specific additional API.