Details
-
Type:
Improvement
-
Status: Resolved (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: core
-
Labels:
-
Similar Issues:
-
Epic Link:
-
Released As:Plugin POM 3.29
Description
Some plugins depend on Java6 (either by compiled for Java6 for by having critical dependencies that are compiled for Java6) while others still work on Java5. The manifest should declare this so that the update center can warn users appropritely.
Attachments
Issue Links
- is blocking
-
JENKINS-55048 Jenkins core should check plugin Minimum Java requirements in Update Center metadata
-
- Resolved
-
-
-
- Resolved
-
- is duplicated by
-
-
- Resolved
-
- is related to
-
-
- Resolved
-
- links to
Activity
Alex Earl see upcoming plugin POM proposal.
| Field | Original Value | New Value |
|---|---|---|
| Component/s | core [ 15593 ] | |
| Component/s | plugin-proposals [ 15491 ] |
| Labels | api |
| Labels | api | api java |
| Summary | Define manifest header in the jpi file to capture minimum JDK requirement | Define manifest header in the jpi file to capture minimum Java requirement |
Really needs multiple components. First, a change to maven-hpi-plugin to record a Java version in the manifest; easy now since java.level is defined in the 2.x POM, so we could just configure the mojo based on that. Second, a change to the update center generator to expose this manifest field in the update center JSON (I think it does not include every field it sees, just the ones explicitly called out). Third, a change to core to block you from installing a new/updated plugin with a Java version newer than what you are currently running.
| Labels | api java | api java updateCenter |
| Workflow | JNJira [ 152488 ] | JNJira + In-Review [ 178220 ] |
| Link |
This issue is related to |
| Link |
This issue is duplicated by |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Open [ 1 ] |
| Assignee | Daniel Beck [ danielbeck ] |
| Remote Link | This issue links to "Update center PR 164 (Web Link)" [ 17657 ] |
| Remote Link | This issue links to "HPI plugin PR 75 (Web Link)" [ 17658 ] |
| Remote Link | This issue links to "core PR 3016 (Web Link)" [ 17659 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
JENKINS-37080 is marked as duplicate, but it's actually not exactly the same: capturing the target version of a given plugin is a first critical step, but it's not the same thing as modifying the UM to handle this.
Daniel Beck I see you marked this in Progress since this morning (or evening PST 
), do you plan to also adapt the Update Manager, or should JENKINS-37080 actually be reopened so that we have a look probably/ideally before Java 9 supports lands?
Baptiste Mathus See linked PRs to update center (forwarding this metadata) and core (consuming it).
| Epic Link |
|
| Assignee | Daniel Beck [ danielbeck ] | Oleg Nenashev [ oleg_nenashev ] |
As discussed with Daniel Beck I will take a look at these stories. Some of them may be helpful to deliver a custom version of Pipeline: Support for Java 11 preview availability: JENKINS-51998
https://github.com/jenkinsci/plugin-pom/pull/134 is the reference impl
| Link |
This issue is blocking |
| Link |
This issue is blocking |
Created JENKINS-55048 for landing the Core implementation by Daniel Beck. I think it should be a part of the Java 11 GA availability scope
| Released As | Plugin POM 3.29 | |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
I'm willing to look into this, but I am unsure how to determine the minimum JDK required for a plugin during the plugin build. Is there something in the maven setup that specifies this?