Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21112

Add 2x Image(s) Or Use HTML To Better Support Retina Screens

    XMLWordPrintable

Details

    Description

      Currently, the embeddable build status plugin uses images which look poor on Retina screens. This could be addressed by either:

      • Supporting 2x Images
      • Building the build status widget/icon using HTML instead of an image

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          joefitzgerald Joe Fitzgerald created issue -
          joefitzgerald Joe Fitzgerald made changes -
          Field Original Value New Value
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          mgedmin Marius Gedminas added a comment -

          Using SVG icons would solve this nicely.

          E.g. Travis CI is transitioning from PNG to SVG icons for this reason.

          mgedmin Marius Gedminas added a comment - Using SVG icons would solve this nicely. E.g. Travis CI is transitioning from PNG to SVG icons for this reason.
          mgedmin Marius Gedminas added a comment -

          My proposed fix for JENKINS-23062 also fixes this one: https://github.com/jenkinsci/embeddable-build-status-plugin/pull/8

          mgedmin Marius Gedminas added a comment - My proposed fix for JENKINS-23062 also fixes this one: https://github.com/jenkinsci/embeddable-build-status-plugin/pull/8
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marius Gedminas
          Path:
          src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java
          src/main/java/org/jenkinsci/plugins/badge/StatusImage.java
          src/main/webapp/status/build-failing-red.svg
          src/main/webapp/status/build-passing-brightgreen.svg
          src/main/webapp/status/build-running-blue.svg
          src/main/webapp/status/build-unknown-lightgrey.svg
          src/main/webapp/status/build-unstable-yellow.svg
          src/main/webapp/status/failure.png
          src/main/webapp/status/running.png
          src/main/webapp/status/success.png
          src/main/webapp/status/unknown.png
          src/main/webapp/status/unstable.png
          http://jenkins-ci.org/commit/embeddable-build-status-plugin/be474fad42c8b36e93ec59eab502fa4ad01d6475
          Log:
          Replace PNG icons with shields.io-style SVG icons

          Fixes https://issues.jenkins-ci.org/browse/JENKINS-23062 and
          https://issues.jenkins-ci.org/browse/JENKINS-21112

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marius Gedminas Path: src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java src/main/java/org/jenkinsci/plugins/badge/StatusImage.java src/main/webapp/status/build-failing-red.svg src/main/webapp/status/build-passing-brightgreen.svg src/main/webapp/status/build-running-blue.svg src/main/webapp/status/build-unknown-lightgrey.svg src/main/webapp/status/build-unstable-yellow.svg src/main/webapp/status/failure.png src/main/webapp/status/running.png src/main/webapp/status/success.png src/main/webapp/status/unknown.png src/main/webapp/status/unstable.png http://jenkins-ci.org/commit/embeddable-build-status-plugin/be474fad42c8b36e93ec59eab502fa4ad01d6475 Log: Replace PNG icons with shields.io-style SVG icons Fixes https://issues.jenkins-ci.org/browse/JENKINS-23062 and https://issues.jenkins-ci.org/browse/JENKINS-21112
          mgedmin Marius Gedminas added a comment -

          This was fixed in 1.5 by switching to SVG icons.

          mgedmin Marius Gedminas added a comment - This was fixed in 1.5 by switching to SVG icons.
          mgedmin Marius Gedminas made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 152974 ] JNJira + In-Review [ 194417 ]
          thomas_dee Thomas Döring added a comment -

          Resolved by using SVG images (v1.9 at least)

          thomas_dee Thomas Döring added a comment - Resolved by using SVG images (v1.9 at least)
          thomas_dee Thomas Döring made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            kohsuke Kohsuke Kawaguchi
            joefitzgerald Joe Fitzgerald
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: