Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21230

Broken HTML code on results page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: sloccount-plugin
    • Labels:
      None
    • Environment:
      Incorrect code.
    • Similar Issues:

      Description

      The following code is incorrect. <tfoot> should not be inside <tbody>, optional <thead> is missing.

      http://www.w3schools.com/tags/tag_thead.asp
      http://www.w3schools.com/tags/tag_tbody.asp
      http://www.w3schools.com/tags/tag_tfoot.asp

        <table class="pane sortable" id="files">
          <tr>
            <td class="pane-header">${%File}</td>
            <td class="pane-header" style="width:2em">${%Language}</td>
            <td class="pane-header" style="width:2em">${%Lines}</td>
            <td class="pane-header" style="width:60%">${%Distribution}</td>
          </tr>
          <tbody>
            ...
            <tfoot>
              ...
            </tfoot>
          </tbody>
        </table>
      

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/hudson/plugins/sloccount/model/SloccountReport.java
          src/main/resources/hudson/plugins/sloccount/SloccountResult/files.jelly
          src/main/resources/hudson/plugins/sloccount/SloccountResult/folders.jelly
          src/main/resources/hudson/plugins/sloccount/SloccountResult/languages.jelly
          http://jenkins-ci.org/commit/sloccount-plugin/710599c6588dc2771b96b84b63d2d65ee2fa5cf5
          Log:
          JENKINS-21230 Broken HTML code on results page

          • Element <tfoot> should not be inside <tbody>, optional <thead> is missing.
          • <tfoot> moved from <tbody> directly to <table>.
          • <thead> element added.
          • Total number of lines in the footer extended by total number of files and total number of folders.
          • Total number of languages can't be added because sorting using this column would stop working. String sorting is probably incorrectly changed to numeric sorting in such case.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/hudson/plugins/sloccount/model/SloccountReport.java src/main/resources/hudson/plugins/sloccount/SloccountResult/files.jelly src/main/resources/hudson/plugins/sloccount/SloccountResult/folders.jelly src/main/resources/hudson/plugins/sloccount/SloccountResult/languages.jelly http://jenkins-ci.org/commit/sloccount-plugin/710599c6588dc2771b96b84b63d2d65ee2fa5cf5 Log: JENKINS-21230 Broken HTML code on results page Element <tfoot> should not be inside <tbody>, optional <thead> is missing. <tfoot> moved from <tbody> directly to <table>. <thead> element added. Total number of lines in the footer extended by total number of files and total number of folders. Total number of languages can't be added because sorting using this column would stop working. String sorting is probably incorrectly changed to numeric sorting in such case.
          Hide
          mixalturek Michal Turek added a comment -

          Fixed in https://github.com/mixalturek/sloccount-plugin/commit/710599c6588dc2771b96b84b63d2d65ee2fa5cf5. Total number of lines in the footer extended by total number of files and total number of folders.

          Show
          mixalturek Michal Turek added a comment - Fixed in https://github.com/mixalturek/sloccount-plugin/commit/710599c6588dc2771b96b84b63d2d65ee2fa5cf5 . Total number of lines in the footer extended by total number of files and total number of folders.

            People

            Assignee:
            mixalturek Michal Turek
            Reporter:
            mixalturek Michal Turek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: