-
Bug
-
Resolution: Fixed
-
Minor
-
None
-
Incorrect code.
The following code is incorrect. <tfoot> should not be inside <tbody>, optional <thead> is missing.
http://www.w3schools.com/tags/tag_thead.asp
http://www.w3schools.com/tags/tag_tbody.asp
http://www.w3schools.com/tags/tag_tfoot.asp
<table class="pane sortable" id="files">
<tr>
<td class="pane-header">${%File}</td>
<td class="pane-header" style="width:2em">${%Language}</td>
<td class="pane-header" style="width:2em">${%Lines}</td>
<td class="pane-header" style="width:60%">${%Distribution}</td>
</tr>
<tbody>
...
<tfoot>
...
</tfoot>
</tbody>
</table>
[JENKINS-21230] Broken HTML code on results page
Michal Turek
created issue -
Michal Turek
made changes -
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Code changed in jenkins
User: Michal Turek
Path:
src/main/java/hudson/plugins/sloccount/model/SloccountReport.java
src/main/resources/hudson/plugins/sloccount/SloccountResult/files.jelly
src/main/resources/hudson/plugins/sloccount/SloccountResult/folders.jelly
src/main/resources/hudson/plugins/sloccount/SloccountResult/languages.jelly
http://jenkins-ci.org/commit/sloccount-plugin/710599c6588dc2771b96b84b63d2d65ee2fa5cf5
Log:
JENKINS-21230 Broken HTML code on results page
- Element <tfoot> should not be inside <tbody>, optional <thead> is missing.
- <tfoot> moved from <tbody> directly to <table>.
- <thead> element added.
- Total number of lines in the footer extended by total number of files and total number of folders.
- Total number of languages can't be added because sorting using this column would stop working. String sorting is probably incorrectly changed to numeric sorting in such case.
Michal Turek
made changes -
| Fix Version/s | New: current [ 10162 ] | |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Progress [ 3 ] | New: Resolved [ 5 ] |
Michal Turek
made changes -
| Status | Original: Resolved [ 5 ] | New: Closed [ 6 ] |
| Workflow | Original: JNJira [ 153093 ] | New: JNJira + In-Review [ 207296 ] |
Fixed in https://github.com/mixalturek/sloccount-plugin/commit/710599c6588dc2771b96b84b63d2d65ee2fa5cf5. Total number of lines in the footer extended by total number of files and total number of folders.