-
New Feature
-
Resolution: Duplicate
-
Major
-
distributed builds, git plugin
We have a custom Jenkins plugin that executes git commands using GitAPI, for example launchCommand("pull", myRemoteRepo, myBranch).
When a build is launched on a slave the build fails because the git commands attempt to run on the Jenkins master instead of the slave.
Our workaround was to replace the LocalLauncher created by CliGitAPIImpl with the Launcher provided by Jenkins during setup (using reflection), so that builds on slaves have a RemoteLauncher. It would be preferable to have a constructor in GitAPI that takes an instance of Launcher so that we do not have to code against CliGitAPIImpl directly.
- is duplicated by
-
JENKINS-30600 git isn't run inside build container
-
- Open
-
[JENKINS-21342] CliGitAPIImpl is hard-coded to use LocalLauncher
Rusty Gerard
created issue -
| Issue Type | Original: Bug [ 1 ] | New: New Feature [ 2 ] |
| Resolution | New: Won't Fix [ 2 ] | |
| Status | Original: Open [ 1 ] | New: Resolved [ 5 ] |
| Status | Original: Resolved [ 5 ] | New: Closed [ 6 ] |
Doug Jacobsen
added a comment - Hello,
I have a BuildWrapper which modifies the Launcher in order to allow processes to function properly on the system (adjusting environment and command line per local policy requirements).
Since CliGitAPIImpl uses it's own LocalLauncher, instead of accepting the Launcher from the the Job instance, the build wrapper is ignored - and thus the commands crash.
Would it be possible for CliGitAPIImpl to use the build launcher instead of instantiating it's own LocalLauncher?
Thanks,
Doug
p.s., please note my use of CliGitAPIImpl is not direct via the API, rather it is coming from use of the Git Plugin to clone/pull/checkout a repo setup in the job.
Doug Jacobsen
added a comment - Hello,
I have a BuildWrapper which modifies the Launcher in order to allow processes to function properly on the system (adjusting environment and command line per local policy requirements).
Since CliGitAPIImpl uses it's own LocalLauncher, instead of accepting the Launcher from the the Job instance, the build wrapper is ignored - and thus the commands crash.
Would it be possible for CliGitAPIImpl to use the build launcher instead of instantiating it's own LocalLauncher?
Thanks,
Doug
p.s., please note my use of CliGitAPIImpl is not direct via the API, rather it is coming from use of the Git Plugin to clone/pull/checkout a repo setup in the job. Doug Jacobsen
made changes -
| Resolution | Original: Won't Fix [ 2 ] | |
| Status | Original: Closed [ 6 ] | New: Reopened [ 4 ] |
Can you provide a pull request to the git-client-plugin (with tests) for your proposed change?
| Component/s | Original: git [ 15543 ] |
Rusty Gerard
made changes -
| Assignee | Original: Nicolas De Loof [ ndeloof ] | New: Rusty Gerard [ rgerard ] |
GitAPI is deprecated, prefer GitClient. GitClient already handle remoting transparently.
Also, git-client plugin is designed to abstract git operations and let us provide alternate implementation (running command line cli is fragile), first one begin JGit with significant limitations, maybe a libgit2 JNA wrapper will be implemented on day or the other...