Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21456

Plugin runs despite earlier errors

    XMLWordPrintable

Details

    Description

      If there is a configuration problem with the job such that the code could not be checked out, the tap plugin still attempts to process the results. The build plugins manage to detect this and avoid running, shouldn't tap be able to do so as well?

      Started by user Andrew Johnson
      Building remotely on cyg64-1 in workspace C:/cygwin64/home/jenkins/workspace/epics-base-3.15-cyg64
      Cleaning workspace...
      $ bzr branch lp:epics-base/3.15/ C:/cygwin64/home/jenkins/workspace/epics-base-3.15-cyg64
      Host key verification failed.
      Host key verification failed.
      ConnectionReset reading response for 'BzrDir.open_2.1', retrying
      bzr: ERROR: Connection closed: Unexpected end of message. Please check connectivity and permissions, and report a bug if problems persist. 
      ERROR: Failed to branch lp:epics-base/3.15/
      TAP Reports Processing: START
      Looking for TAP results report in workspace using pattern: src/**/O.cygwin-x86_64/*.tap
      ERROR: Publisher org.tap4j.plugin.TapPublisher aborted due to exception
      C:\cygwin64\home\jenkins\workspace\epics-base-3.15-cyg64 does not exist.
      	at org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
      	at hudson.FilePath.glob(FilePath.java:1559)
      	at hudson.FilePath.access$700(FilePath.java:168)
      	at hudson.FilePath$26.invoke(FilePath.java:1537)
      	at hudson.FilePath$26.invoke(FilePath.java:1534)
      	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2387)
      	at hudson.remoting.UserRequest.perform(UserRequest.java:118)
      	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
      	at hudson.remoting.Request$2.run(Request.java:326)
      	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
      	at java.util.concurrent.FutureTask.run(Unknown Source)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
      	at java.lang.Thread.run(Unknown Source)
      Sending e-mails to: xxx@xxx
      Finished: FAILURE
      

      Attachments

        Activity

          anjohnson Andrew Johnson created issue -
          kinow Bruno P. Kinoshita made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]

          Agreed, though I'd like to spend some time thinking and looking at other plug-ins, to check if it would be worth to add an option like "Skip if there are build step failures". What do you think?

          kinow Bruno P. Kinoshita added a comment - Agreed, though I'd like to spend some time thinking and looking at other plug-ins, to check if it would be worth to add an option like "Skip if there are build step failures". What do you think?
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 153322 ] JNJira + In-Review [ 185488 ]

          Issue confirmed, reproduced locally.

          kinow Bruno P. Kinoshita added a comment - Issue confirmed, reproduced locally.

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/java/org/tap4j/plugin/TapPublisher.java
          http://jenkins-ci.org/commit/tap-plugin/1f148f47d93758bdd9371af06bc79d79a72e48db
          Log:
          JENKINS-21456 Add option to let user decide to fail if build should be skipped

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/tap4j/plugin/TapPublisher.java http://jenkins-ci.org/commit/tap-plugin/1f148f47d93758bdd9371af06bc79d79a72e48db Log: JENKINS-21456 Add option to let user decide to fail if build should be skipped

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/test/java/org/tap4j/plugin/TapPublisherTest.java
          src/test/java/org/tap4j/plugin/flattentapfeature/TestFlattenTapResult.java
          src/test/java/org/tap4j/plugin/util/TestUtil.java
          http://jenkins-ci.org/commit/tap-plugin/36a8d61769ec3feaecffdbf30bc8be1a3ddd8e22
          Log:
          JENKINS-21456 Stop using some deprecated methods

          Compare: https://github.com/jenkinsci/tap-plugin/compare/1c2cc09213aa...36a8d61769ec

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/test/java/org/tap4j/plugin/TapPublisherTest.java src/test/java/org/tap4j/plugin/flattentapfeature/TestFlattenTapResult.java src/test/java/org/tap4j/plugin/util/TestUtil.java http://jenkins-ci.org/commit/tap-plugin/36a8d61769ec3feaecffdbf30bc8be1a3ddd8e22 Log: JENKINS-21456 Stop using some deprecated methods Compare: https://github.com/jenkinsci/tap-plugin/compare/1c2cc09213aa...36a8d61769ec

          Added a build step that generates a valid TAP Stream, but that than executes 'exit 255'.

          Then checked the option to skip it if there are earlier errors.

          Started by user anonymous
          Building in workspace /home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/workspace
          [workspace] $ /bin/sh -xe /tmp/hudson5979096125422072307.sh
          + cat
          + exit 255
          Build step 'Execute shell' marked build as failure
          Build result is not better or equal unstable. Skipping TAP publisher.
          Finished: FAILURE
          
          kinow Bruno P. Kinoshita added a comment - Added a build step that generates a valid TAP Stream, but that than executes 'exit 255'. Then checked the option to skip it if there are earlier errors. Started by user anonymous Building in workspace /home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/workspace [workspace] $ /bin/sh -xe /tmp/hudson5979096125422072307.sh + cat + exit 255 Build step 'Execute shell' marked build as failure Build result is not better or equal unstable. Skipping TAP publisher. Finished: FAILURE

          Added a help file with the following text:

          If checked, the TAP post build step will be skipped if the build result status is not equal or better than UNSTABLE. i.e. if checked and a build step failed, the TAP publisher will be skipped.

          kinow Bruno P. Kinoshita added a comment - Added a help file with the following text: If checked, the TAP post build step will be skipped if the build result status is not equal or better than UNSTABLE. i.e. if checked and a build step failed, the TAP publisher will be skipped.

          Unchecking the option (by default it's not checked), I get the old behaviour:

          Started by user anonymous
          Building in workspace /home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/workspace
          [workspace] $ /bin/sh -xe /tmp/hudson1853202507738357106.sh
          + cat
          + exit 255
          Build step 'Execute shell' marked build as failure
          TAP Reports Processing: START
          Looking for TAP results report in workspace using pattern: *.tap
          Saving reports...
          Processing '/home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/builds/2016-08-26_20-46-43/tap-master-files/1.tap'
          Parsing TAP test result [/home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/builds/2016-08-26_20-46-43/tap-master-files/1.tap].
          TAP Reports Processing: FINISH
          Finished: FAILURE
          

          Which means we have not changed the current behaviour

          kinow Bruno P. Kinoshita added a comment - Unchecking the option (by default it's not checked), I get the old behaviour: Started by user anonymous Building in workspace /home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/workspace [workspace] $ /bin/sh -xe /tmp/hudson1853202507738357106.sh + cat + exit 255 Build step 'Execute shell' marked build as failure TAP Reports Processing: START Looking for TAP results report in workspace using pattern: *.tap Saving reports... Processing '/home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/builds/2016-08-26_20-46-43/tap-master-files/1.tap' Parsing TAP test result [/home/kinow/Development/java/jenkins/tap-plugin/work/jobs/JENKINS-21456/builds/2016-08-26_20-46-43/tap-master-files/1.tap]. TAP Reports Processing: FINISH Finished: FAILURE Which means we have not changed the current behaviour

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/resources/org/tap4j/plugin/TapPublisher/config.jelly
          src/main/webapp/help/TapPublisher/help-skipIfBuildNotOk.html
          http://jenkins-ci.org/commit/tap-plugin/d4981c8d9671ad3a3e82a2913c1c6807d386ea33
          Log:
          JENKINS-21456 add help files

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/resources/org/tap4j/plugin/TapPublisher/config.jelly src/main/webapp/help/TapPublisher/help-skipIfBuildNotOk.html http://jenkins-ci.org/commit/tap-plugin/d4981c8d9671ad3a3e82a2913c1c6807d386ea33 Log: JENKINS-21456 add help files

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/test/java/org/tap4j/plugin/issue21456/TestIssue21456.java
          src/test/java/org/tap4j/plugin/issue21456/package-info.java
          http://jenkins-ci.org/commit/tap-plugin/5db600a1c6e4623d36fcc05529b4653a1400fbe3
          Log:
          JENKINS-21456 add unit tests

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/test/java/org/tap4j/plugin/issue21456/TestIssue21456.java src/test/java/org/tap4j/plugin/issue21456/package-info.java http://jenkins-ci.org/commit/tap-plugin/5db600a1c6e4623d36fcc05529b4653a1400fbe3 Log: JENKINS-21456 add unit tests

          Tests added, added to release notes for 2.0.1. Included in the next release. Thanks for reporting the issue.

          kinow Bruno P. Kinoshita added a comment - Tests added, added to release notes for 2.0.1. Included in the next release. Thanks for reporting the issue.
          kinow Bruno P. Kinoshita made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          kinow Bruno P. Kinoshita made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]

          2.0.1 released

          kinow Bruno P. Kinoshita added a comment - 2.0.1 released
          kinow Bruno P. Kinoshita made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            kinow Bruno P. Kinoshita
            anjohnson Andrew Johnson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: