Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21600

Enable paging to improve performance

XMLWordPrintable

      In case there are jobs with a very long configuration history - currently loading the history page takes a few minutes.
      Enabling paging that show only a portion of the information at the time will significantly improve the performance.
      This way you can show 100 entries per page, or even better set a default number and let the user change it in case he wants to see more.

          [JENKINS-21600] Enable paging to improve performance

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mirko Friedenhagen
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/FileHistoryDao.java
          src/main/java/hudson/plugins/jobConfigHistory/HistoryDescr.java
          src/main/java/hudson/plugins/jobConfigHistory/LazyHistoryDescr.java
          src/test/java/hudson/plugins/jobConfigHistory/LazyHistoryDescrTest.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/b4973543ef547a467afc8fc9a4685696c05327e6
          Log:
          JENKINS-21600: Implement lazy loading of HistoryDescr in preparation for pagination.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mirko Friedenhagen Path: src/main/java/hudson/plugins/jobConfigHistory/FileHistoryDao.java src/main/java/hudson/plugins/jobConfigHistory/HistoryDescr.java src/main/java/hudson/plugins/jobConfigHistory/LazyHistoryDescr.java src/test/java/hudson/plugins/jobConfigHistory/LazyHistoryDescrTest.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/b4973543ef547a467afc8fc9a4685696c05327e6 Log: JENKINS-21600 : Implement lazy loading of HistoryDescr in preparation for pagination.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mirko Friedenhagen
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/LazyHistoryDescr.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/7826f7abbafb656c1c2edeeb3032a834d70957da
          Log:
          JENKINS-21600: Refactor lazy loading.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mirko Friedenhagen Path: src/main/java/hudson/plugins/jobConfigHistory/LazyHistoryDescr.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/7826f7abbafb656c1c2edeeb3032a834d70957da Log: JENKINS-21600 : Refactor lazy loading.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stefan Brausch
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistory.java
          src/main/resources/hudson/plugins/jobConfigHistory/JobConfigHistory/config.jelly
          src/main/webapp/help/help-maxEntriesPerSite.html
          src/test/java/hudson/plugins/jobConfigHistory/JobConfigHistoryTest.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/d3625312101d5b17dccc04550dcb27cd8b709696
          Log:
          JENKINS-21600: Config entry for max history entries per site

          Compare: https://github.com/jenkinsci/jobConfigHistory-plugin/compare/7826f7abbafb...d3625312101d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Brausch Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistory.java src/main/resources/hudson/plugins/jobConfigHistory/JobConfigHistory/config.jelly src/main/webapp/help/help-maxEntriesPerSite.html src/test/java/hudson/plugins/jobConfigHistory/JobConfigHistoryTest.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/d3625312101d5b17dccc04550dcb27cd8b709696 Log: JENKINS-21600 : Config entry for max history entries per site Compare: https://github.com/jenkinsci/jobConfigHistory-plugin/compare/7826f7abbafb...d3625312101d

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mirko Friedenhagen
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java
          src/test/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectActionTest.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/106610c52925c07ccc4297e4f314e63acf233eea
          Log:
          JENKINS-21600: Restrict number of returned values to maxEntriesPerPage

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mirko Friedenhagen Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java src/test/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectActionTest.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/106610c52925c07ccc4297e4f314e63acf233eea Log: JENKINS-21600 : Restrict number of returned values to maxEntriesPerPage

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mirko Friedenhagen
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java
          src/test/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectActionTest.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/ad1c495b3c2050aa3ddf6afa20532d3480c7efb7
          Log:
          JENKINS-21600: When less configs are stored then maxEntriesPerPage return all entries.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mirko Friedenhagen Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java src/test/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectActionTest.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/ad1c495b3c2050aa3ddf6afa20532d3480c7efb7 Log: JENKINS-21600 : When less configs are stored then maxEntriesPerPage return all entries.

          Daniel Beck added a comment -

          Mirko: This issue is resolved, right?

          Daniel Beck added a comment - Mirko: This issue is resolved, right?

          Mirko Friedenhagen added a comment -

          danielbeck, no, I had to stop this halfways:

          • Currently, only the first maxEntriesPerPage will be shown for job histories, so no real paging right now.
          • And currently on history page beneath a job is supported, as other pages (like the general overview https://HOSTNAME/jenkins/jobConfigHistory) are using an intermediate format, so here stuff is still loaded completely .

          Mirko Friedenhagen added a comment - danielbeck , no, I had to stop this halfways: Currently, only the first maxEntriesPerPage will be shown for job histories, so no real paging right now. And currently on history page beneath a job is supported, as other pages (like the general overview https://HOSTNAME/jenkins/jobConfigHistory ) are using an intermediate format, so here stuff is still loaded completely .

          Dirk Thomas added a comment -

          For a specific job the history seems to be limited based on the config value. But the global page (e.g. "Show job configs only") is not restricted at all. It would be great if pagination (or at least a configurable limit) could be added for that.

          Dirk Thomas added a comment - For a specific job the history seems to be limited based on the config value. But the global page (e.g. "Show job configs only") is not restricted at all. It would be great if pagination (or at least a configurable limit) could be added for that.

          Denys Digtiar added a comment -

          mfriedenhagen  Could you resume the work on this and at least fix the following issue.

          When "Max number of history entries to show per page" is set to N and there are more than N revision of the config file, only N oldest revisions are shown. As a user, I would like to see the N newest revisions that I made not the oldest.

          Denys Digtiar added a comment - mfriedenhagen  Could you resume the work on this and at least fix the following issue. When " Max number of history entries to show per page" is set to N and there are more than N revision of the config file, only N oldest revisions are shown. As a user, I would like to see the N newest revisions that I made not the oldest.

          Mirko Friedenhagen added a comment -

          I am out-of-office until 29th of August, then I will have a look, although I am currently not really active anymore because we are switching most stuff to gitlab-ci

          Mirko Friedenhagen added a comment - I am out-of-office until 29th of August, then I will have a look, although I am currently not really active anymore because we are switching most stuff to gitlab-ci

          Denys Digtiar added a comment -

          mfriedenhagen oh... Sad to see you go  

          Denys Digtiar added a comment - mfriedenhagen oh... Sad to see you go  

          Denys Digtiar added a comment -

          stefanbrausch, kstutz , boev , jochenafuerbacher you are also mentioned as maintainers on the wiki. Do you still actively working on JobConfigHistory plugin? Will you be able to pick this up if Mirko doesn't have time

          Denys Digtiar added a comment - stefanbrausch , kstutz , boev , jochenafuerbacher you are also mentioned as maintainers on the wiki. Do you still actively working on JobConfigHistory plugin? Will you be able to pick this up if Mirko doesn't have time

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jochen Fürbacher
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/89ed7dc3ad2c82f94c0549fd8b8672d0c3b1508c
          Log:
          JENKINS-21600 Fixed max number of history entries issue.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jochen Fürbacher Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/89ed7dc3ad2c82f94c0549fd8b8672d0c3b1508c Log: JENKINS-21600 Fixed max number of history entries issue.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jochen A. Fürbacher
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/702d8338ec34b51cbaa268b106f60e38717338cb
          Log:
          Merge pull request #64 from jenkinsci/JENKINS-21600

          Fixed max number of history entries issue of JENKINS-21600.

          Compare: https://github.com/jenkinsci/jobConfigHistory-plugin/compare/a94a5dc8ec38...702d8338ec34

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jochen A. Fürbacher Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/702d8338ec34b51cbaa268b106f60e38717338cb Log: Merge pull request #64 from jenkinsci/ JENKINS-21600 Fixed max number of history entries issue of JENKINS-21600 . Compare: https://github.com/jenkinsci/jobConfigHistory-plugin/compare/a94a5dc8ec38...702d8338ec34

          Jochen A. Fürbacher added a comment -

          @duemir: Fixed the issue with the max number of history entries you mentioned. It will be available in the next release.

          Jochen A. Fürbacher added a comment - @ duemir : Fixed the issue with the max number of history entries you mentioned. It will be available in the next release.

          Denys Digtiar added a comment -

          jochenafuerbacher thank you very much for such a prompt reply and a fix.

          Denys Digtiar added a comment - jochenafuerbacher thank you very much for such a prompt reply and a fix.

            mfriedenhagen Mirko Friedenhagen
            esinsag Sagi Sinai-Glazer
            Votes:
            8 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated: