Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21720

Don't ask for confirmation when it doesn't make any sense

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • 1.538+

      Introduced in this commit:

      https://github.com/jenkinsci/jenkins/pull/962/files#r9552059

      A few of the odd behaviors:

      • Asks for confirmation when browsing away after navigating between form elements by pressing tab
      • Asks for confirmation when triggering form submit using keyboard
      • Asks for confirmation when navigating away after clicking an Advanced… button.

          [JENKINS-21720] Don't ask for confirmation when it doesn't make any sense

          Daniel Beck created issue -
          Daniel Beck made changes -
          Link New: This issue is related to JENKINS-19835 [ JENKINS-19835 ]
          Daniel Beck made changes -
          Assignee New: Daniel Beck [ danielbeck ]
          Description Original: Introduced in this commit:

          https://github.com/jenkinsci/jenkins/pull/962/files#r9552059
          New: Introduced in this commit:

          https://github.com/jenkinsci/jenkins/pull/962/files#r9552059

          ---

          A few of the odd behaviors:

          * Asks for confirmation when browsing away after navigating between form elements by pressing tab
          * Asks for confirmation when triggering form submit using keyboard
          * Asks for confirmation when navigating away after clicking an *Advanced…* button.
          Summary Original: Jenkins asks for confirmation to leave when submitting the form by pressing the return key New: Don't ask for confirmation when it doesn't make any sense

          Daniel Beck added a comment -

          Daniel Beck added a comment - https://github.com/jenkinsci/jenkins/pull/1175
          Daniel Beck made changes -
          Labels New: lts-candidate

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/logging/LogRecorder/configure.jelly
          core/src/main/resources/hudson/model/Computer/configure.jelly
          core/src/main/resources/hudson/model/ComputerSet/_new.jelly
          core/src/main/resources/hudson/model/View/configure.jelly
          core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy
          core/src/main/resources/jenkins/model/Jenkins/configure.jelly
          core/src/main/resources/lib/form/confirm.js
          http://jenkins-ci.org/commit/jenkins/d85b86e71921f3a43a1c49701f66a1ba2b23477d
          Log:
          [FIXED JENKINS-21720] Improved config confirmation.

          Ask for confirmation when navigating away from node, global,
          security, view and log configuration after changes.

          Don't require confirmation when pressing keys without changing
          (e.g. pressing Tab for navigation) and when pressing Advanced
          buttons.

          Don't require confirmation when submitting the form.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/logging/LogRecorder/configure.jelly core/src/main/resources/hudson/model/Computer/configure.jelly core/src/main/resources/hudson/model/ComputerSet/_new.jelly core/src/main/resources/hudson/model/View/configure.jelly core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy core/src/main/resources/jenkins/model/Jenkins/configure.jelly core/src/main/resources/lib/form/confirm.js http://jenkins-ci.org/commit/jenkins/d85b86e71921f3a43a1c49701f66a1ba2b23477d Log: [FIXED JENKINS-21720] Improved config confirmation. Ask for confirmation when navigating away from node, global, security, view and log configuration after changes. Don't require confirmation when pressing keys without changing (e.g. pressing Tab for navigation) and when pressing Advanced buttons. Don't require confirmation when submitting the form.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/model/ComputerSet/configure.jelly
          core/src/main/resources/hudson/model/Run/configure.jelly
          core/src/main/resources/hudson/model/User/configure.jelly
          core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly
          http://jenkins-ci.org/commit/jenkins/cd0fae16f00805e63832c4009a4d6984622327c0
          Log:
          JENKINS-21720 Added User, Run, ComputerSet, and LabelAtom

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/model/ComputerSet/configure.jelly core/src/main/resources/hudson/model/Run/configure.jelly core/src/main/resources/hudson/model/User/configure.jelly core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly http://jenkins-ci.org/commit/jenkins/cd0fae16f00805e63832c4009a4d6984622327c0 Log: JENKINS-21720 Added User, Run, ComputerSet, and LabelAtom

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/resources/hudson/logging/LogRecorder/configure.jelly
          core/src/main/resources/hudson/model/Computer/configure.jelly
          core/src/main/resources/hudson/model/ComputerSet/_new.jelly
          core/src/main/resources/hudson/model/ComputerSet/configure.jelly
          core/src/main/resources/hudson/model/Job/configure.jelly
          core/src/main/resources/hudson/model/Run/configure.jelly
          core/src/main/resources/hudson/model/User/configure.jelly
          core/src/main/resources/hudson/model/View/configure.jelly
          core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly
          core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy
          core/src/main/resources/jenkins/model/Jenkins/configure.jelly
          core/src/main/resources/lib/form/confirm.js
          http://jenkins-ci.org/commit/jenkins/fc471153db957be8d06d2fea63306e8b2f060462
          Log:
          Merge pull request #1175 from daniel-beck/JENKINS-21720-2

          [FIXED JENKINS-20597 JENKINS-21720] Improved config confirmation.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/resources/hudson/logging/LogRecorder/configure.jelly core/src/main/resources/hudson/model/Computer/configure.jelly core/src/main/resources/hudson/model/ComputerSet/_new.jelly core/src/main/resources/hudson/model/ComputerSet/configure.jelly core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/hudson/model/Run/configure.jelly core/src/main/resources/hudson/model/User/configure.jelly core/src/main/resources/hudson/model/View/configure.jelly core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy core/src/main/resources/jenkins/model/Jenkins/configure.jelly core/src/main/resources/lib/form/confirm.js http://jenkins-ci.org/commit/jenkins/fc471153db957be8d06d2fea63306e8b2f060462 Log: Merge pull request #1175 from daniel-beck/ JENKINS-21720 -2 [FIXED JENKINS-20597 JENKINS-21720] Improved config confirmation.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3321
          [FIXED JENKINS-21720] Improved config confirmation. (Revision d85b86e71921f3a43a1c49701f66a1ba2b23477d)
          JENKINS-21720 Added User, Run, ComputerSet, and LabelAtom (Revision cd0fae16f00805e63832c4009a4d6984622327c0)

          Result = SUCCESS
          daniel-beck : d85b86e71921f3a43a1c49701f66a1ba2b23477d
          Files :

          • core/src/main/resources/hudson/model/View/configure.jelly
          • core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy
          • core/src/main/resources/hudson/model/ComputerSet/_new.jelly
          • core/src/main/resources/hudson/logging/LogRecorder/configure.jelly
          • core/src/main/resources/jenkins/model/Jenkins/configure.jelly
          • core/src/main/resources/lib/form/confirm.js
          • core/src/main/resources/hudson/model/Computer/configure.jelly

          daniel-beck : cd0fae16f00805e63832c4009a4d6984622327c0
          Files :

          • core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly
          • core/src/main/resources/hudson/model/User/configure.jelly
          • core/src/main/resources/hudson/model/ComputerSet/configure.jelly
          • core/src/main/resources/hudson/model/Run/configure.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #3321 [FIXED JENKINS-21720] Improved config confirmation. (Revision d85b86e71921f3a43a1c49701f66a1ba2b23477d) JENKINS-21720 Added User, Run, ComputerSet, and LabelAtom (Revision cd0fae16f00805e63832c4009a4d6984622327c0) Result = SUCCESS daniel-beck : d85b86e71921f3a43a1c49701f66a1ba2b23477d Files : core/src/main/resources/hudson/model/View/configure.jelly core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy core/src/main/resources/hudson/model/ComputerSet/_new.jelly core/src/main/resources/hudson/logging/LogRecorder/configure.jelly core/src/main/resources/jenkins/model/Jenkins/configure.jelly core/src/main/resources/lib/form/confirm.js core/src/main/resources/hudson/model/Computer/configure.jelly daniel-beck : cd0fae16f00805e63832c4009a4d6984622327c0 Files : core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly core/src/main/resources/hudson/model/User/configure.jelly core/src/main/resources/hudson/model/ComputerSet/configure.jelly core/src/main/resources/hudson/model/Run/configure.jelly

            amuniz Antonio Muñiz
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: