Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22001

Do not solve JENKINS-19446 by delivering events asynchronously

XMLWordPrintable

      As I wrote there:

      The current fix is just no good. It delivers events asynchronously, which makes the system unpredictable, and ruins functional tests.
      Better IMHO would be to call just save() asynchronously.

          [JENKINS-22001] Do not solve JENKINS-19446 by delivering events asynchronously

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-19446 [ JENKINS-19446 ]
          Jesse Glick made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ] New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/a8117f59702e8a2ccdf3a9720924718b508b9b83
          Log:
          Updating comment to note JENKINS-22001.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/a8117f59702e8a2ccdf3a9720924718b508b9b83 Log: Updating comment to note JENKINS-22001 .

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractItem.java
          core/src/main/java/hudson/model/Job.java
          test/src/test/java/hudson/model/ListViewTest.java
          http://jenkins-ci.org/commit/jenkins/00d27176f3a452e38bd0caafebe78c7bc2fa822f
          Log:
          [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior.

          Compare: https://github.com/jenkinsci/jenkins/compare/334ce1be691c...00d27176f3a4

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/Job.java test/src/test/java/hudson/model/ListViewTest.java http://jenkins-ci.org/commit/jenkins/00d27176f3a452e38bd0caafebe78c7bc2fa822f Log: [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. Compare: https://github.com/jenkinsci/jenkins/compare/334ce1be691c...00d27176f3a4

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3204
          [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. (Revision 00d27176f3a452e38bd0caafebe78c7bc2fa822f)

          Result = SUCCESS
          Jesse Glick : 00d27176f3a452e38bd0caafebe78c7bc2fa822f
          Files :

          • test/src/test/java/hudson/model/ListViewTest.java
          • core/src/main/java/hudson/model/AbstractItem.java
          • core/src/main/java/hudson/model/Job.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3204 [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. (Revision 00d27176f3a452e38bd0caafebe78c7bc2fa822f) Result = SUCCESS Jesse Glick : 00d27176f3a452e38bd0caafebe78c7bc2fa822f Files : test/src/test/java/hudson/model/ListViewTest.java core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/Job.java

          Daniel Beck added a comment -

          @Jesse: Shouldn't this be closed?

          Daniel Beck added a comment - @Jesse: Shouldn't this be closed?

          Jesse Glick added a comment -

          Yes, JIRA link daemon must have been down.

          Jesse Glick added a comment - Yes, JIRA link daemon must have been down.
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: