• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • ec2-plugin
    • None

      EC2 allows you to spin up an instance with Dedicated tenancy or Default (multi-tenancy). There are some big performance differences if you create a lot of machines with default tenancy, and I can see a need for many people (including myself), who would like to be able to use dedicated tenancy for our slaves. It appears the AWS JDK supports tenancy as an option for slaves that are created, so this shouldn't be a difficult addition.

          [JENKINS-22141] Add Support for Dedicated Tenancy Option

          Ray Sennewald added a comment -

          Ray Sennewald added a comment - Added PR for this here: https://github.com/jenkinsci/ec2-plugin/pull/83 .

          Ray Sennewald added a comment -

          Went ahead and merged this in, all tests were passing and I added a new test to ensure this setting is set when we need it to be.

          Ray Sennewald added a comment - Went ahead and merged this in, all tests were passing and I added a new test to ensure this setting is set when we need it to be.

          Code changed in jenkins
          User: ray.sennewald@gmail.com
          Path:
          src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java
          src/main/java/hudson/plugins/ec2/EC2OndemandSlave.java
          src/main/java/hudson/plugins/ec2/EC2SpotSlave.java
          src/main/java/hudson/plugins/ec2/SlaveTemplate.java
          src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly
          src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
          src/main/resources/hudson/plugins/ec2/SlaveTemplate/help-useDedicatedTenancy.html
          src/test/java/hudson/plugins/ec2/EC2AbstractSlaveTest.java
          src/test/java/hudson/plugins/ec2/EC2OndemandSlaveTest.java
          src/test/java/hudson/plugins/ec2/EC2RetentionStrategyTest.java
          src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java
          src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java
          http://jenkins-ci.org/commit/ec2-plugin/4dd1bf148ddeb20f31109fb778394d79d6053f36
          Log:
          Implementing JENKINS-22141 Add Support for Dedicated Tenancy Option:

          • Added checkbox for dedicated tenancy to Slave Template.
          • Added help entry for dedicated tenancy option to clarify its usage.
          • Added support for dedicated tenancy for OnDemand Instances only, as this doesn't pertain to Spot Instances.
          • Updated SlaveTemplateTest.testConfigRoundtrip to ensure useDedicatedTenancy is set as expected.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ray.sennewald@gmail.com Path: src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java src/main/java/hudson/plugins/ec2/EC2OndemandSlave.java src/main/java/hudson/plugins/ec2/EC2SpotSlave.java src/main/java/hudson/plugins/ec2/SlaveTemplate.java src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly src/main/resources/hudson/plugins/ec2/SlaveTemplate/help-useDedicatedTenancy.html src/test/java/hudson/plugins/ec2/EC2AbstractSlaveTest.java src/test/java/hudson/plugins/ec2/EC2OndemandSlaveTest.java src/test/java/hudson/plugins/ec2/EC2RetentionStrategyTest.java src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java http://jenkins-ci.org/commit/ec2-plugin/4dd1bf148ddeb20f31109fb778394d79d6053f36 Log: Implementing JENKINS-22141 Add Support for Dedicated Tenancy Option: Added checkbox for dedicated tenancy to Slave Template. Added help entry for dedicated tenancy option to clarify its usage. Added support for dedicated tenancy for OnDemand Instances only, as this doesn't pertain to Spot Instances. Updated SlaveTemplateTest.testConfigRoundtrip to ensure useDedicatedTenancy is set as expected.

          Code changed in jenkins
          User: rsennewald
          Path:
          src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java
          src/main/java/hudson/plugins/ec2/EC2OndemandSlave.java
          src/main/java/hudson/plugins/ec2/EC2SpotSlave.java
          src/main/java/hudson/plugins/ec2/SlaveTemplate.java
          src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly
          src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
          src/main/resources/hudson/plugins/ec2/SlaveTemplate/help-useDedicatedTenancy.html
          src/test/java/hudson/plugins/ec2/EC2AbstractSlaveTest.java
          src/test/java/hudson/plugins/ec2/EC2OndemandSlaveTest.java
          src/test/java/hudson/plugins/ec2/EC2RetentionStrategyTest.java
          src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java
          src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java
          http://jenkins-ci.org/commit/ec2-plugin/c47cd08eb7dec5322abfcbe8d031280ed0ac1938
          Log:
          Merge pull request #83 from rsennewald/JENKINS-22141

          Implementing JENKINS-22141 Add Support for Dedicated Tenancy Option.

          Compare: https://github.com/jenkinsci/ec2-plugin/compare/941b9e0190e9...c47cd08eb7de

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsennewald Path: src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java src/main/java/hudson/plugins/ec2/EC2OndemandSlave.java src/main/java/hudson/plugins/ec2/EC2SpotSlave.java src/main/java/hudson/plugins/ec2/SlaveTemplate.java src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly src/main/resources/hudson/plugins/ec2/SlaveTemplate/help-useDedicatedTenancy.html src/test/java/hudson/plugins/ec2/EC2AbstractSlaveTest.java src/test/java/hudson/plugins/ec2/EC2OndemandSlaveTest.java src/test/java/hudson/plugins/ec2/EC2RetentionStrategyTest.java src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java http://jenkins-ci.org/commit/ec2-plugin/c47cd08eb7dec5322abfcbe8d031280ed0ac1938 Log: Merge pull request #83 from rsennewald/ JENKINS-22141 Implementing JENKINS-22141 Add Support for Dedicated Tenancy Option. Compare: https://github.com/jenkinsci/ec2-plugin/compare/941b9e0190e9...c47cd08eb7de

            rsennewald Ray Sennewald
            rsennewald Ray Sennewald
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: