Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22160

Fix findings from FindBugs static analysis

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • sloccount-plugin
    • None
    • All

      FindBugs reports several issues present in the code.

          [JENKINS-22160] Fix findings from FindBugs static analysis

          Michal Turek created issue -
          Michal Turek made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/hudson/plugins/sloccount/SloccountDiff.java
          src/main/java/hudson/plugins/sloccount/SloccountPublisher.java
          src/main/java/hudson/plugins/sloccount/SloccountResult.java
          src/main/java/hudson/plugins/sloccount/model/SloccountParser.java
          http://jenkins-ci.org/commit/sloccount-plugin/f336a1898e7699c22597abcf21861fd915fde943
          Log:
          JENKINS-22160 Fix findings from FindBugs static analysis

          • SloccountParser: Possible null pointer dereference.
          • SloccountDiff: Class defines compareTo(SloccountDiff) and uses Object.equals().
          • SloccountPublisher: Format string should use %n rather than \n.
          • BreadCrumbResult: Implements same interface as superclass.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/hudson/plugins/sloccount/SloccountDiff.java src/main/java/hudson/plugins/sloccount/SloccountPublisher.java src/main/java/hudson/plugins/sloccount/SloccountResult.java src/main/java/hudson/plugins/sloccount/model/SloccountParser.java http://jenkins-ci.org/commit/sloccount-plugin/f336a1898e7699c22597abcf21861fd915fde943 Log: JENKINS-22160 Fix findings from FindBugs static analysis SloccountParser: Possible null pointer dereference. SloccountDiff: Class defines compareTo(SloccountDiff) and uses Object.equals(). SloccountPublisher: Format string should use %n rather than \n. BreadCrumbResult: Implements same interface as superclass.

          Michal Turek added a comment -

          Fixed, will be released in version 1.16.

          Michal Turek added a comment - Fixed, will be released in version 1.16.
          Michal Turek made changes -
          Fix Version/s New: current [ 10162 ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Michal Turek made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/hudson/plugins/sloccount/SloccountResult.java
          http://jenkins-ci.org/commit/sloccount-plugin/88c7d07a4e6a2e24ddd34cfd8460d96985ad5370
          Log:
          JENKINS-22160 Fix findings from FindBugs static analysis

          • Private readResolve method in hudson.plugins.sloccount.SloccountResult not inherited by subclasses.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/hudson/plugins/sloccount/SloccountResult.java http://jenkins-ci.org/commit/sloccount-plugin/88c7d07a4e6a2e24ddd34cfd8460d96985ad5370 Log: JENKINS-22160 Fix findings from FindBugs static analysis Private readResolve method in hudson.plugins.sloccount.SloccountResult not inherited by subclasses.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/hudson/plugins/sloccount/SloccountResult.java
          http://jenkins-ci.org/commit/sloccount-plugin/8630fd143bce4b0ffe6e592b8e871c5891fdc058
          Log:
          Merge pull request #38 from mixalturek/master

          JENKINS-22160 Fix findings from FindBugs static analysis

          Compare: https://github.com/jenkinsci/sloccount-plugin/compare/2453b1e524c1...8630fd143bce

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/hudson/plugins/sloccount/SloccountResult.java http://jenkins-ci.org/commit/sloccount-plugin/8630fd143bce4b0ffe6e592b8e871c5891fdc058 Log: Merge pull request #38 from mixalturek/master JENKINS-22160 Fix findings from FindBugs static analysis Compare: https://github.com/jenkinsci/sloccount-plugin/compare/2453b1e524c1...8630fd143bce
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 154239 ] New: JNJira + In-Review [ 207504 ]

            mixalturek Michal Turek
            mixalturek Michal Turek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: