Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22262

copy-job permission checks wrong

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      copy-job checks CREATE on Jenkins root, when it only needs to do so on the actual target of the copy. Also it fails to check EXTENDED_READ on the source.

      create-job also checks CREATE needlessly on root.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          jglick Jesse Glick created issue -
          jglick Jesse Glick made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          jglick Jesse Glick made changes -
          Labels cli security cli folders security
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/cli/CopyJobCommand.java
          core/src/main/java/hudson/cli/CreateJobCommand.java
          core/src/main/java/hudson/model/ItemGroupMixIn.java
          test/src/test/java/hudson/cli/CopyJobCommandTest.java
          test/src/test/java/hudson/cli/CreateJobCommandTest.java
          http://jenkins-ci.org/commit/jenkins/8861563bd1e7fc28c5686f0dc9552529cfdfbf45
          Log:
          [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks.

          Compare: https://github.com/jenkinsci/jenkins/compare/aaa50018eef1...8861563bd1e7

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/cli/CopyJobCommand.java core/src/main/java/hudson/cli/CreateJobCommand.java core/src/main/java/hudson/model/ItemGroupMixIn.java test/src/test/java/hudson/cli/CopyJobCommandTest.java test/src/test/java/hudson/cli/CreateJobCommandTest.java http://jenkins-ci.org/commit/jenkins/8861563bd1e7fc28c5686f0dc9552529cfdfbf45 Log: [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. Compare: https://github.com/jenkinsci/jenkins/compare/aaa50018eef1...8861563bd1e7
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          Hide
          Permalink
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3243
          [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. (Revision 8861563bd1e7fc28c5686f0dc9552529cfdfbf45)

          Result = SUCCESS
          Jesse Glick : 8861563bd1e7fc28c5686f0dc9552529cfdfbf45
          Files :

          • core/src/main/java/hudson/cli/CreateJobCommand.java
          • test/src/test/java/hudson/cli/CreateJobCommandTest.java
          • changelog.html
          • test/src/test/java/hudson/cli/CopyJobCommandTest.java
          • core/src/main/java/hudson/model/ItemGroupMixIn.java
          • core/src/main/java/hudson/cli/CopyJobCommand.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3243 [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. (Revision 8861563bd1e7fc28c5686f0dc9552529cfdfbf45) Result = SUCCESS Jesse Glick : 8861563bd1e7fc28c5686f0dc9552529cfdfbf45 Files : core/src/main/java/hudson/cli/CreateJobCommand.java test/src/test/java/hudson/cli/CreateJobCommandTest.java changelog.html test/src/test/java/hudson/cli/CopyJobCommandTest.java core/src/main/java/hudson/model/ItemGroupMixIn.java core/src/main/java/hudson/cli/CopyJobCommand.java
          danielbeck Daniel Beck made changes -
          Labels cli folders security cli folders lts-candidate security
          olivergondza Oliver Gondža made changes -
          Labels cli folders lts-candidate security 1.554.1-fixed cli folders security
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 154343 ] JNJira + In-Review [ 194879 ]
          jglick Jesse Glick made changes -
          Link This issue relates to SECURITY-321 [ SECURITY-321 ]

            People

            Assignee:
            jglick Jesse Glick
            Reporter:
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: