Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22430

XFrame Filter Plugin forgets settings upon Jenkins restart

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • xframe-filter-plugin
    • CentOS 6.5
      Latest Jenkins version from repo
      Latest X-Filter Plugin installed via the Jenkins update center

    Description

      I'm using the XFrame Filter Plugin to allow Jenkins to be embedded into an iFrame. To make this work I need to set the X-Frame-Options Options configuration parameter to ALLOW-FROM http://my-address.

      This works fine but when I restart Jenkins (e.g. due to maintenance on the machine) the plugin looses the configuration and restores the value of "X-Frame-Options Options" to SAMEORIGIN which is odd because I have to re-configure the plugin after evey restart of Jenkins.

      Attachments

        Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-21881 Make X-Frame-Options configurable

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            skyvalley83 Marvin Kruse created issue -
            skyvalley83 Marvin Kruse added a comment -

            Fixed typo

            skyvalley83 Marvin Kruse added a comment - Fixed typo
            skyvalley83 Marvin Kruse made changes -
            Field Original Value New Value
            Description I'm using the XFrame Filter Plugin to allow Jenkins to be embedded into an iFrame. To make this work I need to set the X-Frame-Options Options configuration parameter to ALLOW-FORM http://my-address.

            This works fine but when I restart Jenkins (e.g. due to maintenance on the machine) the plugin looses the configuration and restores the value of "X-Frame-Options Options" to SAMEORIGIN which is odd because I have to re-configure the plugin after evey restart of Jenkins.             		I'm using the XFrame Filter Plugin to allow Jenkins to be embedded into an iFrame. To make this work I need to set the X-Frame-Options Options configuration parameter to ALLOW-FROM http://my-address.

            This works fine but when I restart Jenkins (e.g. due to maintenance on the machine) the plugin looses the configuration and restores the value of "X-Frame-Options Options" to SAMEORIGIN which is odd because I have to re-configure the plugin after evey restart of Jenkins.
            jieryn jieryn made changes -
            Assignee jieryn [ jieryn ]
            abubadabu Timm Drevensek made changes -
            Link This issue is related to JENKINS-21881 [ JENKINS-21881 ]
            gavinagoodtime Gavin Goodrich added a comment -

            For now...is there some place on disk we can set it to get reloaded on restart?

            gavinagoodtime Gavin Goodrich added a comment - For now...is there some place on disk we can set it to get reloaded on restart?
            jglick Jesse Glick made changes -
            Labels xframe configuration
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecorator.java
            src/test/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest.java
            src/test/resources/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest/configuration.zip
            http://jenkins-ci.org/commit/xframe-filter-plugin/39ca4304d4ceceeb9080638821262dcff6aa7505
            Log:
            [FIXED JENKINS-22430] Settings not loaded properly after restart.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecorator.java src/test/java/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest.java src/test/resources/org/jenkins/ci/plugins/xframe_filter/XFrameFilterPageDecoratorTest/configuration.zip http://jenkins-ci.org/commit/xframe-filter-plugin/39ca4304d4ceceeb9080638821262dcff6aa7505 Log: [FIXED JENKINS-22430] Settings not loaded properly after restart.
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 154531 ] JNJira + In-Review [ 194937 ]

            People

              jglick Jesse Glick
              skyvalley83 Marvin Kruse
              Votes:
              5 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: