Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22814

Some infomations are logged from constructor on startup

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • gerrit-trigger-plugin
    • None
    • JRE 1.7
      Jenkins 1.509.3
      Gerrit Trigger 2.12-beta-1

    Description

      Apr 30, 2014 2:35:23 PM com.sonyericsson.hudson.plugins.gerrit.trigger.replication.ReplicationCache <init>
      INFO: initialized replication cache with expiration in MINUTES: 360
      Apr 30, 2014 2:35:23 PM com.sonyericsson.hudson.plugins.gerrit.trigger.replication.ReplicationQueueTaskDispatcher <init>
      INFO: Registered to gerrit events
      Apr 30, 2014 2:35:23 PM com.sonyericsson.hudson.plugins.gerrit.trigger.dependency.DependencyQueueTaskDispatcher <init>
      INFO: Registered to gerrit events
      

      Attachments

        Activity

          Code changed in jenkins
          User: rinrinne
          Path:
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationCache.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcher.java
          src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationCacheTest.java
          src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcherTest.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/12b74ea3eb73145c242c75dcf4a35a6472a329c5
          Log:
          Catch implicit exception

          CacheBuilder.expireAfterWrite() has possibility to raise exception if
          expiration is negative. So cache object cannot be set to final member in
          ReplicationCache. Also its exception is not catched anywhere.

          This patch moves cache creation and logging to new method.
          And adds factory class for initializing ReplicationCache correctly.

          Fix for JENKINS-22814: Some infomations are logged from constructor on
          startup
          https://issues.jenkins-ci.org/browse/JENKINS-22814

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rinrinne Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationCache.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcher.java src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationCacheTest.java src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcherTest.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/12b74ea3eb73145c242c75dcf4a35a6472a329c5 Log: Catch implicit exception CacheBuilder.expireAfterWrite() has possibility to raise exception if expiration is negative. So cache object cannot be set to final member in ReplicationCache. Also its exception is not catched anywhere. This patch moves cache creation and logging to new method. And adds factory class for initializing ReplicationCache correctly. Fix for JENKINS-22814 : Some infomations are logged from constructor on startup https://issues.jenkins-ci.org/browse/JENKINS-22814

          Code changed in jenkins
          User: rinrinne
          Path:
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcher.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcher.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/1d9e0db8a0afba94fab21f740019cf421ccff266
          Log:
          Reduce level from info to debug

          In constructor of DependencyQueueTaskDispatcher and
          ReplicationQueueTaskDispatcher.

          Fix for JENKINS-22814: Some infomations are logged from constructor on
          startup
          https://issues.jenkins-ci.org/browse/JENKINS-22814

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rinrinne Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcher.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcher.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/1d9e0db8a0afba94fab21f740019cf421ccff266 Log: Reduce level from info to debug In constructor of DependencyQueueTaskDispatcher and ReplicationQueueTaskDispatcher. Fix for JENKINS-22814 : Some infomations are logged from constructor on startup https://issues.jenkins-ci.org/browse/JENKINS-22814
          rin_ne rin_ne added a comment -
          • ReplicationCache
            • Seems necessary but constructor has possibility to raise exception. So it should be moved to other methods.
          • ReplicationQueueTaskDispatcher, DependencyQueueTaskDispatcher
            • Needless info. So it should be debug level.
          rin_ne rin_ne added a comment - ReplicationCache Seems necessary but constructor has possibility to raise exception. So it should be moved to other methods. ReplicationQueueTaskDispatcher, DependencyQueueTaskDispatcher Needless info. So it should be debug level.

          People

            rsandell rsandell
            rin_ne rin_ne
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: