Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22936

Move rename infrastructure from Job to AbstractItem

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • core

      Job has some fairly complex infrastructure for handling renames:

      • the special textbox in configure.jelly
      • the handling in doConfigSubmit, including ProjectNamingStrategy integration, Apply vs. Save logic (including the tricky JENKINS-17401 fix), and the redirect
      • rename.jelly (and rename.properties)
      • doDoRename, with more checks and redirects

      Reimplementing all this in another item type (such as Folder) is rather painful, involving a lot of duplicated code and thus an inability to fix a bug once in one placeā€”or pick a different implementation, such as using a JavaScript dialog like we now use for deletion and other actions requiring confirmation.

      This code should be pulled up into AbstractItem for easy reuse, with some hooks for domain-specific validation (such as Job.isBuilding).

          [JENKINS-22936] Move rename infrastructure from Job to AbstractItem

          Jesse Glick created issue -
          Jesse Glick made changes -
          Labels Original: api dry New: api dry folders
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-17401 [ JENKINS-17401 ]
          Jesse Glick made changes -
          Link New: This issue is related to SECURITY-128 [ SECURITY-128 ]
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-18649 [ JENKINS-18649 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 155082 ] New: JNJira + In-Review [ 179008 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal CJP-1681 (Web Link)" [ 18984 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal OSS-2597 (Web Link)" [ 19369 ]
          Devin Nusbaum made changes -
          Assignee New: Devin Nusbaum [ dnusbaum ]
          Devin Nusbaum made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Devin Nusbaum made changes -
          Remote Link New: This issue links to "PR 3289 (Web Link)" [ 20067 ]

            dnusbaum Devin Nusbaum
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: