Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23041

Slave systemInfo page breaks when slave is offline

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      /computer/foo/systemInfo breaks when slave is offline, as the assumption of the class loader statistics system info is that there is a slave.

      • Remove the link to System Info when slave is offline, no reason to show it.
      • Make the page itself more robust when slave is offline to not show a thread dump.

          [JENKINS-23041] Slave systemInfo page breaks when slave is offline

          Daniel Beck created issue -
          Daniel Beck made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Daniel Beck added a comment -

          Daniel Beck added a comment - https://github.com/jenkinsci/jenkins/pull/1240

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
          core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly
          http://jenkins-ci.org/commit/jenkins/19a8a5a0e4dea0edba59770e4f63c62f3d1fd070
          Log:
          [FIX JENKINS-23041] Fix systemInfo for offline slaves

          • Don't show link in sidebar
          • Make systemInfo page more robust when accessed via URL

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly http://jenkins-ci.org/commit/jenkins/19a8a5a0e4dea0edba59770e4f63c62f3d1fd070 Log: [FIX JENKINS-23041] Fix systemInfo for offline slaves Don't show link in sidebar Make systemInfo page more robust when accessed via URL

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
          core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly
          http://jenkins-ci.org/commit/jenkins/e8b1a500c9b9bbccb792c902c914efcb31ca10c9
          Log:
          Merge pull request #1240 from daniel-beck/JENKINS-23041

          [FIX JENKINS-23041] Fix systemInfo for offline slaves

          Compare: https://github.com/jenkinsci/jenkins/compare/551c968c4690...e8b1a500c9b9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly http://jenkins-ci.org/commit/jenkins/e8b1a500c9b9bbccb792c902c914efcb31ca10c9 Log: Merge pull request #1240 from daniel-beck/ JENKINS-23041 [FIX JENKINS-23041] Fix systemInfo for offline slaves Compare: https://github.com/jenkinsci/jenkins/compare/551c968c4690...e8b1a500c9b9

          Daniel Beck added a comment -

          Merged towards 1.575.

          Daniel Beck added a comment - Merged towards 1.575.
          Daniel Beck made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3550
          [FIX JENKINS-23041] Fix systemInfo for offline slaves (Revision 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070)

          Result = SUCCESS
          daniel-beck : 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070
          Files :

          • core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly
          • core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #3550 [FIX JENKINS-23041] Fix systemInfo for offline slaves (Revision 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070) Result = SUCCESS daniel-beck : 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070 Files : core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
          Daniel Beck made changes -
          Labels New: lts-candidate
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 1.565.3-fixed

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: