Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23258

Sidebar URL should accept invalid URL

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • sidebar-link-plugin
    • None
    • Jenkins 1.540
      Sidebar Link 1.6

      Tried to enter a URL like the following which resulted in an empty link (no href attr in the anchor tag)

      http://perforce.internal.com:5500/@md=d&cd=/&c=5FN@/?ac=107&mx=100&jsf=Job&jsf=Status&jsf=Codeline&jsf=Description&jsf=Owner&jsf=Modified&jsf=Defect_Ref&jsf=Job_control&jsf=WorkItem_Ref&jsf=Job_Ref&jsf=Originator&ft=%28Status=qaready%20|%20%28Status=open%20%26%20Job_control=requested%29%29%20%26%20codeline=main

          [JENKINS-23258] Sidebar URL should accept invalid URL

          D Soa created issue -
          D Soa made changes -
          Summary Original: Complex sidebar link URL not saved New: Complex sidebar link URL doesn't work

          D Soa added a comment -

          Looks like it is the '|' that it doesn't like. Changing it to %7C worked.

          D Soa added a comment - Looks like it is the '|' that it doesn't like. Changing it to %7C worked.

          Kohsuke Kawaguchi added a comment -

          '|' is not a valid character in URL. See RFC-1738.

          Kohsuke Kawaguchi added a comment - '|' is not a valid character in URL. See RFC-1738.
          Kohsuke Kawaguchi made changes -
          Assignee New: Kohsuke Kawaguchi [ kohsuke ]
          Resolution New: Not A Defect [ 7 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Kohsuke Kawaguchi added a comment -

          ... although come to think of it, it's not clear why the plugin ends up silently dropping it. Reopening.

          Kohsuke Kawaguchi added a comment - ... although come to think of it, it's not clear why the plugin ends up silently dropping it. Reopening.
          Kohsuke Kawaguchi made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ]
          Resolution Original: Not A Defect [ 7 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

          Kohsuke Kawaguchi added a comment -

          Adjusting priority and summary to reflect the task at hand. Without knowing much about the plugin, there seems to be no reason why the plugin needs to enforce the URL syntax rule. It could just as well treat URLs as strings and let browsers do their things.

          Kohsuke Kawaguchi added a comment - Adjusting priority and summary to reflect the task at hand. Without knowing much about the plugin, there seems to be no reason why the plugin needs to enforce the URL syntax rule. It could just as well treat URLs as strings and let browsers do their things.
          Kohsuke Kawaguchi made changes -
          Issue Type Original: Bug [ 1 ] New: Improvement [ 4 ]
          Priority Original: Major [ 3 ] New: Minor [ 4 ]
          Summary Original: Complex sidebar link URL doesn't work New: Sidebar URL should accept invalid URL
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 155820 ] New: JNJira + In-Review [ 186207 ]

            kon Kalle Niemitalo
            dsoa D Soa
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: