SCM historically was tied to AbstractProject/AbstractBuild. It is necessary to break that dependency and allow other kinds of Job/Run to use this API (with modest accompanying changes in SCM plugins).

          [JENKINS-23365] Allow SCM to work with non-AbstractProject

          Jesse Glick created issue -
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/Cause.java
          core/src/main/java/hudson/model/listeners/SCMListener.java
          core/src/main/java/hudson/scm/AbstractScmTagAction.java
          core/src/main/java/hudson/scm/ChangeLogAnnotator.java
          core/src/main/java/hudson/scm/ChangeLogParser.java
          core/src/main/java/hudson/scm/ChangeLogSet.java
          core/src/main/java/hudson/scm/SCM.java
          core/src/main/java/hudson/scm/SCMDescriptor.java
          core/src/main/java/hudson/triggers/SCMTrigger.java
          core/src/main/java/jenkins/triggers/SCMTriggerItem.java
          http://jenkins-ci.org/commit/jenkins/7423d30e9e3599889597547295e1a8a659fb19d5
          Log:
          [FIXED JENKINS-23365] Noting merge of #1257.

          Compare: https://github.com/jenkinsci/jenkins/compare/c95777e47638...7423d30e9e35

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Cause.java core/src/main/java/hudson/model/listeners/SCMListener.java core/src/main/java/hudson/scm/AbstractScmTagAction.java core/src/main/java/hudson/scm/ChangeLogAnnotator.java core/src/main/java/hudson/scm/ChangeLogParser.java core/src/main/java/hudson/scm/ChangeLogSet.java core/src/main/java/hudson/scm/SCM.java core/src/main/java/hudson/scm/SCMDescriptor.java core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/java/jenkins/triggers/SCMTriggerItem.java http://jenkins-ci.org/commit/jenkins/7423d30e9e3599889597547295e1a8a659fb19d5 Log: [FIXED JENKINS-23365] Noting merge of #1257. Compare: https://github.com/jenkinsci/jenkins/compare/c95777e47638...7423d30e9e35
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3444
          [FIXED JENKINS-23365] Noting merge of #1257. (Revision 7423d30e9e3599889597547295e1a8a659fb19d5)

          Result = SUCCESS
          Jesse Glick : 7423d30e9e3599889597547295e1a8a659fb19d5
          Files :

          • core/src/main/java/hudson/model/listeners/SCMListener.java
          • core/src/main/java/hudson/scm/ChangeLogAnnotator.java
          • core/src/main/java/hudson/model/Cause.java
          • core/src/main/java/hudson/scm/ChangeLogParser.java
          • core/src/main/java/hudson/triggers/SCMTrigger.java
          • core/src/main/java/jenkins/triggers/SCMTriggerItem.java
          • core/src/main/java/hudson/scm/SCM.java
          • changelog.html
          • core/src/main/java/hudson/scm/SCMDescriptor.java
          • core/src/main/java/hudson/scm/ChangeLogSet.java
          • core/src/main/java/hudson/scm/AbstractScmTagAction.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3444 [FIXED JENKINS-23365] Noting merge of #1257. (Revision 7423d30e9e3599889597547295e1a8a659fb19d5) Result = SUCCESS Jesse Glick : 7423d30e9e3599889597547295e1a8a659fb19d5 Files : core/src/main/java/hudson/model/listeners/SCMListener.java core/src/main/java/hudson/scm/ChangeLogAnnotator.java core/src/main/java/hudson/model/Cause.java core/src/main/java/hudson/scm/ChangeLogParser.java core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/java/jenkins/triggers/SCMTriggerItem.java core/src/main/java/hudson/scm/SCM.java changelog.html core/src/main/java/hudson/scm/SCMDescriptor.java core/src/main/java/hudson/scm/ChangeLogSet.java core/src/main/java/hudson/scm/AbstractScmTagAction.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/hudson/plugins/mercurial/ChangeComparator.java
          src/main/java/hudson/plugins/mercurial/MercurialChangeLogParser.java
          src/main/java/hudson/plugins/mercurial/MercurialChangeSetList.java
          src/main/java/hudson/plugins/mercurial/MercurialRevisionColumn.java
          src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          src/main/java/hudson/plugins/mercurial/MercurialStatus.java
          src/main/java/hudson/plugins/mercurial/MercurialTagAction.java
          src/test/java/hudson/plugins/mercurial/MercurialChangeLogParserTest.java
          http://jenkins-ci.org/commit/mercurial-plugin/6a633e02bb19eba7d8d1f89f318f60e0bd76fc8e
          Log:
          JENKINS-23365 Draft SCM-Job rework.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/plugins/mercurial/ChangeComparator.java src/main/java/hudson/plugins/mercurial/MercurialChangeLogParser.java src/main/java/hudson/plugins/mercurial/MercurialChangeSetList.java src/main/java/hudson/plugins/mercurial/MercurialRevisionColumn.java src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/main/java/hudson/plugins/mercurial/MercurialStatus.java src/main/java/hudson/plugins/mercurial/MercurialTagAction.java src/test/java/hudson/plugins/mercurial/MercurialChangeLogParserTest.java http://jenkins-ci.org/commit/mercurial-plugin/6a633e02bb19eba7d8d1f89f318f60e0bd76fc8e Log: JENKINS-23365 Draft SCM-Job rework.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3454
          JENKINS-23365 Noting some nullness conditions; calcRevisionsFromBuild in particular is tricky. (Revision 9f16b223b3deaf5ca01f5e88139b695992fc8dd1)

          Result = SUCCESS
          Jesse Glick : 9f16b223b3deaf5ca01f5e88139b695992fc8dd1
          Files :

          • core/src/main/java/hudson/scm/SCM.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3454 JENKINS-23365 Noting some nullness conditions; calcRevisionsFromBuild in particular is tricky. (Revision 9f16b223b3deaf5ca01f5e88139b695992fc8dd1) Result = SUCCESS Jesse Glick : 9f16b223b3deaf5ca01f5e88139b695992fc8dd1 Files : core/src/main/java/hudson/scm/SCM.java
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-12298 [ JENKINS-12298 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/scm/SCM.java
          http://jenkins-ci.org/commit/jenkins/69f7b58d2d8596aab3444d40b7fb84f43cd8dc21
          Log:
          JENKINS-23365 Noting some nullness conditions; calcRevisionsFromBuild in particular is tricky.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/scm/SCM.java http://jenkins-ci.org/commit/jenkins/69f7b58d2d8596aab3444d40b7fb84f43cd8dc21 Log: JENKINS-23365 Noting some nullness conditions; calcRevisionsFromBuild in particular is tricky.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractBuild.java
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/hudson/scm/NullSCM.java
          core/src/main/java/hudson/scm/SCM.java
          http://jenkins-ci.org/commit/jenkins/df9dc4c850374daeeda72ee37177ba1fe2bcebd6
          Log:
          JENKINS-23365 Follow-up API fixes: introduce SCM.getKey(), and add an SCMRevisionState baseline argument to checkout.
          Necessary in order to produce correct changelogs by SCM plugins which actually use SCMRevisionState correctly (unlike git-plugin!).

          Compare: https://github.com/jenkinsci/jenkins/compare/3651b0f011dc...df9dc4c85037

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/scm/NullSCM.java core/src/main/java/hudson/scm/SCM.java http://jenkins-ci.org/commit/jenkins/df9dc4c850374daeeda72ee37177ba1fe2bcebd6 Log: JENKINS-23365 Follow-up API fixes: introduce SCM.getKey(), and add an SCMRevisionState baseline argument to checkout. Necessary in order to produce correct changelogs by SCM plugins which actually use SCMRevisionState correctly (unlike git-plugin!). Compare: https://github.com/jenkinsci/jenkins/compare/3651b0f011dc...df9dc4c85037

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: