Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
* Jenkins and plugins latest
* thousands of generated jobs by job-dsl plugin
* Nested view with lots of sectioned views
Description
If a job is inside a sectioned view (section view plugin) the view-base priority evaluation seems to be broken. Excerpt from log:
Evaluating JobGroup [21] ...
[...]
Evaluating View [Continuous] ...
[...}
Evaluating View [~NEVER-OPEN-THIS] ...
Using filter ...
Job is matching the filter ...
No applicable strategy - Using JobGroup default
Jun 17, 2014 9:26:28 AM FINE PrioritySorter.Queue.Items
Buildable: Id: 6076, JobName: DirectoryService_Tests, jobGroupId: 21, reason: <none>, priority: 5, weight: 5.0, status: BUILDABLE
The same Job "DirectoryService_Tests" is in the sectioned [Continuous] view but it is only evaluated in the view NEVER-OPEN-THIS which is a flat ALL jobs view.
Attachments
Activity
Code changed in jenkins
User: emsa23
Path:
pom.xml
src/main/java/jenkins/advancedqueue/PriorityConfiguration.java
src/test/java/jenkins/advancedqueue/test/SectionedViewTest.java
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/config.xml
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/jenkins.advancedqueue.PriorityConfiguration.xml
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/jenkins.advancedqueue.PrioritySorterConfiguration.xml
http://jenkins-ci.org/commit/priority-sorter-plugin/4ec547ee116f5e6f7a78d08e9af606c5813f74ec
Log:
JENKINS-23462 Sectioned views are not evaluated for job priority
- Need to use getItems() not getItem() to get the items in the View
- Added test-case for Sectioned View Plugin
Code changed in jenkins
User: emsa23
Path:
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/config.xml
http://jenkins-ci.org/commit/priority-sorter-plugin/47b129c07106bacc38b3c1a509461ce976b66b29
Log:
JENKINS-23462 Sectioned views are not evaluated for job priority
Updated test-case to include job by regex since this was the
the cause of the problem.
Thanks for you fast fix Magnus. I have a good and a bad message about it though
The good one: It seems to work, the jobs are found in the views and priorities are assigned as configured.
The bad one: It seems to be a real performance hog at least with our quite large installation.:-/ Jenkins UI was unusable after some time, after downgrading everything is back to normal.
Some facts: We have about 10000 Jobs, more than 20 views refering most of the jobs via regex pattern. So I could imagine that there are long lists of jobs being iterated while computing priorities.
Would it be a better approach for us to configure job priority directly on the job? That would be not a big deal because most of them are generated from template?
Should I open a new JIRA ticket? Or reopen this one?
Code changed in jenkins
User: emsa23
Path:
src/main/java/jenkins/advancedqueue/PriorityConfiguration.java
http://jenkins-ci.org/commit/priority-sorter-plugin/30567281338443e5f73d7790bbb6aefc4d0594b1
Log:
JENKINS-23462Sectioned views are not evaluated for job priorityHandling differences in implementations of contains() in
various View/ViewGroups