Since the last update the periodic refresh has started causing the wall display to flicker, showing "loading jobs..." every 60 seconds (or whatever I set the refresh rate to be).

      It used to work beautifully!

          [JENKINS-23620] The periodic refresh shows "loading jobs.."

          Lars Hagström created issue -

          Arran added a comment -

          What version were you on before?

          Arran added a comment - What version were you on before?

          I believe that I was on 0.6.24 or possibly 0.6.25..

          Lars Hagström added a comment - I believe that I was on 0.6.24 or possibly 0.6.25..

          I have an suggestion as to what the problem could be:

          My jenkins server is quite heavily loaded most of the time, and the API calls in getJenkinsApi (where updateRunning[viewName] is set) may take quite a long time. This causes the "loading jobs..." message to be displayed.

          You can check what it looks like on our jenkins server at https://projekt.consoden.se/safir//plugin/jenkinswalldisplay/walldisplay.html?viewName=Default&jenkinsUrl=https%3A%2F%2Fprojekt.consoden.se%2Fsafir%2F

          Lars Hagström added a comment - I have an suggestion as to what the problem could be: My jenkins server is quite heavily loaded most of the time, and the API calls in getJenkinsApi (where updateRunning [viewName] is set) may take quite a long time. This causes the "loading jobs..." message to be displayed. You can check what it looks like on our jenkins server at https://projekt.consoden.se/safir//plugin/jenkinswalldisplay/walldisplay.html?viewName=Default&jenkinsUrl=https%3A%2F%2Fprojekt.consoden.se%2Fsafir%2F

          Hmm, I've just had a vague flashback. It might be that I've previously gone in and commented out the "Loading jobs..." line in walldisplay.js...
          So it might be that the issue was introduced earlier than indicated above.
          Anyway, the issue goes away if I comment out that line in the current version. But I've left it in on my server so that you'll be able to see the issue.

          Lars Hagström added a comment - Hmm, I've just had a vague flashback. It might be that I've previously gone in and commented out the "Loading jobs..." line in walldisplay.js... So it might be that the issue was introduced earlier than indicated above. Anyway, the issue goes away if I comment out that line in the current version. But I've left it in on my server so that you'll be able to see the issue.

          I was suffering from this bug, I had to go back to 0.6.21.

          Benjamin Herbert added a comment - I was suffering from this bug, I had to go back to 0.6.21.

          We are seeing the same problems, occurs in all browsers.

          Jens-Martin Groenne added a comment - We are seeing the same problems, occurs in all browsers.

          Arran added a comment -

          My analysis of the issue is the problem started here (with the help of git bisect):

          https://github.com/jenkinsci/walldisplay-plugin/commit/69e9fe2e26fd6559ea5b6b5b313dfbcf07fd0305

          So 0.6.25

          It appears to occur when the repaint interval is set to less than the update interval, so sometimes the plugin can be unlucky and the update & it's various API requests haven't finished by the time the repaint comes along to redraw everything.

          Arran added a comment - My analysis of the issue is the problem started here (with the help of git bisect): https://github.com/jenkinsci/walldisplay-plugin/commit/69e9fe2e26fd6559ea5b6b5b313dfbcf07fd0305 So 0.6.25 It appears to occur when the repaint interval is set to less than the update interval, so sometimes the plugin can be unlucky and the update & it's various API requests haven't finished by the time the repaint comes along to redraw everything.

          No, that doesnt do it for me
          For example I set the update interval to 30 and the paint interval to 60, and that still causes occasional flashes (not quite as frequent, though).

          My best workaround is still commenting out the "Loading jobs..." line in walldisplay.js...

          Lars Hagström added a comment - No, that doesnt do it for me For example I set the update interval to 30 and the paint interval to 60, and that still causes occasional flashes (not quite as frequent, though). My best workaround is still commenting out the "Loading jobs..." line in walldisplay.js...

          Arran added a comment -

          On a second attempt, moving from setInterval to a recursive setTimeout doesn't fully remove the issue but does help the issue a lot.

          Arran added a comment - On a second attempt, moving from setInterval to a recursive setTimeout doesn't fully remove the issue but does help the issue a lot.

            Unassigned Unassigned
            donoregano Lars Hagström
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: