Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2366

Tag this build should be hidden

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • _unsorted
    • None
    • Platform: All, OS: All

    Description

      If a user is assigned Read only permission under overall, the link to Tag this
      is visible. User is redirected to the login page after entering the url to
      create the tag.

      Tag this link should be visible only if the user has been assigned Tag
      permission.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          vijaysl vijaysl created issue -
          mindless Alan Harder added a comment -

          I don't see this problem now when the build has no tags already.. I see both
          SubversionTagAction and CVSSCM.TagAction both check TAG permission and don't
          show the link if there are no tags yet.

          If the build does have a tag already, it does show the link (with different
          text.. instead of "Tag this build" it could be "Subversion tag" for example)..
          you can click this to see the existing tag(s).. the problem here is it also
          shows the form to create a new tag even if you don't have permission. If you
          submit the form it shows a permission error.

          I'll make it hide the form if you can't use it..

          mindless Alan Harder added a comment - I don't see this problem now when the build has no tags already.. I see both SubversionTagAction and CVSSCM.TagAction both check TAG permission and don't show the link if there are no tags yet. If the build does have a tag already, it does show the link (with different text.. instead of "Tag this build" it could be "Subversion tag" for example).. you can click this to see the existing tag(s).. the problem here is it also shows the form to create a new tag even if you don't have permission. If you submit the form it shows a permission error. I'll make it hide the form if you can't use it..
          mindless Alan Harder added a comment -

          Fixed in 1.269

          r13988
          main/core/src/main/java/hudson/scm/SubversionTagAction.java
          main/core/src/main/java/hudson/scm/CVSSCM.java
          main/core/src/main/resources/hudson/scm/SubversionTagAction/tagForm.jelly
          main/core/src/main/resources/hudson/scm/CVSSCM/TagAction/tagForm.jelly

          mindless Alan Harder added a comment - Fixed in 1.269 r13988 main/core/src/main/java/hudson/scm/SubversionTagAction.java main/core/src/main/java/hudson/scm/CVSSCM.java main/core/src/main/resources/hudson/scm/SubversionTagAction/tagForm.jelly main/core/src/main/resources/hudson/scm/CVSSCM/TagAction/tagForm.jelly
          mindless Alan Harder made changes -
          Field Original Value New Value
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          abayer Andrew Bayer made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 132439 ] JNJira + In-Review [ 201411 ]
          ircbot Jenkins IRC Bot made changes -
          Component/s _unsorted [ 19622 ]
          Component/s security [ 15508 ]

          People

            mindless Alan Harder
            vijaysl vijaysl
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: