-
Bug
-
Resolution: Fixed
-
Major
-
Jenkins 1.570, Window 7, JDK 7, MS IE 10.0.9200.16921 (32bit)
The page /computer/createItem cannot be displayed in IE 10.
Upon creating a new node, IE shuts down the page with an error and tries to reload it.
The reloaded page states "Error No mode given".
MS IE 10 can display the /computer/createItem page in compatibility mode.
The page also loads without errors on FF29 and Chrome33
Steps to reproduce:
- start a fresh Jenkins
- Open IE10 and navigate to /computer/ (Manage Jenkins - Manage Nodes)
- try to create a new node
[JENKINS-23724] Node creation page cannot be displayed in IE 10 (normal mode)
Martin Kutter
added a comment - The error is displayed as a notification: A problem with this page has caused Internet explorer to close and reopen the tab.
On reloading, IE shows an error page stating that it could not load the page.
Martin Kutter
added a comment - The error is displayed as a notification: A problem with this page has caused Internet explorer to close and reopen the tab .
On reloading, IE shows an error page stating that it could not load the page. 
Henrik Ygge
added a comment - I investigated this a bit.
For some reason IE10 decides to crash if document.getElementsByName is called (which is done in confirm.js) and there is an element with a name-attribute without a value. In this case the attribute came from the makeButton function in hudson-behaviour.js where the name was an empty string ("") which is not null but should probably still not be set on the element.
I have a created a pull request for this. It works locally for me, I hope I haven't broken anything. Attributes without value will no longer be set on buttons, which seems safe to me.
Henrik Ygge
added a comment - I investigated this a bit.
For some reason IE10 decides to crash if document.getElementsByName is called (which is done in confirm.js) and there is an element with a name-attribute without a value. In this case the attribute came from the makeButton function in hudson-behaviour.js where the name was an empty string ("") which is not null but should probably still not be set on the element.
I have a created a pull request for this. It works locally for me, I hope I haven't broken anything. Attributes without value will no longer be set on buttons, which seems safe to me. Henrik.... nice work tracking down the issue. I know Steven Christou has spent some time trying to track down the issue. https://github.com/jenkinsci/jenkins/pull/1346 is the PR, correct?
This ticket is a duplicate of the earlier JENKINS-17825
Henrik Ygge
added a comment - Thanks!
Yes, that is the pull request for the fix. Code changed in jenkins
User: Henrik Ygge
Path:
war/src/main/webapp/scripts/hudson-behavior.js
http://jenkins-ci.org/commit/jenkins/f6ec318cc217671725d2a680140bf4f3d95ecbfe
Log:
[FIXED JENKINS-23724]
For some reason IE10 craches when document.getElementsByName is called and there is an element with a name attribute but no value. In this case a button had a name attribute set with an empty string as the value.
Integrated in 
jenkins_main_trunk #3654
[FIXED JENKINS-23724] (Revision f6ec318cc217671725d2a680140bf4f3d95ecbfe)
Result = SUCCESS
tom.fennelly : f6ec318cc217671725d2a680140bf4f3d95ecbfe
Files :
- war/src/main/webapp/scripts/hudson-behavior.js
What's the error?