Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23770

populateJenkinsHome does not work for all Jenkins TYPEs

      Oliver, seems that the new implementation of JenkinsController#start does work only for a small subset of controllers:

                  try {
                      populateJenkinsHome(new File(JenkinsController.class.getResource("jenkins_updates").toURI()), false);
                  } catch (URISyntaxException ex) {
                      throw new AssertionError(ex);
                  }
      

      Most controllers throw an exception in populateJenkinsHome. Moreover, if using the jutServer.sh command, then the resource "jenkins_updates" is within a jar and the conversion to a URI fails with an exception.

      I already removed the exception for the TYPE=existing implementation: de8d094

          [JENKINS-23770] populateJenkinsHome does not work for all Jenkins TYPEs

          Jesse Glick added a comment -

          Fixed the case of JUT server at least.

          Jesse Glick added a comment - Fixed the case of JUT server at least.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/org/jenkinsci/test/acceptance/controller/ExistingJenkinsController.java
          src/main/java/org/jenkinsci/test/acceptance/controller/IJenkinsController.java
          src/main/java/org/jenkinsci/test/acceptance/controller/JenkinsController.java
          src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java
          src/main/java/org/jenkinsci/test/acceptance/controller/RemoteJenkinsController.java
          src/main/java/org/jenkinsci/test/acceptance/server/PooledJenkinsController.java
          http://jenkins-ci.org/commit/acceptance-test-harness/2fcffb2f76cccd5fd7a7f0bc7636f7a76007dc86
          Log:
          JENKINS-23770 Making JUT server (PooledJenkinsController) work again.
          c9b925d (@stephenc) introduced a populateJenkinsHome but only partly implemented it, in particular failing to implement in PooledJenkinsController and ExistingJenkinsController.
          c490ff8 (@ogondza) then made this mandatory for all tests.
          a62ba10 (@kohsuke) fixed one fatal problem with c490ff8 (by packing tool_installers.zip) but did not address this one.
          Not marking FIXED since this change does not yet address ExistingJenkinsController.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/test/acceptance/controller/ExistingJenkinsController.java src/main/java/org/jenkinsci/test/acceptance/controller/IJenkinsController.java src/main/java/org/jenkinsci/test/acceptance/controller/JenkinsController.java src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java src/main/java/org/jenkinsci/test/acceptance/controller/RemoteJenkinsController.java src/main/java/org/jenkinsci/test/acceptance/server/PooledJenkinsController.java http://jenkins-ci.org/commit/acceptance-test-harness/2fcffb2f76cccd5fd7a7f0bc7636f7a76007dc86 Log: JENKINS-23770 Making JUT server (PooledJenkinsController) work again. c9b925d (@stephenc) introduced a populateJenkinsHome but only partly implemented it, in particular failing to implement in PooledJenkinsController and ExistingJenkinsController. c490ff8 (@ogondza) then made this mandatory for all tests. a62ba10 (@kohsuke) fixed one fatal problem with c490ff8 (by packing tool_installers.zip) but did not address this one. Not marking FIXED since this change does not yet address ExistingJenkinsController.

          Oleg Nenashev added a comment -

          jglick drulli is it fixed now?

          Oleg Nenashev added a comment - jglick drulli is it fixed now?

          Ulli Hafner added a comment -

          I did not see these problems again for the controllers I'm using (LocalController, ExistingJenkinsController, PooledJenkinsController).

          Ulli Hafner added a comment - I did not see these problems again for the controllers I'm using (LocalController, ExistingJenkinsController, PooledJenkinsController).

            Unassigned Unassigned
            drulli Ulli Hafner
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: