Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23797

Update offline cause message picks incorrect message from DiskSpace cause

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      I assume it makes sense for user to change cause type from DiskSpace to UserCause.

      When it is done OfflineCause.toString() is called to populate the offline cause text field. In case of DiskSpaceMonitorDescriptor.DiskSpace it is the number of free bytes. The actual message should be used instead.

        Attachments

          Issue Links

            Activity

            Hide
            olivergondza Oliver Gondža added a comment -

            Should be fixed in 1.595.

            Show
            olivergondza Oliver Gondža added a comment - Should be fixed in 1.595.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3867
            [FIXED JENKINS-23797] Produce human readable output in DiskSpaceMonitorDescriptor.DiskSpace.toString() (Revision e382bbae1b0deefdce458eed72ce025eb91d1855)

            Result = SUCCESS
            ogondza : e382bbae1b0deefdce458eed72ce025eb91d1855
            Files :

            • core/src/main/resources/hudson/node_monitors/Messages_sv_SE.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_fr.properties
            • core/src/main/resources/hudson/node_monitors/Messages_nl.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt_BR.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_cs.properties
            • core/src/main/resources/hudson/node_monitors/Messages_pt_BR.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.properties
            • core/src/main/resources/hudson/node_monitors/Messages_cs.properties
            • core/src/main/resources/hudson/node_monitors/Messages_de.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_ja.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.jelly
            • core/src/main/resources/hudson/node_monitors/Messages.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_da.properties
            • core/src/main/resources/hudson/node_monitors/Messages_pt.properties
            • core/src/main/resources/hudson/node_monitors/Messages_es.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_es.properties
            • core/src/main/resources/hudson/node_monitors/Messages_ja.properties
            • core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
            • core/src/main/resources/hudson/node_monitors/Messages_da.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_zh_TW.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_de.properties
            • core/src/main/resources/hudson/node_monitors/Messages_fr.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_sv_SE.properties
            • core/src/main/resources/hudson/node_monitors/Messages_zh_TW.properties
            • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_nl.properties
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3867 [FIXED JENKINS-23797] Produce human readable output in DiskSpaceMonitorDescriptor.DiskSpace.toString() (Revision e382bbae1b0deefdce458eed72ce025eb91d1855) Result = SUCCESS ogondza : e382bbae1b0deefdce458eed72ce025eb91d1855 Files : core/src/main/resources/hudson/node_monitors/Messages_sv_SE.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_fr.properties core/src/main/resources/hudson/node_monitors/Messages_nl.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt_BR.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_cs.properties core/src/main/resources/hudson/node_monitors/Messages_pt_BR.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.properties core/src/main/resources/hudson/node_monitors/Messages_cs.properties core/src/main/resources/hudson/node_monitors/Messages_de.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_ja.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.jelly core/src/main/resources/hudson/node_monitors/Messages.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_da.properties core/src/main/resources/hudson/node_monitors/Messages_pt.properties core/src/main/resources/hudson/node_monitors/Messages_es.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_es.properties core/src/main/resources/hudson/node_monitors/Messages_ja.properties core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java core/src/main/resources/hudson/node_monitors/Messages_da.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_zh_TW.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_de.properties core/src/main/resources/hudson/node_monitors/Messages_fr.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_sv_SE.properties core/src/main/resources/hudson/node_monitors/Messages_zh_TW.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_nl.properties
            Hide
            olivergondza Oliver Gondža added a comment -

            Daniel Beck exactly. Rephrasing the description.

            Show
            olivergondza Oliver Gondža added a comment - Daniel Beck exactly. Rephrasing the description.
            Hide
            danielbeck Daniel Beck added a comment -

            To clarify, OfflineCause.toString() is called to populate the text field into which the user enters the offline description?

            Show
            danielbeck Daniel Beck added a comment - To clarify, OfflineCause.toString() is called to populate the text field into which the user enters the offline description?

              People

              Assignee:
              olivergondza Oliver Gondža
              Reporter:
              olivergondza Oliver Gondža
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: