Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23797

Update offline cause message picks incorrect message from DiskSpace cause

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None

      I assume it makes sense for user to change cause type from DiskSpace to UserCause.

      When it is done OfflineCause.toString() is called to populate the offline cause text field. In case of DiskSpaceMonitorDescriptor.DiskSpace it is the number of free bytes. The actual message should be used instead.

          [JENKINS-23797] Update offline cause message picks incorrect message from DiskSpace cause

          Oliver Gondža created issue -

          Daniel Beck added a comment -

          To clarify, OfflineCause.toString() is called to populate the text field into which the user enters the offline description?

          Daniel Beck added a comment - To clarify, OfflineCause.toString() is called to populate the text field into which the user enters the offline description?
          Oliver Gondža made changes -
          Description Original: I assume it makes sense for user to change cause type from {{DiskSpace}} to {{UserCause}}.

          When it is done {{OfflineCause.toString()}} is called to provide the original message. In case of {{DiskSpaceMonitorDescriptor.DiskSpace}} it is the number of free bytes. The actual message should be used instead.           		New: I assume it makes sense for user to change cause type from {{DiskSpace}} to {{UserCause}}.

          When it is done {{OfflineCause.toString()}} is called to populate the offline cause text field. In case of {{DiskSpaceMonitorDescriptor.DiskSpace}} it is the number of free bytes. The actual message should be used instead.

          Oliver Gondža added a comment -

          danielbeck exactly. Rephrasing the description.

          Oliver Gondža added a comment - danielbeck exactly. Rephrasing the description.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3867
          [FIXED JENKINS-23797] Produce human readable output in DiskSpaceMonitorDescriptor.DiskSpace.toString() (Revision e382bbae1b0deefdce458eed72ce025eb91d1855)

          Result = SUCCESS
          ogondza : e382bbae1b0deefdce458eed72ce025eb91d1855
          Files :

          • core/src/main/resources/hudson/node_monitors/Messages_sv_SE.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_fr.properties
          • core/src/main/resources/hudson/node_monitors/Messages_nl.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt_BR.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_cs.properties
          • core/src/main/resources/hudson/node_monitors/Messages_pt_BR.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.properties
          • core/src/main/resources/hudson/node_monitors/Messages_cs.properties
          • core/src/main/resources/hudson/node_monitors/Messages_de.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_ja.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.jelly
          • core/src/main/resources/hudson/node_monitors/Messages.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_da.properties
          • core/src/main/resources/hudson/node_monitors/Messages_pt.properties
          • core/src/main/resources/hudson/node_monitors/Messages_es.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_es.properties
          • core/src/main/resources/hudson/node_monitors/Messages_ja.properties
          • core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
          • core/src/main/resources/hudson/node_monitors/Messages_da.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_zh_TW.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_de.properties
          • core/src/main/resources/hudson/node_monitors/Messages_fr.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_sv_SE.properties
          • core/src/main/resources/hudson/node_monitors/Messages_zh_TW.properties
          • core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_nl.properties

          dogfood added a comment - Integrated in jenkins_main_trunk #3867 [FIXED JENKINS-23797] Produce human readable output in DiskSpaceMonitorDescriptor.DiskSpace.toString() (Revision e382bbae1b0deefdce458eed72ce025eb91d1855) Result = SUCCESS ogondza : e382bbae1b0deefdce458eed72ce025eb91d1855 Files : core/src/main/resources/hudson/node_monitors/Messages_sv_SE.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_fr.properties core/src/main/resources/hudson/node_monitors/Messages_nl.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt_BR.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_cs.properties core/src/main/resources/hudson/node_monitors/Messages_pt_BR.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.properties core/src/main/resources/hudson/node_monitors/Messages_cs.properties core/src/main/resources/hudson/node_monitors/Messages_de.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_ja.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.jelly core/src/main/resources/hudson/node_monitors/Messages.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_da.properties core/src/main/resources/hudson/node_monitors/Messages_pt.properties core/src/main/resources/hudson/node_monitors/Messages_es.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_es.properties core/src/main/resources/hudson/node_monitors/Messages_ja.properties core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java core/src/main/resources/hudson/node_monitors/Messages_da.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_zh_TW.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_pt.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_de.properties core/src/main/resources/hudson/node_monitors/Messages_fr.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_sv_SE.properties core/src/main/resources/hudson/node_monitors/Messages_zh_TW.properties core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause_nl.properties
          Oliver Gondža made changes -
          Assignee New: Oliver Gondža [ olivergondza ]

          Oliver Gondža added a comment -

          Should be fixed in 1.595.

          Oliver Gondža added a comment - Should be fixed in 1.595.
          Oliver Gondža made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Oliver Gondža made changes -
          Link New: This issue is related to JENKINS-29286 [ JENKINS-29286 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 156587 ] New: JNJira + In-Review [ 195465 ]

            olivergondza Oliver Gondža
            olivergondza Oliver Gondža
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: