• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • timestamper-plugin
    • None
    • Jenkins 1.57x, Windows 2008 R2 Server master, Windows 7 clients, Chrome35

      Since updating to 1.5.12 of the time-stamper plugin the live-update of the console output is broken for me. Downgrading to 1.5.11 fixes the problem. I supected a core change but discussion on the jenkins-user list gave the right clue to try to downgrade the timestamper plugin.

      In this discussion another user reported the following firebug error, maybe that's helpful:

      Firebug reports this error after receiving a successful POST from http://

      {...}

      /logText/progressiveHtml :
      TypeError: container is null
      http://jenkins-url/static/4a3b5c01/scripts/prototype.js
      Line 1798

          [JENKINS-23867] Incompatibility with Jenkins 1.572 or later

          I was able to reproduce this with any 1.5.* Timestamper, as long as I was running Jenkins 1.572 or later.

          The console does not update on its own, and the timestamp settings UI (choose clock time, elapsed time or none) does not appear.

          Steven G Brown added a comment - I was able to reproduce this with any 1.5.* Timestamper, as long as I was running Jenkins 1.572 or later. The console does not update on its own, and the timestamp settings UI (choose clock time, elapsed time or none) does not appear.

          New div layout does not have an element with id 'navigation' causing the javascript to fail.

          I have submitted a pull request to fix this: https://github.com/jenkinsci/timestamper-plugin/pull/9

          all feedback welcome
          thanks
          Geoff

          Geoff Cummings added a comment - New div layout does not have an element with id 'navigation' causing the javascript to fail. I have submitted a pull request to fix this: https://github.com/jenkinsci/timestamper-plugin/pull/9 all feedback welcome thanks Geoff

          Code changed in jenkins
          User: gcummings
          Path:
          src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js
          http://jenkins-ci.org/commit/timestamper-plugin/f1f5cede0830c8fb69ff281770c808d1320c47ed
          Log:
          JENKINS-23867 - updating javascript to work with new core div layout in 1.572

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: gcummings Path: src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js http://jenkins-ci.org/commit/timestamper-plugin/f1f5cede0830c8fb69ff281770c808d1320c47ed Log: JENKINS-23867 - updating javascript to work with new core div layout in 1.572

          Code changed in jenkins
          User: StevenGBrown
          Path:
          src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js
          http://jenkins-ci.org/commit/timestamper-plugin/eaaeef10b89e7f69c36877005d82a96cd4c8dba6
          Log:
          Merge pull request #9 from gcummings/JENKINS-23867

          [FIXED JENKINS-23867] Update javascript to work with new core div layout in Jenkins 1.572

          Compare: https://github.com/jenkinsci/timestamper-plugin/compare/ff832f29297d...eaaeef10b89e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: StevenGBrown Path: src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js http://jenkins-ci.org/commit/timestamper-plugin/eaaeef10b89e7f69c36877005d82a96cd4c8dba6 Log: Merge pull request #9 from gcummings/ JENKINS-23867 [FIXED JENKINS-23867] Update javascript to work with new core div layout in Jenkins 1.572 Compare: https://github.com/jenkinsci/timestamper-plugin/compare/ff832f29297d...eaaeef10b89e

          Code changed in jenkins
          User: Steven Brown
          Path:
          src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js
          http://jenkins-ci.org/commit/timestamper-plugin/2caf23e6504b93b5a929f686e3eab349d5a58b13
          Log:
          JENKINS-23867 Fail gracefully the next time that the Jenkins UI changes

          If neither the 'side-panel-content' element or the 'navigation' element is
          found, return from the function. Otherwise an error would be thrown which
          can break other behaviour in Jenkins.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Brown Path: src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/script.js http://jenkins-ci.org/commit/timestamper-plugin/2caf23e6504b93b5a929f686e3eab349d5a58b13 Log: JENKINS-23867 Fail gracefully the next time that the Jenkins UI changes If neither the 'side-panel-content' element or the 'navigation' element is found, return from the function. Otherwise an error would be thrown which can break other behaviour in Jenkins.

          Steven G Brown added a comment - - edited

          This is fixed in Timestamper 1.5.13.

          If you are still seeing this problem, try refreshing with Ctrl+F5.
          http://en.wikipedia.org/wiki/Wikipedia:Bypass_your_cache

          Steven G Brown added a comment - - edited This is fixed in Timestamper 1.5.13. If you are still seeing this problem, try refreshing with Ctrl+F5. http://en.wikipedia.org/wiki/Wikipedia:Bypass_your_cache

          Dirk Kuypers added a comment -

          Sorry Steven, the problem is not fixed for me.

          I am still getting no progress in console output even when using Ctrl + F5.

          We are now using 1.574 and timestamper 1.5.13, I am using Chrome 36.

          Please note that my first description mentioned that my problem went away when downgrading to 1.5.11. Must be something else that has nothing to do with the UI enhancements after 1.572.

          Dirk Kuypers added a comment - Sorry Steven, the problem is not fixed for me. I am still getting no progress in console output even when using Ctrl + F5. We are now using 1.574 and timestamper 1.5.13, I am using Chrome 36. Please note that my first description mentioned that my problem went away when downgrading to 1.5.11. Must be something else that has nothing to do with the UI enhancements after 1.572.

          Hmm, I'm not able to reproduce that here. Can you give me instructions?

          Steven G Brown added a comment - Hmm, I'm not able to reproduce that here. Can you give me instructions?

          Dirk Kuypers added a comment -

          Hm, maybe it has something to do with our Jenkins instance running inside TOMCAT?

          I am no web developer at all, I just installed Firebug and watched a console log.

          It says:
          POST logText/progressiveHtml
          400 Bad Request
          9ms

          X-Requested-With XMLHttpRequest
          X-Prototype-Version 1.7
          Accept text/javascript, text/html, application/xml, text/xml, /
          Content-type application/x-www-form-urlencoded; charset=UTF-8
          X-ConsoleAnnotator CfFWnogZhdvgnyjZWUp2Rl1RIZUjCgdBEGKRj0u3Ka67ePzonjQMfryJ7cJoItYR/kFd2JtjWzlEdCVsr0aiA6y1IHq1dn0TMVvjiOZyC1gC/WW27p+qPDC0dVmJ6kt5lZFFNKIe9xyGXB6K+BSwaiOxYl/Ry/OCOlYoB1g9O/iXt1W/Lum9c+Fl4Lf2Uw1H2M496ZvEc13R8twCTQ3/fVbnjbZgqoMjCc1AaSLhI5PIHbwei41Vfs/B3ZYY

          Anything more I could do to help you?

          Dirk Kuypers added a comment - Hm, maybe it has something to do with our Jenkins instance running inside TOMCAT? I am no web developer at all, I just installed Firebug and watched a console log. It says: POST logText/progressiveHtml 400 Bad Request 9ms X-Requested-With XMLHttpRequest X-Prototype-Version 1.7 Accept text/javascript, text/html, application/xml, text/xml, / Content-type application/x-www-form-urlencoded; charset=UTF-8 X-ConsoleAnnotator CfFWnogZhdvgnyjZWUp2Rl1RIZUjCgdBEGKRj0u3Ka67ePzonjQMfryJ7cJoItYR/kFd2JtjWzlEdCVsr0aiA6y1IHq1dn0TMVvjiOZyC1gC/WW27p+qPDC0dVmJ6kt5lZFFNKIe9xyGXB6K+BSwaiOxYl/Ry/OCOlYoB1g9O/iXt1W/Lum9c+Fl4Lf2Uw1H2M496ZvEc13R8twCTQ3/fVbnjbZgqoMjCc1AaSLhI5PIHbwei41Vfs/B3ZYY Anything more I could do to help you?

          A. Kirby added a comment -

          I also am having issues. The plugin worked until 1.572 was released. I uninstalled it since it was having an impact on my console output. When I saw that the latest resolved the issues, I re-installed it but it still doesn't work. I do see the script.js being loaded so I walked the code. Since the span.timestamper isn't being added to the DOM the script.js does nothing. I used a little jQuery to add the span in myself, and it did render the radio buttons but the timestamps still didn't show up. Something in the plugin isn't inserting the span needed for the script to work, and there could be something else wrong that's not allowing the console output to show the timestamps. I am running Jenkins 1.573 now and the latest Timestamper plugin. I have used Chrome, IE and FF, flushed my cache and tried different machines. I believe the problem is in the plugin.

          A. Kirby added a comment - I also am having issues. The plugin worked until 1.572 was released. I uninstalled it since it was having an impact on my console output. When I saw that the latest resolved the issues, I re-installed it but it still doesn't work. I do see the script.js being loaded so I walked the code. Since the span.timestamper isn't being added to the DOM the script.js does nothing. I used a little jQuery to add the span in myself, and it did render the radio buttons but the timestamps still didn't show up. Something in the plugin isn't inserting the span needed for the script to work, and there could be something else wrong that's not allowing the console output to show the timestamps. I am running Jenkins 1.573 now and the latest Timestamper plugin. I have used Chrome, IE and FF, flushed my cache and tried different machines. I believe the problem is in the plugin.

          Code changed in jenkins
          User: Steven Brown
          Path:
          src/main/java/hudson/plugins/timestamper/TimestamperConfig.java
          src/main/java/hudson/plugins/timestamper/format/TimestampFormatterImpl.java
          src/test/java/hudson/plugins/timestamper/format/TimestampFormatterImplTest.java
          http://jenkins-ci.org/commit/timestamper-plugin/6fce098d374ee8db610230f163b952ae9ad68ee7
          Log:
          JENKINS-23867 Reduce the size of the X-ConsoleAnnotator HTTP header

          The data in the header is now the same as it was at the time of the 1.5.11
          Timestamper release.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Brown Path: src/main/java/hudson/plugins/timestamper/TimestamperConfig.java src/main/java/hudson/plugins/timestamper/format/TimestampFormatterImpl.java src/test/java/hudson/plugins/timestamper/format/TimestampFormatterImplTest.java http://jenkins-ci.org/commit/timestamper-plugin/6fce098d374ee8db610230f163b952ae9ad68ee7 Log: JENKINS-23867 Reduce the size of the X-ConsoleAnnotator HTTP header The data in the header is now the same as it was at the time of the 1.5.11 Timestamper release.

          Dirk, could you do me a favour? Give this version a try and let me know whether you still get 400 Bad Request.

          https://jenkins.ci.cloudbees.com/job/plugins/job/timestamper-plugin/67/org.jenkins-ci.plugins$timestamper/

          Steven G Brown added a comment - Dirk, could you do me a favour? Give this version a try and let me know whether you still get 400 Bad Request. https://jenkins.ci.cloudbees.com/job/plugins/job/timestamper-plugin/67/org.jenkins-ci.plugins$timestamper/

          Dirk Kuypers added a comment -

          I will do, but it could be that the next window for a restart will take another 24 hours.

          Dirk Kuypers added a comment - I will do, but it could be that the next window for a restart will take another 24 hours.

          Dirk Kuypers added a comment -

          Steven, good Job! It works again. Thanks!

          Dirk Kuypers added a comment - Steven, good Job! It works again. Thanks!

          Great, that's good news. I've prepared a 1.5.14 release with that fix.

          I appreciate your help. Thanks, Dirk.

          Steven G Brown added a comment - Great, that's good news. I've prepared a 1.5.14 release with that fix. I appreciate your help. Thanks, Dirk.

          A. Kirby added a comment -

          I downloaded the 1.5.14-SNAPSHOT package and installed it on my Jenkins test server. I am still not seeing the timestamper. I'm still seeing the same issue where the timestamp span isn't being rendered on the page causing the jquery code to not bind. Even if I use jquery to insert the missing span, timestamper still doesn't want to render the timestamps in the console output. I have tried uninstalling, rebooting the server, manually deleting the plugin and downgrading the plugin. With the rollout of 1.572 this plugin has completely stopped working for me. I am using 1.574 and I keep upgrading hoping that either a newer Jenkins or a newer plugin will resolve the problem.

          A. Kirby added a comment - I downloaded the 1.5.14-SNAPSHOT package and installed it on my Jenkins test server. I am still not seeing the timestamper. I'm still seeing the same issue where the timestamp span isn't being rendered on the page causing the jquery code to not bind. Even if I use jquery to insert the missing span, timestamper still doesn't want to render the timestamps in the console output. I have tried uninstalling, rebooting the server, manually deleting the plugin and downgrading the plugin. With the rollout of 1.572 this plugin has completely stopped working for me. I am using 1.574 and I keep upgrading hoping that either a newer Jenkins or a newer plugin will resolve the problem.

          A. Kirby,

          Could you clarify what problems you are experiencing? I think that your timestamps are not appearing, and also something else went wrong that prompted you to uninstall the plugin?

          Steven G Brown added a comment - A. Kirby, Could you clarify what problems you are experiencing? I think that your timestamps are not appearing, and also something else went wrong that prompted you to uninstall the plugin?

          A. Kirby added a comment -

          Steve,

          I had timestamper installed and working for a while, then I upgraded jenkins to 1.572 and it stopped working. I tried uninstalling timestamp, installing it again, upgrading to the latest and upgrading jenkins to 1.573 and now 1.574. I have the latest version of timestamper installed; the 1.5.14 snapshot and it's still not working. The first thing I have noticed is the span.timestamp tag isn't being inserted into the side panel. In script.js it looks for this to bind to, but the plugin isn't inserting it into the DOM. If I use a little jquery to create the span myself, it does render the radio buttons and even binds the events. However, it still doesn't render the information in the console output. It seems like although the plugin is installed, and is enabled, it's not being executed correctly if at all. I do see the settings in the Manage Jenkins -> Configure System -> Timestamper section.

          A. Kirby added a comment - Steve, I had timestamper installed and working for a while, then I upgraded jenkins to 1.572 and it stopped working. I tried uninstalling timestamp, installing it again, upgrading to the latest and upgrading jenkins to 1.573 and now 1.574. I have the latest version of timestamper installed; the 1.5.14 snapshot and it's still not working. The first thing I have noticed is the span.timestamp tag isn't being inserted into the side panel. In script.js it looks for this to bind to, but the plugin isn't inserting it into the DOM. If I use a little jquery to create the span myself, it does render the radio buttons and even binds the events. However, it still doesn't render the information in the console output. It seems like although the plugin is installed, and is enabled, it's not being executed correctly if at all. I do see the settings in the Manage Jenkins -> Configure System -> Timestamper section.

          OK, here are some things to try:

          • On the project configuration page, make sure the "Add Timestamps to the Console Output" option (found under "Build Environment) is enabled.
          • Check for errors in your web server's log file when running a build and when viewing the console.
          • Attach the contents of the timestamper directory to this JIRA issue. You should see at least two files: "timestamps" and "timestamps.SHA-1".

          Steven G Brown added a comment - OK, here are some things to try: On the project configuration page, make sure the "Add Timestamps to the Console Output" option (found under "Build Environment) is enabled. Check for errors in your web server's log file when running a build and when viewing the console. Attach the contents of the timestamper directory to this JIRA issue. You should see at least two files: "timestamps" and "timestamps.SHA-1".

          A. Kirby added a comment -

          Thanks Steve. I don't recall checking this in the previous releases and I didn't think to look at the project configuration to enable the plugin, but that's what the problem was. The "Add Timestamps to the Console Output" wasn't checked. Things are working now.

          A. Kirby added a comment - Thanks Steve. I don't recall checking this in the previous releases and I didn't think to look at the project configuration to enable the plugin, but that's what the problem was. The "Add Timestamps to the Console Output" wasn't checked. Things are working now.

          Great. Happy to help.

          Steven G Brown added a comment - Great. Happy to help.

            stevengbrown Steven G Brown
            bruce Dirk Kuypers
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: